skia2/tests/sksl/errors/VoidInStruct.glsl

### Compilation failed:

error: 5: type 'void' may not be used in an array
    void b[2];
    ^^^^^^^^^
error: 6: type 'void' may not be used in an array
    void[2] c;
    ^^^^^^^
error: 7: type 'void' may not be used in an array
    void[2] d[2];
    ^^^^^^^
error: 4: type 'void' is not permitted in a struct
    void a;
    ^^^^^^
4 errors
Fix assertion when arrays are double-declared. Multi-dimensional arrays aren't legal in GLSL/SkSL, so this should be caught and flagged as an error. The parser now verifies that a variable's type isn't an array-type before accepting a `[` token to open an array on the variable name. This CL also refactors the IR generator's `convertArraySize` method to make sure that various checks are made for all callers. Originally this restructuring was used to verify array multi-dimensionality, but that didn't detect errors inside struct declarations (which get no error checking inside the IR generator) so the IR generator updates no longer need to check the array dimensions. Bug: skia:11322 Change-Id: Id33f4bdfb544019ddf995a8196c3c09cfe5a4525 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/369916 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2021-02-12 22:07:51 +00:00			`### Compilation failed:`

Reenable DSLParser Change-Id: I1819b2c40902611d7e86245bff73ad8c2bd7629c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/449060 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-09-16 14:42:24 +00:00			`error: 5: type 'void' may not be used in an array`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`void b[2];`
			`^^^^^^^^^`
Reenable DSLParser Change-Id: I1819b2c40902611d7e86245bff73ad8c2bd7629c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/449060 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-09-16 14:42:24 +00:00			`error: 6: type 'void' may not be used in an array`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`void[2] c;`
			`^^^^^^^`
Add test for void type in struct. Mysteriously, I had written a test which put arrays of void inside a struct, but had neglected to include the non-array case. It causes an okay-not-great error (referring to void as an "opaque type"). Change-Id: Id20a9d3512d29aecea81d46877dce708b7b2f973 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/472450 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2021-11-17 14:57:11 +00:00			`error: 7: type 'void' may not be used in an array`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`void[2] d[2];`
			`^^^^^^^`
Remove void from the list of opaque types. `void` behaves differently from opaque types in several situations, such as function return types, and errors involving `void` should not call it an opaque type. I've fixed all the places where we relied on `isOpaque` to return catch void types. Change-Id: I359c00f836be6e56cb0373beff60cf2ff830f77b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/472451 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> 2021-11-17 14:57:29 +00:00			`error: 4: type 'void' is not permitted in a struct`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`void a;`
			`^^^^^^`
Add test for void type in struct. Mysteriously, I had written a test which put arrays of void inside a struct, but had neglected to include the non-array case. It causes an okay-not-great error (referring to void as an "opaque type"). Change-Id: Id20a9d3512d29aecea81d46877dce708b7b2f973 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/472450 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2021-11-17 14:57:11 +00:00			`4 errors`