AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
8c1fe9f743
skia2/tests/PreChopPathCurvesTest.cpp

43 lines
2.0 KiB
C++
Raw Normal View History

Make path pre-chopping more robust Exceptionally large control points might require us to chop the path very deeply. This CL converts the recursive chopping to loop with a stack of control points on the heap, in order to avoid the risk of stack overflow. It also adds a bail condition to avoid getting stuck in endless recursion due to fp32 precision issues. Bug: chromium:1266446 Change-Id: I005be4bc29de51d3c89f04b5d6c553a921a92aa3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473197 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-18 08:04:04 +00:00
/*
* Copyright 2021 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "src/gpu/tessellate/Tessellation.h"
#include "tests/Test.h"
Move src/gpu/tessellate/ types into skgpu::tess namespace For usages of constants in classes outside of skgpu::tess (e.g. when using tessellation in skgpu::v1 or skgpu::graphite), the constants are accessed with tess::. This is just to help with clarity since it scopes the constant name. However, functions and types are still referred to without that, and using namespace skgpu::tess is used to keep those references simpler. In headers, tess:: is added when there are only a few usages of the types, or it's brought in as an alias. Change-Id: I12af595659fe791de419db0393482dae6cd238e3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534668 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-05 13:54:23 +00:00
namespace skgpu::tess {
Make path pre-chopping more robust Exceptionally large control points might require us to chop the path very deeply. This CL converts the recursive chopping to loop with a stack of control points on the heap, in order to avoid the risk of stack overflow. It also adds a bail condition to avoid getting stuck in endless recursion due to fp32 precision issues. Bug: chromium:1266446 Change-Id: I005be4bc29de51d3c89f04b5d6c553a921a92aa3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473197 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-18 08:04:04 +00:00
DEF_TEST(PreChopPathCurves, reporter) {
// These particular test cases can get stuck in infinite recursion due to limited fp32
// precision. (Although they will not with the provided tessellationPrecision values; we had to
// lower precision in order to avoid the "viewport size" assert in PreChopPathCurves.) Bump the
// tessellationPreciion up to 4 and run these tests in order to verify our bail condition for
// infinite recursion caused by bad fp32 precision. If the test completes, it passed.
SkPath p = SkPath().moveTo(11.171727877046647f, -11.78621173228717f)
.quadTo(11.171727877046647f, -11.78621173228717f,
8.33583747124031f, 77.27177002747368f)
.cubicTo(8.33583747124031f, 77.27177002747368f,
8.33583747124031f, 77.27177002747368f,
11.171727877046647f, -11.78621173228717f)
.conicTo(11.171727877046647f, -11.78621173228717f,
8.33583747124031f, 77.27177002747368f,
1e-6f)
.conicTo(8.33583747124031f, 77.27177002747368f,
11.171727877046647f, -11.78621173228717f,
1e6f);
SkMatrix m = SkMatrix::Scale(138.68622826903837f, 74192976757580.44189f);
Move src/gpu/tessellate/ types into skgpu::tess namespace For usages of constants in classes outside of skgpu::tess (e.g. when using tessellation in skgpu::v1 or skgpu::graphite), the constants are accessed with tess::. This is just to help with clarity since it scopes the constant name. However, functions and types are still referred to without that, and using namespace skgpu::tess is used to keep those references simpler. In headers, tess:: is added when there are only a few usages of the types, or it's brought in as an alias. Change-Id: I12af595659fe791de419db0393482dae6cd238e3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534668 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-05 13:54:23 +00:00
PreChopPathCurves(1/16.f, p, m, {1000, -74088852800000.f, 3000, -74088852700000.f});
Make path pre-chopping more robust Exceptionally large control points might require us to chop the path very deeply. This CL converts the recursive chopping to loop with a stack of control points on the heap, in order to avoid the risk of stack overflow. It also adds a bail condition to avoid getting stuck in endless recursion due to fp32 precision issues. Bug: chromium:1266446 Change-Id: I005be4bc29de51d3c89f04b5d6c553a921a92aa3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473197 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-18 08:04:04 +00:00
m = SkMatrix::Scale(138.68622826903837f, 74192976757580.44189f*.3f);
Move src/gpu/tessellate/ types into skgpu::tess namespace For usages of constants in classes outside of skgpu::tess (e.g. when using tessellation in skgpu::v1 or skgpu::graphite), the constants are accessed with tess::. This is just to help with clarity since it scopes the constant name. However, functions and types are still referred to without that, and using namespace skgpu::tess is used to keep those references simpler. In headers, tess:: is added when there are only a few usages of the types, or it's brought in as an alias. Change-Id: I12af595659fe791de419db0393482dae6cd238e3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534668 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-05 13:54:23 +00:00
PreChopPathCurves(.25f, p, m, {1000, -22226658140000.f, 3000, -22226658130000.f});
Make path pre-chopping more robust Exceptionally large control points might require us to chop the path very deeply. This CL converts the recursive chopping to loop with a stack of control points on the heap, in order to avoid the risk of stack overflow. It also adds a bail condition to avoid getting stuck in endless recursion due to fp32 precision issues. Bug: chromium:1266446 Change-Id: I005be4bc29de51d3c89f04b5d6c553a921a92aa3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473197 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-18 08:04:04 +00:00
m = SkMatrix::Scale(138.68622826903837f, 74192976757580.44189f/4);
Move src/gpu/tessellate/ types into skgpu::tess namespace For usages of constants in classes outside of skgpu::tess (e.g. when using tessellation in skgpu::v1 or skgpu::graphite), the constants are accessed with tess::. This is just to help with clarity since it scopes the constant name. However, functions and types are still referred to without that, and using namespace skgpu::tess is used to keep those references simpler. In headers, tess:: is added when there are only a few usages of the types, or it's brought in as an alias. Change-Id: I12af595659fe791de419db0393482dae6cd238e3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534668 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-05 13:54:23 +00:00
PreChopPathCurves(.25f, p, m, {1000, -18522213200000.f, 3000, -18522213100000.f});
Make path pre-chopping more robust Exceptionally large control points might require us to chop the path very deeply. This CL converts the recursive chopping to loop with a stack of control points on the heap, in order to avoid the risk of stack overflow. It also adds a bail condition to avoid getting stuck in endless recursion due to fp32 precision issues. Bug: chromium:1266446 Change-Id: I005be4bc29de51d3c89f04b5d6c553a921a92aa3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/473197 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2021-11-18 08:04:04 +00:00
}
Move src/gpu/tessellate/ types into skgpu::tess namespace For usages of constants in classes outside of skgpu::tess (e.g. when using tessellation in skgpu::v1 or skgpu::graphite), the constants are accessed with tess::. This is just to help with clarity since it scopes the constant name. However, functions and types are still referred to without that, and using namespace skgpu::tess is used to keep those references simpler. In headers, tess:: is added when there are only a few usages of the types, or it's brought in as an alias. Change-Id: I12af595659fe791de419db0393482dae6cd238e3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/534668 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2022-05-05 13:54:23 +00:00
} // namespace skgpu::tess
Reference in New Issue Copy Permalink