AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
8e96c9db78
skia2/tools/BUILD.bazel

36 lines
803 B
Python
Raw Normal View History

[bazel] Add rules for CanvasKit and dependent modules This may look like a lot, but //modules/canvaskit/BUILD.bazel is nearly identical to how it was with gazelle: https://github.com/google/skia/blob/162dfca3403b21575212f2b75e6627fa88ae6160/modules/canvaskit/BUILD.bazel I removed the "wasm_gm_tests" targets from it, because they had bitrotted slightly and fixing them is its own task. CanvasKit depends on Skottie and Particles, which depend on the SkParagraph, SkShaper, SkUnicode, and SkResources modules. I've structured the BUILD.bazel files in the //modules directory in a similar fashion as the "hierarchical filegroup" introduced in https://skia-review.googlesource.com/c/skia/+/543977 Suggested Review Order - //modules/skottie/... - //modules/skparagraph/... - all other modules. - Note that modules/canvaskit/go/gold_test_env/BUILD.bazel is generated from gazelle, because we like how gazelle handles golang files and deps. - All other files in any order. Change-Id: I0aa9e6f81dba2c00f15cae7b19fe49a2027dcf1d Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/544676 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-05-27 19:12:31 +00:00
load("//bazel:macros.bzl", "cc_library", "exports_files_legacy", "py_binary")
[bazel] Get GPU examples working This adds targets which test our Dawn, GL, and Vulkan backends. It follows the hierarchical filegroup pattern, as outlined in https://skia-review.googlesource.com/c/skia/+/543977 Suggested Review order: - tools/sk_app/BUILD.bazel. For many things in tools, I anticipate they will depend on //:skia_core and other //tools targets. sk_app shows this off, as well how to make the target specific to a given platform and pull in the proper native code. I'm trying out setting test_only = True, to see if we can partition Skia's tests and helpers from the actual Skia library. - other changes to //tools/, especially looking at sk_app's dependencies. - //example/BUILD.bazel. This uses the cc_binary_with_flags which existed previously [1] to make it so people don't have to specify all the flags for a given binary and can build it as is. These targets nows how up in //bazel/Makefile - //include/... and //src/..., where some typos from previous CLs were fixed and rules expanded. - Misc changes to .cpp files to remove unnecessary includes that were assuming the GL backend was being compiled in. - All other changes [1] https://github.com/google/skia/blob/162dfca3403b21575212f2b75e6627fa88ae6160/bazel/cc_binary_with_flags.bzl Change-Id: Ieacec464d44368cad0da0890c7dc85a6c0b900c9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/544317 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-05-27 18:47:29 +00:00
licenses(["notice"])
exports_files_legacy()
[bazel] Add new rules for various tools This adds or fixes rules to build three binaries that previously had Bazel support. How we build skslc with Bazel differs from GN in a large way: GN has a small set of C++ files [1] it compiles in, but with Bazel that was too hard/clumsy to pipe through (and get the headers to work well). So, I just had skslc depend on //:skia_core for simplicity. skslc did need to include something in //src, so I made a special filegroup for it. For more complex executables that need more headers from //src, we should probably make a "src_hdrs" filegroup or something to expose those. That or a skia_for_tests cc_library that has all headers as "public". [1] https://github.com/google/skia/blob/main/gn/sksl.gni#L235 Change-Id: Ie1382e982228059369886f4bfef4947f686b11b5 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/544637 Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-27 19:03:36 +00:00
cc_library(
name = "tool_utils",
testonly = True,
srcs = [
"Resources.cpp",
"ToolUtils.cpp",
"ResourceFactory.h",
"Resources.h",
"//tools/flags:core_srcs",
# TODO(kjlubick, bungeman): We should split out the font stuff into its own set of files
"//tools/fonts:test_font_manager_srcs",
],
hdrs = [
"ToolUtils.h",
],
textual_hdrs = [
"//tools/fonts:test_fonts",
],
visibility = ["//:__subpackages__"],
deps = [
[bazel] Add "skia_internal" target that exposes private API for tests/tools. Organization v3.5, if we are keeping track :) This splits the "srcs" filegroup into "srcs" and "private_hdrs", and renames "hdrs" to "public_hdrs". To assist with the split, I created the macro split_srcs_and_hdrs. Rather than keep two separate lists of header and source files, I figured it would be easiest, at least for the common case, to keep one list of files and then have a for loop split them apart. I've tried to be consistent with having the list of files be named with a _FILES suffix - maybe we can use this as a marker to generate .gni files in the future? Suggested review order: - //bazel/macros.bzl. Note this needs a corresponding G3 change (http://cl/452279799) as well. The exports_files_legacy change is the better approach to something I manually handled yesterday when fixing the G3 roll. - //BUILD.bazel to see the new target skia_internal and the previous skia_core renamed to skia_public. - //src/core/BUILD.bazel to see a typical usage of split_srcs_and_hdrs. - //include/... to see the change to public_hdrs and private_hdrs - //src/... to see many more usages of split_srcs_and_hdrs - //tools/... to see changes to skia_internal where appropriate. - Everything else. Note that //modules/... might also need to be built with skia_internal instead of skia_public, but we can fix that up later, if necessary. Change-Id: Ie1cc969455d97b029b2d77faa222c4a9bad70671 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/545716 Reviewed-by: Ben Wagner <bungeman@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-06-01 18:45:46 +00:00
"//:skia_internal",
[bazel] Add new rules for various tools This adds or fixes rules to build three binaries that previously had Bazel support. How we build skslc with Bazel differs from GN in a large way: GN has a small set of C++ files [1] it compiles in, but with Bazel that was too hard/clumsy to pipe through (and get the headers to work well). So, I just had skslc depend on //:skia_core for simplicity. skslc did need to include something in //src, so I made a special filegroup for it. For more complex executables that need more headers from //src, we should probably make a "src_hdrs" filegroup or something to expose those. That or a skia_for_tests cc_library that has all headers as "public". [1] https://github.com/google/skia/blob/main/gn/sksl.gni#L235 Change-Id: Ie1382e982228059369886f4bfef4947f686b11b5 Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/544637 Reviewed-by: Ben Wagner <bungeman@google.com>
2022-05-27 19:03:36 +00:00
],
)
[bazel] Add rules for CanvasKit and dependent modules This may look like a lot, but //modules/canvaskit/BUILD.bazel is nearly identical to how it was with gazelle: https://github.com/google/skia/blob/162dfca3403b21575212f2b75e6627fa88ae6160/modules/canvaskit/BUILD.bazel I removed the "wasm_gm_tests" targets from it, because they had bitrotted slightly and fixing them is its own task. CanvasKit depends on Skottie and Particles, which depend on the SkParagraph, SkShaper, SkUnicode, and SkResources modules. I've structured the BUILD.bazel files in the //modules directory in a similar fashion as the "hierarchical filegroup" introduced in https://skia-review.googlesource.com/c/skia/+/543977 Suggested Review Order - //modules/skottie/... - //modules/skparagraph/... - all other modules. - Note that modules/canvaskit/go/gold_test_env/BUILD.bazel is generated from gazelle, because we like how gazelle handles golang files and deps. - All other files in any order. Change-Id: I0aa9e6f81dba2c00f15cae7b19fe49a2027dcf1d Bug: skia:12541 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/544676 Reviewed-by: Leandro Lovisolo <lovisolo@google.com>
2022-05-27 19:12:31 +00:00
py_binary(
name = "embed_resources",
srcs = ["embed_resources.py"],
visibility = ["//:__subpackages__"],
)
Reference in New Issue Copy Permalink