AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
980169a5b5
skia2/tests/sksl/errors/StaticSwitchConditionalBreak.glsl

5 lines
94 B
Plaintext
Raw Normal View History

Fix up outdated tests. Removed error tests which no longer test anything: - UseWithoutInitialize...: we no longer track variable use-before-init. - InlineDivideByZero: we no longer constant-fold the result of an inlined function call into its parent statement. - Unreachable: we no longer report unreachable statements. And fixed some minor test-case issues: - StaticSwitchConditionalBreak: we still check this, but the function was being dead-stripped before this check could run. Renamed to main. - OssFuzzXxxxx: these cases no longer report errors, but they are still valuable as regression tests; moved to `shared/`. Change-Id: Iade3cff821dc998cacfd02f62d3ac4625e48904c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387820 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-03-22 19:42:16 +00:00
### Compilation failed:
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
Remove usage of sqrt() as an optimization barrier in tests. In the majority of cases, a uniform is an equally good substitute, and replacing `sqrt(N)` with `unknownInput` actually makes the test clearer. Change-Id: I7bcb477571972d7aa2ce8c49b3674471f7310748 Bug: skia:12034 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/411306 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-05-24 14:52:23 +00:00
error: 5: static switch contains non-static conditional exit
Fix up outdated tests. Removed error tests which no longer test anything: - UseWithoutInitialize...: we no longer track variable use-before-init. - InlineDivideByZero: we no longer constant-fold the result of an inlined function call into its parent statement. - Unreachable: we no longer report unreachable statements. And fixed some minor test-case issues: - StaticSwitchConditionalBreak: we still check this, but the function was being dead-stripped before this check could run. Renamed to main. - OssFuzzXxxxx: these cases no longer report errors, but they are still valuable as regression tests; moved to `shared/`. Change-Id: Iade3cff821dc998cacfd02f62d3ac4625e48904c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/387820 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2021-03-22 19:42:16 +00:00
1 error
Reference in New Issue Copy Permalink