skia2/tests/sksl/errors/ArrayOfVoidInStruct.glsl

### Compilation failed:

error: 4: opaque type 'void' is not permitted in a struct
error: 5: opaque type 'void' is not permitted in a struct
error: 6: multi-dimensional arrays are not supported
3 errors
Fix assertion when arrays are double-declared. Multi-dimensional arrays aren't legal in GLSL/SkSL, so this should be caught and flagged as an error. The parser now verifies that a variable's type isn't an array-type before accepting a `[` token to open an array on the variable name. This CL also refactors the IR generator's `convertArraySize` method to make sure that various checks are made for all callers. Originally this restructuring was used to verify array multi-dimensionality, but that didn't detect errors inside struct declarations (which get no error checking inside the IR generator) so the IR generator updates no longer need to check the array dimensions. Bug: skia:11322 Change-Id: Id33f4bdfb544019ddf995a8196c3c09cfe5a4525 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/369916 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2021-02-12 22:07:51 +00:00			`### Compilation failed:`

SkSL: Turn DSL parser off again Several fuzzer issues, and one Chromium issue that's blocking the roll. Bug: chromium:1246795 Bug: skia:12423 Change-Id: I00370b74569b447e543d9a1f22c588eb493063da Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445960 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Osman <brianosman@google.com> 2021-09-07 13:36:08 +00:00			`error: 4: opaque type 'void' is not permitted in a struct`
			`error: 5: opaque type 'void' is not permitted in a struct`
			`error: 6: multi-dimensional arrays are not supported`
Fix assertion when arrays are double-declared. Multi-dimensional arrays aren't legal in GLSL/SkSL, so this should be caught and flagged as an error. The parser now verifies that a variable's type isn't an array-type before accepting a `[` token to open an array on the variable name. This CL also refactors the IR generator's `convertArraySize` method to make sure that various checks are made for all callers. Originally this restructuring was used to verify array multi-dimensionality, but that didn't detect errors inside struct declarations (which get no error checking inside the IR generator) so the IR generator updates no longer need to check the array dimensions. Bug: skia:11322 Change-Id: Id33f4bdfb544019ddf995a8196c3c09cfe5a4525 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/369916 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2021-02-12 22:07:51 +00:00			`3 errors`