skia2/tests/sksl/errors/Ossfuzz29444.glsl

### Compilation failed:

error: 2: invalid arguments to 'float[1]' constructor (expected 1 elements, but found 0)
1 error
Reject array constructors with the wrong number of elements. We now catch this error at IR generation time; previously we'd send it to the driver (where it would fail to compile). Change-Id: I45890214ffa164be1c0f359320f942bc4dc479ca Bug: skia:11265 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365697 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2021-02-03 20:11:18 +00:00			`### Compilation failed:`
Fix for fuzzer-discovered use-after-free. The inliner discovered that when a binary expression is inlined, its type is not cloned into the destination's SymbolTable. This meant that when the inlined-from function was later dead-stripped, the type pointer would become dangling. Did a quick pass over inlineExpression and inlineStatement and ensured that types are always copied. Also found that `copy_if_needed` was making a copy of eligible types each time one was encountered, instead of making one copy and reusing it. This is fixed as well. Change-Id: Iee3259ab038dfb04034bf0110af1909ccffec3de Bug: oss-fuzz:29444 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354219 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> 2021-01-14 23:35:34 +00:00
Reject array constructors with the wrong number of elements. We now catch this error at IR generation time; previously we'd send it to the driver (where it would fail to compile). Change-Id: I45890214ffa164be1c0f359320f942bc4dc479ca Bug: skia:11265 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365697 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2021-02-03 20:11:18 +00:00			`error: 2: invalid arguments to 'float[1]' constructor (expected 1 elements, but found 0)`
Generate more diagnostics from IRGenerator, when given bad code. Two minor changes: - Converting a Block with bad statements will now generate a partial block instead of nullptr. The change mirrors how DSL behaves; functions containing invalid statements will now be created and added to the program. Previously, we would discard a function definition with any invalid statements inside; this prevented duplicate-function-definition errors from appearing. - Converting a return with a bad expression will now generate a poisoned return instead of nullptr. This change improves diagnostics for functions with invalid return statements. If we eliminate the return statements (by returning null), we report bad return statements as "function can exit without returning a value" (which is confusing). Change-Id: I6d998d5c50585f8d96bb7e3cb7f59b63125d6a62 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/446325 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Osman <brianosman@google.com> 2021-09-07 19:22:02 +00:00			`1 error`