AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
b2271e6016
skia2/tests/sksl/errors/VectorIndexOutOfRange.glsl

25 lines
1015 B
Plaintext
Raw Normal View History

Improve array-indexing tests. Previously, we didn't have tests which leveraged constant-evaluation of array indexing (because we didn't support it), and our test files commingled constant-indexing into vectors with constant-indexing into arrays. The test files now separate vector- and array-handling into separate tests, and a ton of new cases have been added to ArrayFolding. The ArrayFolding tests now require constant-evaluation of array indexing, so they fail in this CL, but will be fixed in the followup CL. Change-Id: I3b663e743d97d6db80627bc9b7808f88c99917a7 Bug: skia:12472 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/469528 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-11-10 14:58:32 +00:00
### Compilation failed:
error: 1: index -1 out of range for 'half4'
error: 6: index 4 out of range for 'half4'
error: 7: index 1000000000 out of range for 'half4'
error: 9: index -1 out of range for 'half3'
error: 13: index 3 out of range for 'half3'
error: 14: index 4 out of range for 'half3'
error: 15: index 1000000000 out of range for 'half3'
error: 17: index -1 out of range for 'half2'
error: 20: index 2 out of range for 'half2'
error: 21: index 3 out of range for 'half2'
error: 22: index 4 out of range for 'half2'
error: 23: index 1000000000 out of range for 'half2'
Add tests for matrix constant-expressions. We should support constant-expressions involving matrices (GLSL ES2 does, WebGL does). We currently don't. We do properly report out-of- range indexing, but we don't optimize away valid matrix index expressions or allow matrices to be indexed in a constant-expression context. Change-Id: If58aa4c5f15abef421a412957072f3617b4176df Bug: skia:12472 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/469818 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-11-10 19:02:18 +00:00
error: 25: index -1 out of range for 'half2'
error: 28: index 2 out of range for 'half2'
error: 29: index 1000000000 out of range for 'half2'
error: 31: index -1 out of range for 'half3'
error: 35: index 3 out of range for 'half3'
error: 36: index 1000000000 out of range for 'half3'
error: 38: index -1 out of range for 'half4'
error: 43: index 4 out of range for 'half4'
error: 44: index 1000000000 out of range for 'half4'
21 errors
Reference in New Issue Copy Permalink