AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
b2b1d6553e
skia2/tests/sksl/errors/BitShiftFloatMatrix.glsl

34 lines
1.2 KiB
Plaintext
Raw Normal View History

SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
### Compilation failed:
error: 5: type mismatch: '>>=' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void shr_eq() { x >>= 1; }
^^^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 6: type mismatch: '<<=' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void shl_eq() { x <<= 1; }
^^^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 7: type mismatch: '&=' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void and_eq() { x &= 1; }
^^^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 8: type mismatch: '|=' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void or_eq() { x |= 1; }
^^^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 9: type mismatch: '^=' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void xor_eq() { x ^= 1; }
^^^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 11: type mismatch: '>>' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void shr() { x = x >> 1; }
^^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 12: type mismatch: '<<' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void shl() { x = x << 1; }
^^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 13: type mismatch: '&' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void and() { x = x & 1; }
^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 14: type mismatch: '|' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void or() { x = x | 1; }
^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
error: 15: type mismatch: '^' cannot operate on 'float2x2', 'int'
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void xor() { x = x ^ 1; }
^^^^^
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
10 errors
Reference in New Issue Copy Permalink