AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
b2b1d6553e
skia2/tests/sksl/errors/PrivateVariables.glsl

16 lines
277 B
Plaintext
Raw Normal View History

Reject $ in variable names for non-builtin code. These identifiers are reserved for SkSL internal use (and can't be exposed to GLSL or Metal anyway). Change-Id: Id554cbf21ed2fb66785e77700ff79424ecdf66db Bug: skia:12854 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/498036 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-22 20:32:53 +00:00
### Compilation failed:
error: 1: name '$a' is reserved
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
int $a;
Improved positions of variable name errors Bug: skia:13170 Change-Id: I11ef0ea5ac3ae61b24a47805bb3290a37880cfee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/532536 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-21 20:54:01 +00:00
^^
Reject $ in variable names for non-builtin code. These identifiers are reserved for SkSL internal use (and can't be exposed to GLSL or Metal anyway). Change-Id: Id554cbf21ed2fb66785e77700ff79424ecdf66db Bug: skia:12854 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/498036 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-22 20:32:53 +00:00
error: 2: name '$b' is reserved
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
void func(float2 $b) {
Improved positions of variable name errors Bug: skia:13170 Change-Id: I11ef0ea5ac3ae61b24a47805bb3290a37880cfee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/532536 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-21 20:54:01 +00:00
^^
Reject $ in variable names for non-builtin code. These identifiers are reserved for SkSL internal use (and can't be exposed to GLSL or Metal anyway). Change-Id: Id554cbf21ed2fb66785e77700ff79424ecdf66db Bug: skia:12854 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/498036 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-22 20:32:53 +00:00
error: 3: name '$c' is reserved
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
float $c[2];
Improved positions of variable name errors Bug: skia:13170 Change-Id: I11ef0ea5ac3ae61b24a47805bb3290a37880cfee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/532536 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-21 20:54:01 +00:00
^^
Reject $ in variable names for non-builtin code. These identifiers are reserved for SkSL internal use (and can't be exposed to GLSL or Metal anyway). Change-Id: Id554cbf21ed2fb66785e77700ff79424ecdf66db Bug: skia:12854 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/498036 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-22 20:32:53 +00:00
error: 4: name '$d' is reserved
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
bool4 $d;
Improved positions of variable name errors Bug: skia:13170 Change-Id: I11ef0ea5ac3ae61b24a47805bb3290a37880cfee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/532536 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-21 20:54:01 +00:00
^^
Reject $ in variable names for non-builtin code. These identifiers are reserved for SkSL internal use (and can't be exposed to GLSL or Metal anyway). Change-Id: Id554cbf21ed2fb66785e77700ff79424ecdf66db Bug: skia:12854 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/498036 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2022-01-22 20:32:53 +00:00
4 errors
Reference in New Issue Copy Permalink