AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
b2b1d6553e
skia2/tests/sksl/errors/RedeclareVariable.glsl

28 lines
530 B
Plaintext
Raw Normal View History

Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
### Compilation failed:
error: 4: symbol 'x' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
int x;
^^^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
error: 5: symbol 'x' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
float4x4 x;
^^^^^^^^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
error: 6: symbol 'x' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
bool2 x[2];
^^^^^^^^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
error: 7: symbol 'x' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
S x;
^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
error: 11: symbol 'y' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
float2 y;
^^^^^^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
error: 12: symbol 'y' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
int y;
^^^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
error: 13: symbol 'y' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
float y[4];
^^^^^^^^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
error: 14: symbol 'y' was already defined
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
2022-04-06 22:24:52 +00:00
S y;
^^^
Disallow identifier names that overlap existing types. It's not legal to use identifiers like "int" or "sampler" to name your variables (or enums, or structs, etc.). SkSL will now report this as an error instead of relying on the driver to catch this. (Note that in some contexts, it might be legal by the spec to reuse a name that you introduced yourself, depending on the scope. In practice, this confuses Apple GLSL, so we shouldn't support it anyway.) This caught several existing places in our code where we used the name "sampler." These were never exposed to the driver (they were intrinsics that we would replace during compilation) so they were harmless before. Change-Id: Ia6dcfca8c500d02e1eb5f9427bed8727e114dfc2 Bug: skia:11036 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/340758 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-12-04 15:51:21 +00:00
8 errors
Reference in New Issue Copy Permalink