AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
b44185086e
skia2/.clang-tidy

26 lines
836 B
Plaintext
Raw Normal View History

Enable ClangTidy flag modernize-use-override. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required. virtual on non base class implementations was used to help indicate to the user that a function was virtual. C++ compilers did not use the presence of this to signify an overridden function. Change-Id: If66d8919358f72a4035190caf8d7569268037a9a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310160 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-14 02:58:04 +00:00
Checks: >
-*,
bugprone-argument-comment,
bugprone-bool-pointer-implicit-conversion,
Enable ClangTidy flag bugprone-suspicious-string-compare. https://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-string-compare.html Find suspicious usage of runtime string comparison functions. This check is valid in C and C++. Checks for calls with implicit comparator and proposed to explicitly add it: if (strcmp(...)) // Implicitly compare to zero if (!strcmp(...)) // Won't warn if (strcmp(...) != 0) // Won't warn Checks that compare function results (i,e, strcmp) are compared to valid constant. The resulting value is < 0 when lower than, > 0 when greater than, == 0 when equals. A common mistake is to compare the result to 1 or -1: if (strcmp(...) == -1) // Incorrect usage of the returned value. Additionally, the check warns if the results value is implicitly cast to a suspicious non-integer type. It’s happening when the returned value is used in a wrong context: if (strcmp(...) < 0.) // Incorrect usage of the returned value. Change-Id: I001b88d06cc4f3eb5846103885be675f9b78e126 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310761 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-16 03:22:53 +00:00
bugprone-suspicious-string-compare,
Enable ClangTidy flag modernize-use-override. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required. virtual on non base class implementations was used to help indicate to the user that a function was virtual. C++ compilers did not use the presence of this to signify an overridden function. Change-Id: If66d8919358f72a4035190caf8d7569268037a9a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310160 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-14 02:58:04 +00:00
bugprone-undelegated-constructor,
bugprone-unused-raii,
bugprone-use-after-move,
google-build-namespaces,
llvm-namespace-comment,
misc-definitions-in-headers,
modernize-make-unique,
Enable ClangTidy check modernize-use-nullptr. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html The check converts the usage of null pointer constants (eg. NULL, 0) to use the new C++11 nullptr keyword. Change-Id: Iaea2d843154c70e49d62affdc5dceb3bca8c1089 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310297 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-14 14:52:06 +00:00
modernize-use-nullptr,
Enable ClangTidy flag modernize-use-override. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required. virtual on non base class implementations was used to help indicate to the user that a function was virtual. C++ compilers did not use the presence of this to signify an overridden function. Change-Id: If66d8919358f72a4035190caf8d7569268037a9a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310160 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-14 02:58:04 +00:00
modernize-use-override,
performance-for-range-copy,
performance-unnecessary-copy-initialization,
readability-const-return-type,
readability-redundant-preprocessor,
Enable ClangTidy check readability-redundant-smartptr-get. To my surprise, this even works with homegrown smart pointers (such as SkTLazy). https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-smartptr-get.html Find and remove redundant calls to smart pointer’s .get() method. Examples: ptr.get()->Foo() ==> ptr->Foo() *ptr.get() ==> *ptr *ptr->get() ==> **ptr if (ptr.get() == nullptr) ... => if (ptr == nullptr) ... Change-Id: I8ff541e0229656b4d8e875c8053a7e6138302547 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310976 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-16 12:48:02 +00:00
readability-redundant-smartptr-get,
Enable ClangTidy flag modernize-use-override. https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required. virtual on non base class implementations was used to help indicate to the user that a function was virtual. C++ compilers did not use the presence of this to signify an overridden function. Change-Id: If66d8919358f72a4035190caf8d7569268037a9a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/310160 Commit-Queue: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2020-08-14 02:58:04 +00:00
readability-static-accessed-through-instance
Enable ClangTidy check llvm-namespace-comment. This fixes a large number of SkSL namespaces which were labeled as if they were anonymous, and also a handful of other mislabeled namespaces. Missing namespace-end comments have been added throughout. A number of diffs are just indentation-related (adjusting 1- or 3- space indents to 2-space). Change-Id: I6c62052a0d3aea4ae12ca07e0c2a8587b2fce4ec Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308503 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-08-06 18:11:56 +00:00
CheckOptions:
Disable ClangTidy namespace comments for short blocks. Namespace comments don't assist readability for blocks that can easily fit on a single screen. Change-Id: I93cbebe8e51400dead794c9eb41cb1eaa86bf756 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/312639 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-08-23 22:30:07 +00:00
- key: llvm-namespace-comment.ShortNamespaceLines
value: 40
Enable ClangTidy check llvm-namespace-comment. This fixes a large number of SkSL namespaces which were labeled as if they were anonymous, and also a handful of other mislabeled namespaces. Missing namespace-end comments have been added throughout. A number of diffs are just indentation-related (adjusting 1- or 3- space indents to 2-space). Change-Id: I6c62052a0d3aea4ae12ca07e0c2a8587b2fce4ec Reviewed-on: https://skia-review.googlesource.com/c/skia/+/308503 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-08-06 18:11:56 +00:00
- key: llvm-namespace-comment.SpacesBeforeComments
value: 2
Reference in New Issue Copy Permalink