AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
b82c0ece7e
skia2/site/dev/sheriffing/android.md

65 lines
3.9 KiB
Markdown
Raw Normal View History

Add documentation for being a Android RoboCop. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=5759 Change-Id: I6172c9edfcac63855b3f7c2b120bac44760a24a5 Reviewed-on: https://skia-review.googlesource.com/5759 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
2016-12-12 13:32:43 +00:00
Android RoboCop Documentation
===========================
### Contents ###
* [What does a Android RoboCop do?](#what_is_a_robocop)
Add documentation for android-o-roll.skia.org BUG=skia:6438 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13475 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Reviewed-on: https://skia-review.googlesource.com/13475 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:27:00 +00:00
* [Android Autorollers](#autoroller_doc)
Add documentation for being a Android RoboCop. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=5759 Change-Id: I6172c9edfcac63855b3f7c2b120bac44760a24a5 Reviewed-on: https://skia-review.googlesource.com/5759 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
2016-12-12 13:32:43 +00:00
* [View current and upcoming RoboCops](#view_current_upcoming_robocops)
* [How to swap RoboCop shifts](#how_to_swap)
<a name="what_is_a_robocop"></a>
What does a Android RoboCop do?
-----------------------
The RoboCop has two primary jobs:
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
1) Monitor and approve the semi-autonomous [git merges](https://googleplex-android-review.git.corp.google.com/#/q/owner:31977622648%2540project.gserviceaccount.com+status:open) from Skia's repository into the Android source tree. See autoroller documentation <a href="#autoroller_doc">here</a> for details on how to interact with it.
Add documentation for being a Android RoboCop. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=5759 Change-Id: I6172c9edfcac63855b3f7c2b120bac44760a24a5 Reviewed-on: https://skia-review.googlesource.com/5759 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
2016-12-12 13:32:43 +00:00
Update Robocop docs for skia-android-triage Instead of looking at open Skia bugs, which may already be assigned or have lower priority, the Robocop should be looking at open bugs assigned to skia-android-triage. New bugs will typically (though not always) be assigned to this new alias. No-Try: true Docs-Preview: https://skia.org/?cl=177889 Change-Id: Ifa006bfda5ad46f37e8e23ee80a7ee1caad8b915 Reviewed-on: https://skia-review.googlesource.com/c/177889 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
2018-12-17 14:33:13 +00:00
2) Stay on top of incoming Android-related bugs in both the [Skia](https://bugs.chromium.org/p/skia/issues/list?can=2&q=OpSys%3DAndroid&sort=-id&colspec=ID+Type+Status+Priority+Owner+Summary&cells=tiles) and [Android](https://buganizer.corp.google.com/issues?q=assignee:skia-android-triage%20status:open) bug trackers. For Skia bugs, this means triaging and assigning all Android bugs that are currently unassigned. For Android, this means following the [Android guidelines](go/android-buganizer) to verifying that all Skia bugs are TL-triaged (if not reach out to djsollen@).
Add documentation for being a Android RoboCop. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=5759 Change-Id: I6172c9edfcac63855b3f7c2b120bac44760a24a5 Reviewed-on: https://skia-review.googlesource.com/5759 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
2016-12-12 13:32:43 +00:00
The RoboCop's job is NOT to address issues in Perf and Gold. You'll get your chance when you are the general Skia sheriff.
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
<a name="autoroller_doc"></a>
Add documentation for android-o-roll.skia.org BUG=skia:6438 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13475 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Reviewed-on: https://skia-review.googlesource.com/13475 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:27:00 +00:00
Android Autorollers
-------------------
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
Add documentation for android-o-roll.skia.org BUG=skia:6438 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13475 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Reviewed-on: https://skia-review.googlesource.com/13475 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:27:00 +00:00
The Android autoroller into the master branch runs on [https://android-master-roll.skia.org](android-master-roll.skia.org) and is accessible only to Googlers.<br/>
Update Android autoroller documentation BUG=skia:5538 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13266 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Reviewed-on: https://skia-review.googlesource.com/13266 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-12 16:51:05 +00:00
The autoroller's status is displayed on Skia's [status page](https://status.skia.org/).
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
Update Android autoroller documentation BUG=skia:5538 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13266 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Reviewed-on: https://skia-review.googlesource.com/13266 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-12 16:51:05 +00:00
You can send the autoroller into dry run mode via the UI. The uploaded change will not autosubmit when it is in dry run mode.
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
Update Android autoroller documentation BUG=skia:5538 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13266 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Reviewed-on: https://skia-review.googlesource.com/13266 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-12 16:51:05 +00:00
You can also stop the autoroller via the UI. This is useful in cases where a failure needs to be investigated and you do not want to waste TH resources by running unnecessary tests.
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
Add links to autoroller cloud logs for roboCops No-Try: true Docs-Preview: https://skia.org/?cl=42901 Change-Id: I065c69085a8b32e8ff25ab5667882067f26a38c9 Bug: skia: Reviewed-on: https://skia-review.googlesource.com/42901 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-09-06 17:00:05 +00:00
If the autoroller displays an error in the UI then look for more detail in it's [cloud logs](https://pantheon.corp.google.com/logs/viewer?project=google.com:skia-buildbots&resource=logging_log%2Fname%2Fandroid-master-autoroll&logName=projects%2Fgoogle.com:skia-buildbots%2Flogs%2Fautoroll).
Update Android autoroller documentation BUG=skia:5538 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13266 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Change-Id: I76fa8db5ea9916fab2ef0f8058157dac96d52517 Reviewed-on: https://skia-review.googlesource.com/13266 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-12 16:51:05 +00:00
If you need any more information about the autoroller please look at [skia:5538](https://bugs.chromium.org/p/skia/issues/detail?id=5538) or ask rmistry@ / skiabot@.
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
Add documentation for android-o-roll.skia.org BUG=skia:6438 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13475 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Reviewed-on: https://skia-review.googlesource.com/13475 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:27:00 +00:00
We also have autorollers into release branches (also restricted only to Googlers):
Add links to autoroller cloud logs for roboCops No-Try: true Docs-Preview: https://skia.org/?cl=42901 Change-Id: I065c69085a8b32e8ff25ab5667882067f26a38c9 Bug: skia: Reviewed-on: https://skia-review.googlesource.com/42901 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-09-06 17:00:05 +00:00
* [https://android-o-roll.skia.org](https://android-o-roll.skia.org) ([cloud logs](https://pantheon.corp.google.com/logs/viewer?project=google.com:skia-buildbots&resource=logging_log%2Fname%2Fandroid-o-autoroll&logName=projects%2Fgoogle.com:skia-buildbots%2Flogs%2Fautoroll)).
Add documentation for android-o-roll.skia.org BUG=skia:6438 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13475 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Reviewed-on: https://skia-review.googlesource.com/13475 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:27:00 +00:00
Document the new bug and test lines behavior of the release rollers BUG=skia:6506 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13686 Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc Change-Id: I8f38d2f87784a846ccdc4be54d0f07e0fe98f7dc Reviewed-on: https://skia-review.googlesource.com/13686 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-18 12:09:46 +00:00
Changes created by these rollers need to be manually approved.<br/>
The changes created by the release rollers:
* Include all authors of merged changes so that they can watch the roll.
* Extracts all buganizer bugs of the form 'BUG=b/123' or 'Bug: b/456' and creates a single line in the merge change 'Bug: 123, 456'.
* Collects all 'Test: ' lines and carries them over to the merge change.
Add documentation for android-o-roll.skia.org BUG=skia:6438 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=13475 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Change-Id: I7d76d66b9b665fafc5c89bd4620517ebb9d2b076 Reviewed-on: https://skia-review.googlesource.com/13475 Reviewed-by: Matt Sarett <msarett@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-04-14 14:27:00 +00:00
Add robocop instructions on how to interact with the autoroller BUG=skia:6065 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=6812 Change-Id: I04acc6d4a75ce01a3c0af94091ada84aeadc7da8 Reviewed-on: https://skia-review.googlesource.com/6812 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
2017-01-09 19:31:33 +00:00
Add documentation for being a Android RoboCop. NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=5759 Change-Id: I6172c9edfcac63855b3f7c2b120bac44760a24a5 Reviewed-on: https://skia-review.googlesource.com/5759 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
2016-12-12 13:32:43 +00:00
<a name="view_current_upcoming_robocops"></a>
View current and upcoming RoboCops
----------------------------------
The list of RoboCops is specified in the [skia-tree-status web app](http://skia-tree-status.appspot.com/robocop). The current RoboCop is highlighted in green.
The banner on the top of the [status page](https://status.skia.org) also displays the current RoboCop.
<a name="how_to_swap"></a>
How to swap RoboCop shifts
--------------------------
If you need to swap shifts with someone (because you are out sick or on vacation), please get approval from the person you want to swap with. Then send an email to skia-android@google.com and cc rmistry@.
Reference in New Issue Copy Permalink