skia2/tests/sksl/errors/ArrayUnspecifiedDimensions.glsl

### Compilation failed:

error: 1: expected array dimension
int arrUnsized[];
              ^^
error: 2: array size must be an integer
int arrFloat[1.];
             ^^
error: 3: array size must be an integer
int arrBool[true];
            ^^^^
error: 5: missing index in '[]'
int unsized_in_expression() { return int[](0)[0]; }
                                        ^^
4 errors
Disallow unsized array dimensions on size fields past the frontmost. This was slightly complicated by the fact that this syntax indicates an array with a known size: float[] x = float[](1, 2, 3, 4); Of course, the size is 4; it's just never explicitly stated in the code. (The SkSL parser never actually deduces the size, but it doesn't apparently have a need to; we don't do much in the way of optimization for arrays.) However, this prevents us from simply failing whenever we parse "[]" in non-builtin code; we need to keep scanning and see if the variable is initialized. We already check this in the ArrayConstructors.sksl test file. Change-Id: I5b86958e81bd9bf5edf28a617cecf95c1875583e Bug: skia:10957 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335240 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2020-11-17 16:33:49 +00:00			`### Compilation failed:`

Reenable DSLParser Change-Id: I1819b2c40902611d7e86245bff73ad8c2bd7629c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/449060 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-09-16 14:42:24 +00:00			`error: 1: expected array dimension`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`int arrUnsized[];`
			`^^`
Allow const int variables to be used for array sizes. See http://review.skia.org/460037 for an example of the existing behavior. Const variables are constant-expressions and should be allowed here. Change-Id: I41383d79668785f270b7825485e9f6fa56c553c1 Bug: skia:12549 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460036 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> 2021-10-16 00:01:49 +00:00			`error: 2: array size must be an integer`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`int arrFloat[1.];`
			`^^`
Allow const int variables to be used for array sizes. See http://review.skia.org/460037 for an example of the existing behavior. Const variables are constant-expressions and should be allowed here. Change-Id: I41383d79668785f270b7825485e9f6fa56c553c1 Bug: skia:12549 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/460036 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> 2021-10-16 00:01:49 +00:00			`error: 3: array size must be an integer`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`int arrBool[true];`
			`^^^^`
Reenable DSLParser Change-Id: I1819b2c40902611d7e86245bff73ad8c2bd7629c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/449060 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-09-16 14:42:24 +00:00			`error: 5: missing index in '[]'`
Added range highlighting to SkSL error reports SkSL errors now identify the specific range of code they are describing, rather than just the line number. Change-Id: Ifabb3148476f9b4cd8e532f23e5b38e1cf33a87e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/528039 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> 2022-04-06 22:24:52 +00:00			`int unsized_in_expression() { return int[](0)[0]; }`
			`^^`
Enforce (valid) array sizes in many more places Unsized arrays are now allowed in exactly one place: On the declaration of an interface block. This satisfies the one existing use-case, which is the gl_in (sk_in) declaration for geometry shaders. There is no other useful scenario, and most of our backends don't support them anyway. Several spots were using less strict checks when attaching sizes to arrays, allowing for zero or negative-sized arrays, so those are all fixed now. The existing tests that initialize arrays are still a problem, because Metal doesn't support that (neither does GLES2). Also, ArrayConstructors has gone from generating an error in the Vulkan backend, to invalid SPIR-V. Bug: skia:11013 Bug: skia:11127 Change-Id: Ib08dfe9aeec96bf605661665d6f166419d27e8bc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/353817 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-01-14 19:18:10 +00:00			`4 errors`