skia2/include/sksl/SkSLPosition.h

96 lines
2.3 KiB
C
Raw Normal View History

/*
* Copyright 2021 Google LLC.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#ifndef SKSL_POSITION
#define SKSL_POSITION
#include "include/core/SkTypes.h"
[includes] Enforce IWYU on sksl code PS1 regenerates the Bazel files. Use it as the base change when comparing patchsets. IWYU seems to do a good job of working with MyFile.cpp and MyFile.h, but if there is just a MyHeader.h, it doesn't always seem to throw errors if the includes aren't correct. This was observed with include/sksl/DSL.h This might be due to the fact that headers are not compiled on their own, so they are never sent directly to the IWYU binary. This change sets enforce_iwyu_on_package() on the all sksl packages and then fixes the includes until all those checks are happy. There were a few files that needed fixes outside of the sksl folder. Examples include: - src/gpu/effects/GrConvexPolyEffect.cpp - tests/SkSLDSLTest.cpp To really enforce this, we need to add a CI/CQ job that runs bazel build //example:hello_world_gl --config=clang \ --sandbox_base=/dev/shm --features skia_enforce_iwyu If that failed, a dev could make the changes described in the logs and/or run the command locally to see those prescribed fixes. I had to add several entries to toolchain/IWYU_mapping.imp in order to fix some private includes and other atypical choices. I tried adding a rule there to allow inclusion of SkTypes.h to make sure defines like SK_SUPPORT_GPU, but could not get it to work for all cases, so I deferred to using the IWYU pragma: keep (e.g. SkSLPipelineStageCodeGenerator.h) Change-Id: I4c3e536d8e69ff7ff2d26fe61a525a6c2e80db06 Bug: skia:13052 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522256 Reviewed-by: John Stiles <johnstiles@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2022-03-18 20:40:58 +00:00
#include <string_view>
#ifndef __has_builtin
#define __has_builtin(x) 0
#endif
namespace SkSL {
class Position {
public:
Position()
: fStartOffsetOrLine(-1)
, fEndOffset(-1) {}
static Position Line(int line) {
Position result;
result.fStartOffsetOrLine = line;
result.fEndOffset = -1;
return result;
}
static Position Range(int startOffset, int endOffset) {
Position result;
result.fStartOffsetOrLine = startOffset;
result.fEndOffset = endOffset;
return result;
}
#if __has_builtin(__builtin_FILE) && __has_builtin(__builtin_LINE)
static Position Capture(const char* file = __builtin_FILE(), int line = __builtin_LINE());
#else
static Position Capture() { return Position(); }
#endif // __has_builtin(__builtin_FILE) && __has_builtin(__builtin_LINE)
bool valid() const {
return fStartOffsetOrLine != -1;
}
int line(std::string_view source = std::string_view()) const;
int startOffset() const {
SkASSERT(fEndOffset != -1);
return fStartOffsetOrLine;
}
int endOffset() const {
SkASSERT(fEndOffset != -1);
return fEndOffset;
}
bool operator==(const Position& other) const {
return fStartOffsetOrLine == other.fStartOffsetOrLine &&
fEndOffset == other.fEndOffset;
}
bool operator!=(const Position& other) const {
return !(*this == other);
}
bool operator>(const Position& other) const {
return fStartOffsetOrLine > other.fStartOffsetOrLine;
}
bool operator>=(const Position& other) const {
return fStartOffsetOrLine >= other.fStartOffsetOrLine;
}
bool operator<(const Position& other) const {
return fStartOffsetOrLine < other.fStartOffsetOrLine;
}
bool operator<=(const Position& other) const {
return fStartOffsetOrLine <= other.fStartOffsetOrLine;
}
private:
// Contains either a start offset (if fEndOffset != -1) or a line number (if fEndOffset == -1)
int32_t fStartOffsetOrLine;
int32_t fEndOffset;
};
} // namespace SkSL
#endif