AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
cf43fc6768
skia2/gn/sksl_tests.gni

305 lines
14 KiB
Plaintext
Raw Normal View History

Generate SkSL golden output files from test inputs during the build. Golden SkSL outputs are intended to eventually replace the majority of our unit tests, since they can automatically update themselves when we change implementation details of the compiler. If you change the compiler output without updating the Golden files, the CheckGeneratedFiles housekeeper will be triggered. Set `skia_compile_processors` or `skia_compile_sksl_tests` to true in your GN args to regenerate them. Almost all of the tests from SkSLFPTests.cpp and SkSLGLSLTests.cpp can be migrated into separate unit-test .fp/.sksl files in a followup CL. hcm@ has signed off on removing the copyright boilerplate preamble from our unit test files. Change-Id: I9e24a944bbac8f8efd62c92481b022a0b1ecdd0b Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316336 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-14 14:21:44 +00:00
# Copyright 2020 Google LLC
#
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Things are easiest for everyone if these source paths are absolute.
_tests = get_path_info("../tests", "abspath")
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
# Tests in sksl_fp_tests_sources will be compiled with --settings on.
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
sksl_fp_tests_sources = [
Migrate several SkSLFP tests to golden outputs. Change-Id: I83a38f2c953a560fea3483e95e31df532b90773e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317456 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 22:40:38 +00:00
"$_tests/sksl/errors/GrBadIn.fp",
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
"$_tests/sksl/errors/GrBothExplicitReturnAndSkOutColor.fp",
Migrate several SkSLFP tests to golden outputs. Change-Id: I83a38f2c953a560fea3483e95e31df532b90773e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317456 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 22:40:38 +00:00
"$_tests/sksl/errors/GrCannotReturnWithSkOutColor.fp",
"$_tests/sksl/errors/GrNoFragmentProcessorConstruction.fp",
"$_tests/sksl/errors/GrNoFragmentProcessorExpressions.fp",
"$_tests/sksl/errors/GrNoFragmentProcessorLocals.fp",
"$_tests/sksl/errors/GrNoFragmentProcessorParams.fp",
"$_tests/sksl/errors/GrNoFragmentProcessorReturn.fp",
Convert the remaining FP tests to golden outputs. (Removed one test, SkSLFPSwitchWithMultipleReturnsInside, because it was redundant with existing tests.) Change-Id: I1bfc069babdb5eb0cc515f195c3a2e307bb5871a Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319029 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-23 15:46:29 +00:00
"$_tests/sksl/fp/GrChildProcessorAndGlobal.fp",
"$_tests/sksl/fp/GrChildProcessorFieldAccess.fp",
"$_tests/sksl/fp/GrChildProcessorInlineFieldAccess.fp",
"$_tests/sksl/fp/GrChildProcessorSampleCoords.fp",
"$_tests/sksl/fp/GrChildProcessorSampleMatrixAndCoords.fp",
"$_tests/sksl/fp/GrChildProcessorSampleMatrixConstant.fp",
"$_tests/sksl/fp/GrChildProcessorSampleMatrixConstantAndCoords.fp",
"$_tests/sksl/fp/GrChildProcessorSampleMatrixMultipleUniforms.fp",
"$_tests/sksl/fp/GrChildProcessorSampleMatrixSingleInUniform.fp",
"$_tests/sksl/fp/GrChildProcessorSampleMatrixSingleUniform.fp",
"$_tests/sksl/fp/GrChildProcessorSampleMatrixSingleUniformExpr.fp",
"$_tests/sksl/fp/GrChildProcessorWithInputExpression.fp",
"$_tests/sksl/fp/GrChildProcessors.fp",
"$_tests/sksl/fp/GrChildProcessorsWithInput.fp",
Migrate several SkSLFP tests to golden outputs. Change-Id: I83a38f2c953a560fea3483e95e31df532b90773e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317456 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 22:40:38 +00:00
"$_tests/sksl/fp/GrConditionalInUniform.fp",
"$_tests/sksl/fp/GrFunction.fp",
Convert the remaining FP tests to golden outputs. (Removed one test, SkSLFPSwitchWithMultipleReturnsInside, because it was redundant with existing tests.) Change-Id: I1bfc069babdb5eb0cc515f195c3a2e307bb5871a Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319029 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-23 15:46:29 +00:00
"$_tests/sksl/fp/GrGrSLTypesAreSupported.fp",
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
"$_tests/sksl/fp/GrHelloWorld.fp",
Migrate several SkSLFP tests to golden outputs. Change-Id: I83a38f2c953a560fea3483e95e31df532b90773e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317456 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 22:40:38 +00:00
"$_tests/sksl/fp/GrInUniform.fp",
"$_tests/sksl/fp/GrInUniformCType.fp",
"$_tests/sksl/fp/GrInlinedFunction.fp",
"$_tests/sksl/fp/GrKeyIn.fp",
Convert the remaining FP tests to golden outputs. (Removed one test, SkSLFPSwitchWithMultipleReturnsInside, because it was redundant with existing tests.) Change-Id: I1bfc069babdb5eb0cc515f195c3a2e307bb5871a Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319029 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-23 15:46:29 +00:00
"$_tests/sksl/fp/GrLayoutWhen.fp",
"$_tests/sksl/fp/GrMainCoords.fp",
Migrate several SkSLFP tests to golden outputs. Change-Id: I83a38f2c953a560fea3483e95e31df532b90773e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317456 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 22:40:38 +00:00
"$_tests/sksl/fp/GrNestedChildProcessors.fp",
"$_tests/sksl/fp/GrNonInlinedInUniform.fp",
"$_tests/sksl/fp/GrNullableChildProcessor.fp",
"$_tests/sksl/fp/GrSectionClass.fp",
"$_tests/sksl/fp/GrSectionConstructor.fp",
"$_tests/sksl/fp/GrSectionConstructorParams.fp",
"$_tests/sksl/fp/GrSectionCpp.fp",
"$_tests/sksl/fp/GrSectionDumpInfo.fp",
"$_tests/sksl/fp/GrSectionEmitCode.fp",
"$_tests/sksl/fp/GrSectionFields.fp",
"$_tests/sksl/fp/GrSectionHeader.fp",
"$_tests/sksl/fp/GrSectionInitializers.fp",
"$_tests/sksl/fp/GrSectionMake.fp",
"$_tests/sksl/fp/GrSectionSetData.fp",
"$_tests/sksl/fp/GrSectionTest.fp",
"$_tests/sksl/fp/GrTrackedInUniform.fp",
"$_tests/sksl/fp/GrUniform.fp",
Convert the remaining FP tests to golden outputs. (Removed one test, SkSLFPSwitchWithMultipleReturnsInside, because it was redundant with existing tests.) Change-Id: I1bfc069babdb5eb0cc515f195c3a2e307bb5871a Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319029 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-23 15:46:29 +00:00
"$_tests/sksl/fp/GrUniformArrays.fp",
Migrate several SkSLFP tests to golden outputs. Change-Id: I83a38f2c953a560fea3483e95e31df532b90773e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317456 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 22:40:38 +00:00
"$_tests/sksl/fp/GrUseExplicitReturn.fp",
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
]
Generate SkSL golden output files from test inputs during the build. Golden SkSL outputs are intended to eventually replace the majority of our unit tests, since they can automatically update themselves when we change implementation details of the compiler. If you change the compiler output without updating the Golden files, the CheckGeneratedFiles housekeeper will be triggered. Set `skia_compile_processors` or `skia_compile_sksl_tests` to true in your GN args to regenerate them. Almost all of the tests from SkSLFPTests.cpp and SkSLGLSLTests.cpp can be migrated into separate unit-test .fp/.sksl files in a followup CL. hcm@ has signed off on removing the copyright boilerplate preamble from our unit test files. Change-Id: I9e24a944bbac8f8efd62c92481b022a0b1ecdd0b Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316336 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-14 14:21:44 +00:00
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
# Tests in sksl_glsl_tests_sources will be compiled with --settings on.
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
sksl_glsl_tests_sources = [
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/errors/ArgumentCountMismatch.sksl",
"$_tests/sksl/errors/ArgumentMismatch.sksl",
"$_tests/sksl/errors/ArgumentModifiers.sksl",
"$_tests/sksl/errors/AssignmentTypeMismatch.sksl",
"$_tests/sksl/errors/BadCaps.sksl",
"$_tests/sksl/errors/BadIndex.sksl",
"$_tests/sksl/errors/BadModifiers.sksl",
"$_tests/sksl/errors/BinaryTypeCoercion.sksl",
"$_tests/sksl/errors/BinaryTypeMismatch.sksl",
SkSL: Only allow bitwise ops on integral types We were allowing these ops on floating point types. The resulting GLSL would fail to compile. We also allowed >>= and <<= on vectors (but not any of the other bitwise ops). The newly added unit tests were failing (eg, not catching errors). New results are correct. Bug: skia:10707 Change-Id: I97b769f1ce59261361109a71061b42dc8ef3c74b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317393 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
2020-09-16 20:21:40 +00:00
"$_tests/sksl/errors/BitShiftFloat.sksl",
"$_tests/sksl/errors/BitShiftFloatMatrix.sksl",
"$_tests/sksl/errors/BitShiftFloatVector.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/errors/BreakOutsideLoop.sksl",
"$_tests/sksl/errors/CallNonFunction.sksl",
"$_tests/sksl/errors/CanExitWithoutReturningValue.sksl",
"$_tests/sksl/errors/ConstructorArgumentCount.sksl",
"$_tests/sksl/errors/ConstructorTypeMismatch.sksl",
"$_tests/sksl/errors/ContinueOutsideLoop.sksl",
"$_tests/sksl/errors/DivideByZero.sksl",
"$_tests/sksl/errors/DoTypeMismatch.sksl",
"$_tests/sksl/errors/DuplicateFunction.sksl",
"$_tests/sksl/errors/DuplicateOutput.sksl",
"$_tests/sksl/errors/DuplicateSymbol.sksl",
"$_tests/sksl/errors/EnumValueMustBeConstInt.sksl",
"$_tests/sksl/errors/ErrorsInDeadCode.sksl",
"$_tests/sksl/errors/FieldAfterRuntimeArray.sksl",
"$_tests/sksl/errors/ForTypeMismatch.sksl",
"$_tests/sksl/errors/GenericArgumentMismatch.sksl",
"$_tests/sksl/errors/IfTypeMismatch.sksl",
"$_tests/sksl/errors/InterfaceBlockScope.sksl",
"$_tests/sksl/errors/InterfaceBlockStorageModifiers.sksl",
"$_tests/sksl/errors/InvalidAssignment.sksl",
Add new unit tests for SkSL. These cover: - Properly configured out-params - Invalid/non-lvalue out-params, which currently cause an SkSL crash - Interactions between the inliner and variable swizzles Change-Id: I4874101236084f273e704d8717149b431d813883 Bug: skia:10753 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-23 19:20:01 +00:00
"$_tests/sksl/errors/InvalidOutParams.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/errors/InvalidUnary.sksl",
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
"$_tests/sksl/errors/OpenArray.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/errors/ReturnDifferentType.sksl",
"$_tests/sksl/errors/ReturnFromVoid.sksl",
"$_tests/sksl/errors/ReturnMissingValue.sksl",
"$_tests/sksl/errors/ReturnTypeMismatch.sksl",
"$_tests/sksl/errors/SpuriousFloat.sksl",
"$_tests/sksl/errors/StaticIfTest.sksl",
"$_tests/sksl/errors/StaticSwitchConditionalBreak.sksl",
"$_tests/sksl/errors/StaticSwitchTest.sksl",
"$_tests/sksl/errors/SwitchDuplicateCase.sksl",
"$_tests/sksl/errors/SwitchTypes.sksl",
"$_tests/sksl/errors/SwizzleConstantOutput.sksl",
"$_tests/sksl/errors/SwizzleDuplicateOutput.sksl",
"$_tests/sksl/errors/SwizzleMatrix.sksl",
"$_tests/sksl/errors/SwizzleOnlyLiterals.sksl",
"$_tests/sksl/errors/SwizzleOutOfBounds.sksl",
"$_tests/sksl/errors/SwizzleTooManyComponents.sksl",
"$_tests/sksl/errors/TernaryMismatch.sksl",
"$_tests/sksl/errors/UndefinedFunction.sksl",
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
"$_tests/sksl/errors/UndefinedSymbol.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/errors/Unreachable.sksl",
"$_tests/sksl/errors/UnsupportedGLSLIdentifiers.sksl",
"$_tests/sksl/errors/UseWithoutInitializeArrayIndex.sksl",
"$_tests/sksl/errors/UseWithoutInitializeBinaryExpr.sksl",
"$_tests/sksl/errors/UseWithoutInitializeDeadIf.sksl",
"$_tests/sksl/errors/UseWithoutInitializeDeadSwitch.sksl",
"$_tests/sksl/errors/UseWithoutInitializeReturnValue.sksl",
"$_tests/sksl/errors/UseWithoutInitializeVarDecl.sksl",
"$_tests/sksl/errors/UsingInvalidValue.sksl",
"$_tests/sksl/errors/WhileTypeMismatch.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/ArrayConstructors.sksl",
"$_tests/sksl/glsl/ArrayIndexTypes.sksl",
"$_tests/sksl/glsl/ArrayTypes.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/glsl/AssignmentTypeMatch.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/BoolFolding.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/Caps.sksl",
"$_tests/sksl/glsl/CastsRoundTowardZero.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/ClipDistanceFragment.sksl",
"$_tests/sksl/glsl/ClipDistanceVertex.vert",
"$_tests/sksl/glsl/Clockwise.sksl",
"$_tests/sksl/glsl/ComplexDelete.sksl",
"$_tests/sksl/glsl/ConstArray.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/glsl/ConstVariableComparison.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/ConstantIf.sksl",
"$_tests/sksl/glsl/Control.sksl",
Add unit test for a dead do-while loop. Ideally the optimizer should be able to detect and remove this loop. This CL establishes a baseline. Change-Id: I6aba0b52fe49552f170fca25d81c29c515044ef5 Bug: skia:10737 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317861 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-18 20:16:14 +00:00
"$_tests/sksl/glsl/DeadDoWhileLoop.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/DeadLoopVariable.sksl",
"$_tests/sksl/glsl/DependentInitializers.sksl",
Migrate Derivatives tests to golden outputs. Change-Id: I35ff25c4cc394c1a4a964207ece87095a9ba84cf Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317767 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-18 16:03:42 +00:00
"$_tests/sksl/glsl/DerivativesUnused.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/Discard.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/FloatFolding.sksl",
Add support for #pragma settings comments in SkSL. This will allow us to write skslc-based golden tests that deviate from the standalone skslc settings. This CL provides six options; more will be added as necessary. - Default (caps) - UsesPrecisionModifiers (caps) - Version110 (caps) - Version450Core (caps) - ForceHighPrecision (settings flag bit) - Sharpen (settings flag bit) Change-Id: I9b779e039b2f0c0ccf43dca226fb4844aff3526b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317237 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-16 21:43:11 +00:00
"$_tests/sksl/glsl/ForceHighPrecision.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/FrExp.sksl",
Migrate remaining SkSL GLSL tests to golden outputs. Change-Id: I72fd3083f75ca5bf74fb2c3b032465864a13aed5 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317771 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-18 18:42:58 +00:00
"$_tests/sksl/glsl/FragCoordsFlipY.sksl",
"$_tests/sksl/glsl/FragCoordsNew.sksl",
"$_tests/sksl/glsl/FragCoordsOld.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/glsl/FunctionArgumentMatch.sksl",
"$_tests/sksl/glsl/FunctionPrototype.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/Functions.sksl",
Migrate geometry SkSL tests to golden outputs. Change-Id: I01c150d6bfcdd1500033521a87c058c7428c3521 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317769 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-18 16:04:04 +00:00
"$_tests/sksl/glsl/Geometry.geom",
"$_tests/sksl/glsl/GeometryExtension.geom",
"$_tests/sksl/glsl/GeometryGSInvocations.geom",
"$_tests/sksl/glsl/GeometryNoGSInvocations.geom",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/Height.sksl",
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
"$_tests/sksl/glsl/HelloWorld.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/Hex.sksl",
Migrate remaining SkSL GLSL tests to golden outputs. Change-Id: I72fd3083f75ca5bf74fb2c3b032465864a13aed5 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317771 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-18 18:42:58 +00:00
"$_tests/sksl/glsl/IncompleteShortIntPrecision.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/InstanceID.vert",
"$_tests/sksl/glsl/IntFolding.sksl",
"$_tests/sksl/glsl/InterfaceBlockAnonymous.sksl",
"$_tests/sksl/glsl/InterfaceBlockArray.sksl",
"$_tests/sksl/glsl/InterfaceBlockNamed.sksl",
"$_tests/sksl/glsl/Matrices.sksl",
"$_tests/sksl/glsl/MatrixFolding.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/ModifiersDeclaration.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/MultipleAssignments.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/NegatedVectorLiteral.sksl",
Migrate remaining SkSL GLSL tests to golden outputs. Change-Id: I72fd3083f75ca5bf74fb2c3b032465864a13aed5 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317771 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-18 18:42:58 +00:00
"$_tests/sksl/glsl/NoFragCoordsPos.vert",
"$_tests/sksl/glsl/NoFragCoordsPosRT.vert",
Migrate geometry SkSL tests to golden outputs. Change-Id: I01c150d6bfcdd1500033521a87c058c7428c3521 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317769 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-18 16:04:04 +00:00
"$_tests/sksl/glsl/NormalizationGeo.geom",
"$_tests/sksl/glsl/NormalizationVert.vert",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/NumberConversions.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/Offset.sksl",
"$_tests/sksl/glsl/Operators.sksl",
Add new unit tests for SkSL. These cover: - Properly configured out-params - Invalid/non-lvalue out-params, which currently cause an SkSL crash - Interactions between the inliner and variable swizzles Change-Id: I4874101236084f273e704d8717149b431d813883 Bug: skia:10753 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-23 19:20:01 +00:00
"$_tests/sksl/glsl/OutParams.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/RectangleTexture.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/glsl/ResizeMatrix.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/SampleMask.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/glsl/ScopedSymbol.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/ShortCircuitBoolFolding.sksl",
Migrate remaining SkSL GLSL tests to golden outputs. Change-Id: I72fd3083f75ca5bf74fb2c3b032465864a13aed5 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317771 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-18 18:42:58 +00:00
"$_tests/sksl/glsl/ShortIntPrecision.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/StackingVectorCasts.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/glsl/StaticIf.sksl",
"$_tests/sksl/glsl/StaticSwitch.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/StaticSwitchWithBreak.sksl",
"$_tests/sksl/glsl/StaticSwitchWithBreakInsideBlock.sksl",
"$_tests/sksl/glsl/StaticSwitchWithConditionalBreak.sksl",
"$_tests/sksl/glsl/StaticSwitchWithConditionalBreakInsideBlock.sksl",
"$_tests/sksl/glsl/StaticSwitchWithFallthroughA.sksl",
"$_tests/sksl/glsl/StaticSwitchWithFallthroughB.sksl",
"$_tests/sksl/glsl/StaticSwitchWithStaticConditionalBreak.sksl",
"$_tests/sksl/glsl/StaticSwitchWithStaticConditionalBreakInsideBlock.sksl",
"$_tests/sksl/glsl/Structs.sksl",
"$_tests/sksl/glsl/Switch.sksl",
"$_tests/sksl/glsl/SwitchContainingDeadCode.sksl",
"$_tests/sksl/glsl/SwitchWithFallthrough.sksl",
Add unit test for swizzling booleans. This test currently crashes skslc, but will be fixed in the followup CL. Change-Id: I3683d94a310242e8ca67560296518fd1223b28d0 Bug: oss-fuzz:25781 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318656 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-22 17:56:01 +00:00
"$_tests/sksl/glsl/SwizzleBoolConstants.sksl",
Migrate swizzle tests to golden SkSL files. This simplifies life when revising the swizzle logic. Change-Id: I7fc63c0cc845c4741c17c82b3078040264b61ba0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317379 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-16 17:40:35 +00:00
"$_tests/sksl/glsl/SwizzleConstants.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/SwizzleLTRB.sksl",
Migrate swizzle tests to golden SkSL files. This simplifies life when revising the swizzle logic. Change-Id: I7fc63c0cc845c4741c17c82b3078040264b61ba0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317379 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-16 17:40:35 +00:00
"$_tests/sksl/glsl/SwizzleOpt.sksl",
"$_tests/sksl/glsl/SwizzleScalar.sksl",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/TernaryAsLValueEntirelyFoldable.sksl",
"$_tests/sksl/glsl/TernaryAsLValueFoldableTest.sksl",
"$_tests/sksl/glsl/TernaryAsLValueUnfoldable.sksl",
Add support for #pragma settings comments in SkSL. This will allow us to write skslc-based golden tests that deviate from the standalone skslc settings. This CL provides six options; more will be added as necessary. - Default (caps) - UsesPrecisionModifiers (caps) - Version110 (caps) - Version450Core (caps) - ForceHighPrecision (settings flag bit) - Sharpen (settings flag bit) Change-Id: I9b779e039b2f0c0ccf43dca226fb4844aff3526b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317237 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-16 21:43:11 +00:00
"$_tests/sksl/glsl/Texture.sksl",
"$_tests/sksl/glsl/TextureSharpen.sksl",
"$_tests/sksl/glsl/TextureSharpenVersion110.sksl",
"$_tests/sksl/glsl/TextureVersion110.sksl",
Migrate SkSL error tests to golden outputs. Change-Id: Ic8f4730d035981c32b4ddb48e5e919b0396b6d93 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317578 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-17 22:20:26 +00:00
"$_tests/sksl/glsl/UnaryPositiveNegative.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/UnusedVariables.sksl",
Add support for #pragma settings comments in SkSL. This will allow us to write skslc-based golden tests that deviate from the standalone skslc settings. This CL provides six options; more will be added as necessary. - Default (caps) - UsesPrecisionModifiers (caps) - Version110 (caps) - Version450Core (caps) - ForceHighPrecision (settings flag bit) - Sharpen (settings flag bit) Change-Id: I9b779e039b2f0c0ccf43dca226fb4844aff3526b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317237 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-16 21:43:11 +00:00
"$_tests/sksl/glsl/UsesPrecisionModifiers.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/VectorConstructors.sksl",
"$_tests/sksl/glsl/VectorFolding.sksl",
Add support for #pragma settings comments in SkSL. This will allow us to write skslc-based golden tests that deviate from the standalone skslc settings. This CL provides six options; more will be added as necessary. - Default (caps) - UsesPrecisionModifiers (caps) - Version110 (caps) - Version450Core (caps) - ForceHighPrecision (settings flag bit) - Sharpen (settings flag bit) Change-Id: I9b779e039b2f0c0ccf43dca226fb4844aff3526b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317237 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-16 21:43:11 +00:00
"$_tests/sksl/glsl/Version110.sksl",
"$_tests/sksl/glsl/Version450Core.sksl",
Convert several SkSL->GLSL unit tests to golden outputs. The new test files are intended to be identical to the unit tests in every meaningful way. (Comments and formatting are not preserved exactly.) In cases where a unit-test method contained more than one test, multiple test files were created; in these cases, new names were invented to match the apparent intent of each invocation. Followup CLs will continue to migrate additional tests. Change-Id: I785c6761ba7ee2b25b5ddc0108321734be23b77c Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316678 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 21:30:13 +00:00
"$_tests/sksl/glsl/VertexID.vert",
Convert additional GLSL tests to use golden files. A handful of simplifications were made, but these hew very close to the original tests and are intended to cover the exact same ground. The remaining unconverted tests depend on non-default caps bits and will be updated once caps handling in skslc is fully landed. Change-Id: I3f3c29bf87f73e501561d7bfcdaabe8acc14b89f Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317390 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2020-09-16 19:32:21 +00:00
"$_tests/sksl/glsl/Width.sksl",
Migrate SkSL inliner tests to golden files. Our lack of proper caps-bits controls in skslc affects the outcome of one test: "InlinerWrapsEarlyReturnsWithDoWhileBlock" does not actually emit the do-while block because the standalone caps bits don't enable do-while support. This will be fixed in a followup CL that adds caps-bit support to our tests. A few tests were renamed for consistency, a few were simplified slightly and one test was removed because it was simply redundant (there was a second test that covered the exact same ground as `ForWithReturnInsideCannotBeInlined`). Change-Id: I2e3b97cb3aea331b6d806bdb865aa78c35c7a6b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316997 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-15 14:10:43 +00:00
"$_tests/sksl/inliner/DoWhileBodyMustBeInlinedIntoAScope.sksl",
"$_tests/sksl/inliner/DoWhileTestCannotBeInlined.sksl",
"$_tests/sksl/inliner/ForBodyMustBeInlinedIntoAScope.sksl",
"$_tests/sksl/inliner/ForInitializerExpressionsCanBeInlined.sksl",
"$_tests/sksl/inliner/ForWithReturnInsideCannotBeInlined.sksl",
"$_tests/sksl/inliner/ForWithoutReturnInsideCanBeInlined.sksl",
"$_tests/sksl/inliner/IfBodyMustBeInlinedIntoAScope.sksl",
"$_tests/sksl/inliner/IfElseBodyMustBeInlinedIntoAScope.sksl",
"$_tests/sksl/inliner/IfElseChainWithReturnsCanBeInlined.sksl",
"$_tests/sksl/inliner/IfTestCanBeInlined.sksl",
"$_tests/sksl/inliner/IfWithReturnsCanBeInlined.sksl",
"$_tests/sksl/inliner/InlineKeywordOverridesThreshold.sksl",
"$_tests/sksl/inliner/InlineThreshold.sksl",
"$_tests/sksl/inliner/InlineWithInoutArgument.sksl",
"$_tests/sksl/inliner/InlineWithModifiedArgument.sksl",
"$_tests/sksl/inliner/InlineWithNestedBigCalls.sksl",
"$_tests/sksl/inliner/InlineWithNestedCalls.sksl",
"$_tests/sksl/inliner/InlineWithUnmodifiedArgument.sksl",
"$_tests/sksl/inliner/InlineWithUnnecessaryBlocks.sksl",
Demonstrate name reuse error in inliner. The following conditions lead to the error: - A pair of nested functions, both of which must be inlined. - Both inlined functions create a variable with the same name. - The outer function passes its variable to the inner function. - The initialization of the inner variable uses the value from the outer variable. - The inner function does not mutate the variable, use it as an out- parameter, or otherwise cause it to receive a temporary copy. When all these conditions are met, both variable declarations are inlined as-is without performing any name salting, because it's seemingly safe to do so. The name overlap issue is not considered in the safety checks. Inlined variable declarations are not subject to name salting but they should be; I suspect other adversarial examples could be crafted as well where unhandled name overlap leads to errors. Change-Id: Ia754bee8e45c8a5c7548436594bbf04abc7a8396 Bug: skia:10722 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316945 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 22:23:54 +00:00
"$_tests/sksl/inliner/InlinerAvoidsVariableNameOverlap.sksl",
Migrate SkSL inliner tests to golden files. Our lack of proper caps-bits controls in skslc affects the outcome of one test: "InlinerWrapsEarlyReturnsWithDoWhileBlock" does not actually emit the do-while block because the standalone caps bits don't enable do-while support. This will be fixed in a followup CL that adds caps-bit support to our tests. A few tests were renamed for consistency, a few were simplified slightly and one test was removed because it was simply redundant (there was a second test that covered the exact same ground as `ForWithReturnInsideCannotBeInlined`). Change-Id: I2e3b97cb3aea331b6d806bdb865aa78c35c7a6b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316997 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-15 14:10:43 +00:00
"$_tests/sksl/inliner/InlinerManglesNames.sksl",
"$_tests/sksl/inliner/ShortCircuitEvaluationsCannotInlineRightHandSide.sksl",
"$_tests/sksl/inliner/SwitchWithCastCanBeInlined.sksl",
"$_tests/sksl/inliner/SwitchWithReturnInsideCannotBeInlined.sksl",
"$_tests/sksl/inliner/SwitchWithoutReturnInsideCanBeInlined.sksl",
Add new unit tests for SkSL. These cover: - Properly configured out-params - Invalid/non-lvalue out-params, which currently cause an SkSL crash - Interactions between the inliner and variable swizzles Change-Id: I4874101236084f273e704d8717149b431d813883 Bug: skia:10753 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319036 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-23 19:20:01 +00:00
"$_tests/sksl/inliner/SwizzleCanBeInlinedDirectly.sksl",
Migrate SkSL inliner tests to golden files. Our lack of proper caps-bits controls in skslc affects the outcome of one test: "InlinerWrapsEarlyReturnsWithDoWhileBlock" does not actually emit the do-while block because the standalone caps bits don't enable do-while support. This will be fixed in a followup CL that adds caps-bit support to our tests. A few tests were renamed for consistency, a few were simplified slightly and one test was removed because it was simply redundant (there was a second test that covered the exact same ground as `ForWithReturnInsideCannotBeInlined`). Change-Id: I2e3b97cb3aea331b6d806bdb865aa78c35c7a6b9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316997 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-15 14:10:43 +00:00
"$_tests/sksl/inliner/TernaryResultsCannotBeInlined.sksl",
"$_tests/sksl/inliner/TernaryTestCanBeInlined.sksl",
"$_tests/sksl/inliner/WhileBodyMustBeInlinedIntoAScope.sksl",
"$_tests/sksl/inliner/WhileTestCannotBeInlined.sksl",
Support testing error cases in our SkSL unit test goldens. Change-Id: I56e19153597e2c4393c5821314b82937828c0d50 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/316569 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-14 20:46:40 +00:00
]
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
# Tests in sksl_glsl_settings_tests_sources will be compiled twice, once with --settings and once
Rename 'DefaultSettings' golden outputs to 'StandaloneSettings'. I realized that "DefaultSettings" as a name suffix was unclear, because "Default" is a different settings mode from skslc running with --nosettings. In --nosettings mode, skslc uses "standalone" settings. Change-Id: I1f5d80df0a21cec55948c4ad146169bcb34f4999 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318210 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2020-09-21 21:09:52 +00:00
# using --nosettings. In the latter mode, StandaloneSettings is appended to the output filename.
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
sksl_glsl_settings_tests_sources = [
Create golden outputs for SkSL blend functions. Several blend functions generate a surprisingly large amount of code, and appear to have opportunities for further optimization. At any rate, if we make compiler changes that would affect the output of a blend function, I think we would want to see the changes reflected in our golden outputs. Change-Id: Iff612dcd4bad8824b5e6e97413ffce19e5ea1c0e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/318336 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-21 21:01:22 +00:00
"$_tests/sksl/blend/BlendClear.sksl",
"$_tests/sksl/blend/BlendColor.sksl",
"$_tests/sksl/blend/BlendColorBurn.sksl",
"$_tests/sksl/blend/BlendColorDodge.sksl",
"$_tests/sksl/blend/BlendDarken.sksl",
"$_tests/sksl/blend/BlendDifference.sksl",
"$_tests/sksl/blend/BlendDst.sksl",
"$_tests/sksl/blend/BlendDstAtop.sksl",
"$_tests/sksl/blend/BlendDstIn.sksl",
"$_tests/sksl/blend/BlendDstOut.sksl",
"$_tests/sksl/blend/BlendDstOver.sksl",
"$_tests/sksl/blend/BlendExclusion.sksl",
"$_tests/sksl/blend/BlendHardLight.sksl",
"$_tests/sksl/blend/BlendHue.sksl",
"$_tests/sksl/blend/BlendLighten.sksl",
"$_tests/sksl/blend/BlendLuminosity.sksl",
"$_tests/sksl/blend/BlendModulate.sksl",
"$_tests/sksl/blend/BlendMultiply.sksl",
"$_tests/sksl/blend/BlendOverlap.sksl",
"$_tests/sksl/blend/BlendPlus.sksl",
"$_tests/sksl/blend/BlendSaturation.sksl",
"$_tests/sksl/blend/BlendScreen.sksl",
"$_tests/sksl/blend/BlendSoftLight.sksl",
"$_tests/sksl/blend/BlendSrc.sksl",
"$_tests/sksl/blend/BlendSrcAtop.sksl",
"$_tests/sksl/blend/BlendSrcIn.sksl",
"$_tests/sksl/blend/BlendSrcOut.sksl",
"$_tests/sksl/blend/BlendSrcOver.sksl",
"$_tests/sksl/blend/BlendXor.sksl",
Migrate Derivatives tests to golden outputs. Change-Id: I35ff25c4cc394c1a4a964207ece87095a9ba84cf Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317767 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-18 16:03:42 +00:00
"$_tests/sksl/glsl/Derivatives.sksl",
"$_tests/sksl/glsl/DerivativesFlipY.sksl",
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
"$_tests/sksl/glsl/TypePrecision.sksl",
Fix unit test for InlinerWrapsEarlyReturnsWithDoWhileBlock. This resolves the following TODO block: TODO(johnstiles): the skslc standalone caps bits do not enable do-while support, so this test does not actually perform as described; the `returny` function is not inlined at all. This will be fixed when customizable caps-bit support is added to the golden tests. Change-Id: I3495e4813b9be37264a8fda978453594c1f5fa13 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317859 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-18 19:41:31 +00:00
"$_tests/sksl/inliner/InlinerWrapsEarlyReturnsWithDoWhileBlock.sksl",
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
"$_tests/sksl/workarounds/AbsInt.sksl",
"$_tests/sksl/workarounds/FractNegative.sksl",
Migrate remaining SkSL GLSL tests to golden outputs. Change-Id: I72fd3083f75ca5bf74fb2c3b032465864a13aed5 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317771 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-18 18:42:58 +00:00
"$_tests/sksl/workarounds/FragCoords.sksl",
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
"$_tests/sksl/workarounds/LoopCondition.sksl",
"$_tests/sksl/workarounds/MinAndAbsTogether.sksl",
"$_tests/sksl/workarounds/NegatedAtan.sksl",
"$_tests/sksl/workarounds/PowWithConstantExponent.sksl",
Migrate remaining SkSL GLSL tests to golden outputs. Change-Id: I72fd3083f75ca5bf74fb2c3b032465864a13aed5 Bug: skia:10694 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317771 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-09-18 18:42:58 +00:00
"$_tests/sksl/workarounds/RewriteDoWhileLoops.sksl",
Migrate several GLSL workaround unit tests to golden files. We now support building an SkSL golden output twice, once honoring the custom #pragma settings, and once more ignoring the settings. This allows us to see the output of the workaround technique, alongside the "default-settings" output which should not contain a workaround. To implement this, skslc now supports a flag: --[no]settings. When it's set, /*#pragma settings*/ comments are honored. When it's not set, skslc ignores the comments. compile_sksl_tests.py passes this flag along to skslc. This approach is not strictly limited to workarounds; the "TypePrecision" GLSL test was also updated to use this technique. Change-Id: I79204df047b024533ed6bc1f4c088e0e878d5bb1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-09-16 21:46:37 +00:00
"$_tests/sksl/workarounds/TernaryShortCircuit.sksl",
]
Reference in New Issue Copy Permalink