skia2/tests/sksl/inliner/ForInitializerExpressionsCanBeInlined.glsl

14 lines
247 B
Plaintext
Raw Normal View History

out vec4 sk_FragColor;
bool shouldLoop(vec4 v) {
return v.x < 0.5;
}
vec4 grow(vec4 v) {
return v + vec4(0.125);
}
void main() {
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
for (sk_FragColor = vec4(0.0625);shouldLoop(sk_FragColor); sk_FragColor = grow(sk_FragColor)) {
}
Reland "Remove inliner from IR generation stage." This reverts commit 4c412bce4cacf556fbf87e9e9066ba709bc671f9. Reason for revert: investigating Pinpoint failure cases, if any Original change's description: > Revert "Reland "Remove inliner from IR generation stage."" > > This reverts commit e497a080651c05678cf4760fa6e4daa53a10355b. > > Reason for revert: Pinpoint disagrees > > Original change's description: > > Reland "Remove inliner from IR generation stage." > > > > This reverts commit 941fc7174fc20e8a8b707f1b636c85bbf2e1294f. > > > > Reason for revert: performance now seems to be roughly equal or better > > (~1%) over several trials. > > Nanobench: http://screen/A8e8sojaXBgbMgF > > > > Original change's description: > > > Revert "Remove inliner from IR generation stage." > > > > > > This reverts commit 21d7778cb5c13e729b513eaa22dbf53f58a877c8. > > > > > > Reason for revert: Pinpoint absolutely hates this change > > > > > > Original change's description: > > > > Remove inliner from IR generation stage. > > > > > > > > There is no need to inline code during IR generation, as the optimizer > > > > can now handle this. > > > > > > > > Change-Id: If272bfb98e945a75ec91fb4aa026e5631ac51b5b > > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/315971 > > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > Commit-Queue: Brian Osman <brianosman@google.com> > > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > > Auto-Submit: John Stiles <johnstiles@google.com> > > > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > > > Change-Id: I62c235415bcdc92a088e2a7f9c3d7dbf7e1bf669 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317976 > > > Reviewed-by: John Stiles <johnstiles@google.com> > > > Commit-Queue: John Stiles <johnstiles@google.com> > > > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > > > Change-Id: I6189806c678283188f4b67ee61e5886f88c2d6fc > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/324891 > > Reviewed-by: John Stiles <johnstiles@google.com> > > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> > > Commit-Queue: Ethan Nicholas <ethannicholas@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: I79149467565f22f53b8c28868dd53b80f3421137 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/325626 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Auto-Submit: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I2727bd4a2b43e8d12b36b1979ce6fe4a2d935380 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/335936 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-20 17:52:22 +00:00
}