skia2/gn/skia.gni

# Copyright 2019 Google LLC.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

declare_args() {
  skia_use_icu = !is_fuchsia && !is_ios && !is_win  # TODO: Windows
}
GN/ICU cleanup For targets that depend on ICU, only define if `skia_use_icu` is set. Move declare_args/skia_use_icu into skia.gni. Other variables that need to work like that can move there later. icu/BUILD.gn defines SK_USING_THIRD_PARTY_ICU if needed. SkShaper_harfbuzz.cpp SkPDFSubsetFont.cpp respects SK_USING_THIRD_PARTY_ICU when calling SkLoadICU(). sfntly/BUILD.gn, harfbuzz/BUILD.gn, icu/icu.gni uses $_src variable to reduce verbosity. icu/icu.gni adds more headersto sources. Change-Id: I9e000b9b19902d9f5c0c64e989bf42466aa8a299 Reviewed-on: https://skia-review.googlesource.com/c/189304 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com> 2019-02-04 20:36:31 +00:00			`# Copyright 2019 Google LLC.`
			`# Use of this source code is governed by a BSD-style license that can be`
			`# found in the LICENSE file.`

			`declare_args() {`
Revert "third_party/icu: use upstream" This reverts commit e6cfe7718592468518f15d4a95dfa194bd8ab57a. Reason for revert: Android & Win7 perf/test failures. Original change's description: > third_party/icu: use upstream > > Change DEPS to point at upstream, not chromium's fork. > `skia_use_icu` defaults to true everywhere but iOS > Clean up SkLoadICU: use U_ICUDATA_ENTRY_POINT, no DLL. > Add data dep to icu/icu.gni > Scripts: icu/{make_data_assembly.py,make_data_obj_win.py} > Scripts: icu/{update_icu.sh,build_icu_data_file.py} for rebuilding > document process in icu/README.md > > Bug: skia:8702 > Change-Id: I99789749ba84ae737f6c62475d0d676cd36715bb > Reviewed-on: https://skia-review.googlesource.com/c/186870 > Commit-Queue: Hal Canary <halcanary@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Ben Wagner <bungeman@google.com> TBR=halcanary@google.com,bungeman@google.com,fmalita@chromium.org,fmalita@google.com Change-Id: Id379bc2be7d53eca67b2c557ac20bd44073a6258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:8702 Reviewed-on: https://skia-review.googlesource.com/c/189647 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> 2019-02-06 02:28:24 +00:00			`skia_use_icu = !is_fuchsia && !is_ios && !is_win # TODO: Windows`
GN/ICU cleanup For targets that depend on ICU, only define if `skia_use_icu` is set. Move declare_args/skia_use_icu into skia.gni. Other variables that need to work like that can move there later. icu/BUILD.gn defines SK_USING_THIRD_PARTY_ICU if needed. SkShaper_harfbuzz.cpp SkPDFSubsetFont.cpp respects SK_USING_THIRD_PARTY_ICU when calling SkLoadICU(). sfntly/BUILD.gn, harfbuzz/BUILD.gn, icu/icu.gni uses $_src variable to reduce verbosity. icu/icu.gni adds more headersto sources. Change-Id: I9e000b9b19902d9f5c0c64e989bf42466aa8a299 Reviewed-on: https://skia-review.googlesource.com/c/189304 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com> 2019-02-04 20:36:31 +00:00			`}`
Revert "third_party/icu: use upstream" This reverts commit e6cfe7718592468518f15d4a95dfa194bd8ab57a. Reason for revert: Android & Win7 perf/test failures. Original change's description: > third_party/icu: use upstream > > Change DEPS to point at upstream, not chromium's fork. > `skia_use_icu` defaults to true everywhere but iOS > Clean up SkLoadICU: use U_ICUDATA_ENTRY_POINT, no DLL. > Add data dep to icu/icu.gni > Scripts: icu/{make_data_assembly.py,make_data_obj_win.py} > Scripts: icu/{update_icu.sh,build_icu_data_file.py} for rebuilding > document process in icu/README.md > > Bug: skia:8702 > Change-Id: I99789749ba84ae737f6c62475d0d676cd36715bb > Reviewed-on: https://skia-review.googlesource.com/c/186870 > Commit-Queue: Hal Canary <halcanary@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Ben Wagner <bungeman@google.com> TBR=halcanary@google.com,bungeman@google.com,fmalita@chromium.org,fmalita@google.com Change-Id: Id379bc2be7d53eca67b2c557ac20bd44073a6258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:8702 Reviewed-on: https://skia-review.googlesource.com/c/189647 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> 2019-02-06 02:28:24 +00:00