skia2/tests/sksl/runtime_errors/IllegalIndexing.skvm

### Compilation failed:

error: 25: index expression must be constant
error: 26: index expression must be constant
error: 29: index expression must be constant
3 errors
Enforce ES2 limits on indexing expressions (in runtime effects) This enforces an even stricter version of the rules from GLSL ES 1.0 Appendix A, Section 5. Essentially, indices (to arrays, vectors, matrices) must be made of literals, loop indices, and expressions made of those two. Bug: skia:10837 Bug: skia:11096 Change-Id: I437a5ed64da58e24d5991ddbde68859f5214e98b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354665 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-01-15 18:20:32 +00:00			`### Compilation failed:`

			`error: 25: index expression must be constant`
Align SkSL const rules more closely with GLSL This adds Analysis::IsConstantExpression, to determine if an expression is a constant-expression. It now expands to cover 'const' local and global variables, because we also enforce that the initializer on those variables is - in turn - a constant expression. This fixes 10837 - previously you could initialize a const variable with a non-constant expression, and we'd emit GLSL that contained that same pattern, which would fail to compile at the driver level. That should not be possible any longer. Bug: skia:10679 Bug: skia:10837 Change-Id: I517820ef4da57fff45768c0b04c55aebc18d3272 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/375856 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> 2021-02-25 16:25:30 +00:00			`error: 26: index expression must be constant`
Enforce ES2 limits on indexing expressions (in runtime effects) This enforces an even stricter version of the rules from GLSL ES 1.0 Appendix A, Section 5. Essentially, indices (to arrays, vectors, matrices) must be made of literals, loop indices, and expressions made of those two. Bug: skia:10837 Bug: skia:11096 Change-Id: I437a5ed64da58e24d5991ddbde68859f5214e98b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/354665 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-01-15 18:20:32 +00:00			`error: 29: index expression must be constant`
Align SkSL const rules more closely with GLSL This adds Analysis::IsConstantExpression, to determine if an expression is a constant-expression. It now expands to cover 'const' local and global variables, because we also enforce that the initializer on those variables is - in turn - a constant expression. This fixes 10837 - previously you could initialize a const variable with a non-constant expression, and we'd emit GLSL that contained that same pattern, which would fail to compile at the driver level. That should not be possible any longer. Bug: skia:10679 Bug: skia:10837 Change-Id: I517820ef4da57fff45768c0b04c55aebc18d3272 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/375856 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> 2021-02-25 16:25:30 +00:00			`3 errors`