AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
ece1d794b9
skia2/tests/sksl/shared/GaussianBlur.metal

138 lines
8.3 KiB
Metal
Raw Normal View History

Revert "Only include header once in combined MSL shader." This reverts commit e7a8f85e4f224d49323689a346e68196b40b7d65. Reason for revert: must revert dependent CL Original change's description: > Only include header once in combined MSL shader. > > Bug: skia:11389 > Change-Id: I3e24dcaa2cfeddc7efd7985f9f42a59bfc8175f2 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385137 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> TBR=jvanverth@google.com,johnstiles@google.com Change-Id: I7a886b6c57a666e54e65365e41dcb57bd9ab4ba6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:11389 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385237 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>
2021-03-16 14:40:11 +00:00
#include <metal_stdlib>
#include <simd/simd.h>
using namespace metal;
Add unit test demonstrating output from Gaussian blur. Change-Id: I1be21b428939d17bbf3a9347a64db56c7cd69eb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337638 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-23 19:46:55 +00:00
struct Inputs {
float2 vLocalCoord_Stage0 [[user(locn0)]];
};
struct Outputs {
float4 sk_FragColor [[color(0)]];
};
struct uniformBuffer {
float4 sk_RTAdjust;
float2 uIncrement_Stage1_c0;
char pad0[8];
Reland "Improve support for arrays in Metal." This reverts commit 38df4c8470ab3db7455005ab0c3599a95c791d2b. Reason for revert: updated ArrayTypes test for ES2 compatibility Original change's description: > Revert "Improve support for arrays in Metal." > > This reverts commit dd904af5666b4746d4b9af5c1f03b47ac3ec73b2. > > Reason for revert: breaks ANGLE > > Original change's description: > > Improve support for arrays in Metal. > > > > Arrays in Metal now use the `array<T, N>` type instead of the C-style > > `T[N]` type. This gives them semantics much more in line with GLSL, > > so they can be initialized and assigned like GLSL arrays. > > > > This allows the ArrayTypes and Assignment tests to pass, so they have > > been added to our dm SkSL tests. (ArrayConstructors also passes, but > > is not ES2-compliant so it is not enabled.) > > > > Change-Id: Id1028311963084befd0e044e11e223af6a064dda > > Bug: skia:10761, skia:10760, skia:11022, skia:10939 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365699 > > Commit-Queue: John Stiles <johnstiles@google.com> > > Auto-Submit: John Stiles <johnstiles@google.com> > > Reviewed-by: Brian Osman <brianosman@google.com> > > TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com > > Change-Id: If6a18dea7d6a45fa7836e9129bf81c2e536f07e3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia:10761 > Bug: skia:10760 > Bug: skia:11022 > Bug: skia:10939 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/365976 > Reviewed-by: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Bug: skia:10761 Bug: skia:10760 Bug: skia:11022 Bug: skia:10939 Change-Id: Ia1c4917f5d3c41162d282b3093814d861707ad30 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/366144 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-02-04 15:57:08 +00:00
array<float4, 7> uKernel_Stage1_c0;
Add unit test demonstrating output from Gaussian blur. Change-Id: I1be21b428939d17bbf3a9347a64db56c7cd69eb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337638 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-23 19:46:55 +00:00
float3x3 umatrix_Stage1_c0_c0;
float4 uborder_Stage1_c0_c0_c0;
float4 usubset_Stage1_c0_c0_c0;
float4 unorm_Stage1_c0_c0_c0;
};
struct Globals {
constant uniformBuffer* _anonInterface0;
texture2d<float> uTextureSampler_0_Stage1;
sampler uTextureSampler_0_Stage1Smplr;
};
Inline functions of the form 'return (expr)' only. This drastically reduces the number of functions which we allow to be inlined. If this change does not hurt our performance, it will allow us to trivially remove hundreds of LOC. All current data leads us to believe that it may affect the Mali 400 but is highly unlikely to change results on any other device in the tree. More info: http://go/optimization-in-sksl-inliner Change-Id: Ia6b706742ce5407453e0e697b6c1f9201084c0e8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384858 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
2021-03-15 18:30:06 +00:00
float4 MatrixEffect_Stage1_c0_c0(thread Globals& _globals, float4 _input, float2 _coords) {
Reduce unnecessary scratch variables in Inliner. Arguments without side-effects that aren't read from more than once can be moved directly into the inlined function, and don't need a scratch variable. This can allow functions like `guarded_divide` to inline completely in more cases. Change-Id: I0bfce35635cf9779f4af1bc0790da966ccfe4230 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/386678 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-03-19 13:39:44 +00:00
float2 _1_inCoord = (_globals._anonInterface0->umatrix_Stage1_c0_c0 * float3(_coords, 1.0)).xy;
_1_inCoord *= _globals._anonInterface0->unorm_Stage1_c0_c0_c0.xy;
float2 _2_subsetCoord;
_2_subsetCoord.x = _1_inCoord.x;
_2_subsetCoord.y = _1_inCoord.y;
float2 _3_clampedCoord;
_3_clampedCoord = _2_subsetCoord;
float4 _4_textureColor = _globals.uTextureSampler_0_Stage1.sample(_globals.uTextureSampler_0_Stage1Smplr, _3_clampedCoord * _globals._anonInterface0->unorm_Stage1_c0_c0_c0.zw);
float _5_snappedX = floor(_1_inCoord.x + 0.0010000000474974513) + 0.5;
if (_5_snappedX < _globals._anonInterface0->usubset_Stage1_c0_c0_c0.x || _5_snappedX > _globals._anonInterface0->usubset_Stage1_c0_c0_c0.z) {
_4_textureColor = _globals._anonInterface0->uborder_Stage1_c0_c0_c0;
Revert "Inline functions of the form 'return (expr)' only." This reverts commit 92748af1a5051e9fe329c8200f0fa3b47aadbdd7. Reason for revert: SkSLCommaSideEffects_GPU crashing on Android Original change's description: > Inline functions of the form 'return (expr)' only. > > This drastically reduces the number of functions which we allow to be > inlined. If this change does not hurt our performance, it will allow us > to trivially remove hundreds of LOC. All current data leads us to > believe that it may affect the Mali 400 but is highly unlikely to change > results on any other device in the tree. > > More info: http://go/optimization-in-sksl-inliner > > Change-Id: Ia6b706742ce5407453e0e697b6c1f9201084c0e8 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/384858 > Auto-Submit: John Stiles <johnstiles@google.com> > Commit-Queue: John Stiles <johnstiles@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Ethan Nicholas <ethannicholas@google.com> TBR=brianosman@google.com,ethannicholas@google.com,johnstiles@google.com Change-Id: I6a670dacaa58fe3386ff50375ac6d1cac4fd7f2c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/385161 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
2021-03-15 22:08:38 +00:00
}
Reduce unnecessary scratch variables in Inliner. Arguments without side-effects that aren't read from more than once can be moved directly into the inlined function, and don't need a scratch variable. This can allow functions like `guarded_divide` to inline completely in more cases. Change-Id: I0bfce35635cf9779f4af1bc0790da966ccfe4230 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/386678 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-03-19 13:39:44 +00:00
return _4_textureColor;
Avoid inlining functions that are called repeatedly. Previously, we'd gauge suitability for inlining by counting the nodes in a function; past a certain limit, the function was considered "too big." Now, we also incorporate the number of times that function is called. So if a function is called three times, and its size is 20 nodes, it would be considered to have an inlining cost of 60 (3 * 20) instead of 20. This should tamp down the aggressive nature of the inliner in cases like gaussian convolution or complicated blends, and will hopefully satisfy Pinpoint. No change visible in Nanobench (which doesn't test any of these sorts of patterns, but certainly inlines things): http://screen/AwD5hkgkEfjVx4g Change-Id: Ie5e32898245ac854adb9ddd52d87001df6a67125 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337676 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2020-11-23 19:48:06 +00:00
}
Add unit test demonstrating output from Gaussian blur. Change-Id: I1be21b428939d17bbf3a9347a64db56c7cd69eb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337638 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-23 19:46:55 +00:00
fragment Outputs fragmentMain(Inputs _in [[stage_in]], texture2d<float> uTextureSampler_0_Stage1[[texture(0)]], sampler uTextureSampler_0_Stage1Smplr[[sampler(0)]], constant uniformBuffer& _anonInterface0 [[buffer(0)]], bool _frontFacing [[front_facing]], float4 _fragCoord [[position]]) {
Remove unnecessary _out pointer in Metal. Like _globals, it's not actually necessary to indirect through a separate pointer at all. The output struct is now passed by reference and the additional pointer variable is removed. (Additionally, renamed _skGlobals back to _globals.) Change-Id: Id089a20cb751cdaedc48462a52da78ee43783611 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/355632 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-01-19 18:07:55 +00:00
Globals _globals{&_anonInterface0, uTextureSampler_0_Stage1, uTextureSampler_0_Stage1Smplr};
Squelch Metal warnings about unused _globals/_out. Change-Id: I84e546184d1ce8261602346d2c91c580b30e9b6d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/357001 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Reviewed-by: Adlai Holler <adlai@google.com>
2021-01-22 03:24:28 +00:00
(void)_globals;
Remove unnecessary _out pointer in Metal. Like _globals, it's not actually necessary to indirect through a separate pointer at all. The output struct is now passed by reference and the additional pointer variable is removed. (Additionally, renamed _skGlobals back to _globals.) Change-Id: Id089a20cb751cdaedc48462a52da78ee43783611 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/355632 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-01-19 18:07:55 +00:00
Outputs _out;
Squelch Metal warnings about unused _globals/_out. Change-Id: I84e546184d1ce8261602346d2c91c580b30e9b6d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/357001 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Reviewed-by: Adlai Holler <adlai@google.com>
2021-01-22 03:24:28 +00:00
(void)_out;
Performance experiment: disable control-flow analysis. This CL will be used to test for potential performance regressions (or improvements) that we might cause by disabling this optimization pass. It will be reverted in ~1 day. Change-Id: I26b7687c341eb6d81231406381c39869cfccf6d6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/381259 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-08 18:29:15 +00:00
float4 outputColor_Stage0;
float4 outputCoverage_Stage0;
{
outputColor_Stage0 = float4(1.0);
outputCoverage_Stage0 = float4(1.0);
}
Add unit test demonstrating output from Gaussian blur. Change-Id: I1be21b428939d17bbf3a9347a64db56c7cd69eb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337638 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-23 19:46:55 +00:00
float4 output_Stage1;
Reduce unnecessary scratch variables in Inliner. Arguments without side-effects that aren't read from more than once can be moved directly into the inlined function, and don't need a scratch variable. This can allow functions like `guarded_divide` to inline completely in more cases. Change-Id: I0bfce35635cf9779f4af1bc0790da966ccfe4230 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/386678 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-03-19 13:39:44 +00:00
float4 _6_output;
_6_output = float4(0.0, 0.0, 0.0, 0.0);
float2 _7_coord = _in.vLocalCoord_Stage0 - 12.0 * _globals._anonInterface0->uIncrement_Stage1_c0;
float2 _8_coordSampled = float2(0.0, 0.0);
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[0].x;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[0].y;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[0].z;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[0].w;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[1].x;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[1].y;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[1].z;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[1].w;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[2].x;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[2].y;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[2].z;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[2].w;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[3].x;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[3].y;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[3].z;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[3].w;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[4].x;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[4].y;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[4].z;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[4].w;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[5].x;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[5].y;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[5].z;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[5].w;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_8_coordSampled = _7_coord;
_6_output += MatrixEffect_Stage1_c0_c0(_globals, outputColor_Stage0, _8_coordSampled) * _globals._anonInterface0->uKernel_Stage1_c0[6].x;
_7_coord += _globals._anonInterface0->uIncrement_Stage1_c0;
_6_output *= outputColor_Stage0;
output_Stage1 = _6_output;
Add unit test demonstrating output from Gaussian blur. Change-Id: I1be21b428939d17bbf3a9347a64db56c7cd69eb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337638 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-23 19:46:55 +00:00
{
Performance experiment: disable control-flow analysis. This CL will be used to test for potential performance regressions (or improvements) that we might cause by disabling this optimization pass. It will be reverted in ~1 day. Change-Id: I26b7687c341eb6d81231406381c39869cfccf6d6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/381259 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2021-03-08 18:29:15 +00:00
_out.sk_FragColor = output_Stage1 * outputCoverage_Stage0;
Add unit test demonstrating output from Gaussian blur. Change-Id: I1be21b428939d17bbf3a9347a64db56c7cd69eb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337638 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-23 19:46:55 +00:00
}
Remove unnecessary _out pointer in Metal. Like _globals, it's not actually necessary to indirect through a separate pointer at all. The output struct is now passed by reference and the additional pointer variable is removed. (Additionally, renamed _skGlobals back to _globals.) Change-Id: Id089a20cb751cdaedc48462a52da78ee43783611 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/355632 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
2021-01-19 18:07:55 +00:00
return _out;
Add unit test demonstrating output from Gaussian blur. Change-Id: I1be21b428939d17bbf3a9347a64db56c7cd69eb4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/337638 Commit-Queue: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2020-11-23 19:46:55 +00:00
}
Reference in New Issue Copy Permalink