AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
ed4ff9c9d0
skia2/infra/bots/recipe_modules/flavor/examples/full.py

240 lines
9.4 KiB
Python
Raw Normal View History

Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
DEPS = [
'flavor',
'recipe_engine/properties',
'recipe_engine/raw_io',
'run',
'vars',
]
Recipes: remove some pragma: no cover These are the remaining instances, and they're harder to deal with: $ git grep pragma recipe_modules/swarming/api.py: except self.m.step.StepFailure as e: # pragma: no cover recipe_modules/swarming/api.py: if len(ids) > 1: # pragma: nocover recipes/ct_skps.py: if api.path.exists(version_file): # pragma: nocover recipes/ct_skps.py: if api.path.exists(blacklist_file): # pragma: nocover recipes/upload_nano_results.py: if len(results) != 1: # pragma: nocover Bug: skia:6473 Change-Id: If75e2ffcf39a944b513b9005bbc4bd9c4fb031f6 Reviewed-on: https://skia-review.googlesource.com/13867 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 18:39:21 +00:00
def test_exceptions(api):
try:
api.flavor.copy_directory_contents_to_device('src', 'dst')
except ValueError:
pass
try:
api.flavor.copy_directory_contents_to_host('src', 'dst')
except ValueError:
pass
try:
api.flavor.copy_file_to_device('src', 'dst')
except ValueError:
pass
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
def RunSteps(api):
api.vars.setup()
api.flavor.setup()
Recipes: remove some pragma: no cover These are the remaining instances, and they're harder to deal with: $ git grep pragma recipe_modules/swarming/api.py: except self.m.step.StepFailure as e: # pragma: no cover recipe_modules/swarming/api.py: if len(ids) > 1: # pragma: nocover recipes/ct_skps.py: if api.path.exists(version_file): # pragma: nocover recipes/ct_skps.py: if api.path.exists(blacklist_file): # pragma: nocover recipes/upload_nano_results.py: if len(results) != 1: # pragma: nocover Bug: skia:6473 Change-Id: If75e2ffcf39a944b513b9005bbc4bd9c4fb031f6 Reviewed-on: https://skia-review.googlesource.com/13867 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 18:39:21 +00:00
if api.properties.get('is_testing_exceptions') == 'True':
return test_exceptions(api)
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
api.flavor.compile('dm')
api.flavor.copy_extra_build_products(api.vars.swarming_out_dir)
Manually roll skia recipe deps. This includes: recipes-py: https://chromium.googlesource.com/external/github.com/luci/recipes-py/+log/f5e47cfc28b5964701572db12f96c7a5a3f1821a..554e8878ac6395262dc3c90bbb8a100ee844f766 depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/109907e6a95ae0301b1564c76c4a3e9d15e19366..1e71b8bdf0913b306b28141192272350cf68cdc2 tools/build: https://chromium.googlesource.com/chromium/tools/build/+log/f7b41106d64b6517c67343f2cfb03f4a9d62afc2..dcca7cbe7ecda2c4d511f38c6f3eab29cad08cf7 The ranges include my generic postprocess/merge change in tools/build that had been failing to roll over in https://skia-review.googlesource.com/c/13920/ along with a few corresponding fixes. Change-Id: I7e328bdb3acfc9b4c219e408c226f181f3b05f3d Reviewed-on: https://skia-review.googlesource.com/14678 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Eric Boren <borenet@google.com>
2017-04-29 01:59:04 +00:00
assert str(api.flavor.out_dir) != ''
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
if 'Build' not in api.properties['buildername']:
try:
api.flavor.copy_file_to_device('file.txt', 'file.txt')
api.flavor.create_clean_host_dir('results_dir')
api.flavor.create_clean_device_dir('device_results_dir')
api.flavor.install_everything()
Fix Chromebook output step and skpbench They pull stuff of using scp, which does not perform well if a directory does not exist. Skpbench also needs to be updated to use new adb. Bug: skia: NOTRY=true Change-Id: I1e9f2dbddaab05e1aeb4d71d97f1e6e4bfdd299a Reviewed-on: https://skia-review.googlesource.com/59081 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-12 19:15:47 +00:00
if 'Test' in api.properties['buildername']:
api.flavor.step('dm', ['dm', '--some-flag'])
api.flavor.copy_directory_contents_to_host(
api.flavor.device_dirs.dm_dir, api.vars.dm_dir)
elif 'Perf' in api.properties['buildername']:
api.flavor.step('nanobench', ['nanobench', '--some-flag'])
api.flavor.copy_directory_contents_to_host(
api.flavor.device_dirs.perf_data_dir, api.vars.perf_data_dir)
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
finally:
api.flavor.cleanup_steps()
api.run.check_failure()
TEST_BUILDERS = [
Add new Android builder which uses API_LEVEL 26 Bug: skia:6870 Change-Id: Idd9a27518c1123c0a729b4d07461047f5530aae3 Reviewed-on: https://skia-review.googlesource.com/24960 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-07-20 14:21:38 +00:00
'Build-Debian9-Clang-arm-Release-Android_API26',
Add Pixelbook to tree Bug: skia:7249 NOTRY=true Change-Id: I7ab6bc28d567ca5ae75df9c1e56b46c307032024 Reviewed-on: https://skia-review.googlesource.com/66143 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 13:34:08 +00:00
'Build-Debian9-Clang-arm-Release-Chromebook_GLES',
target Android M for -arm- ASAN builds Change-Id: I8154b9a0b2fcf76fa02af0efa6b57425c6f9ac31 Reviewed-on: https://skia-review.googlesource.com/101580 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
2018-01-29 23:38:16 +00:00
'Build-Debian9-Clang-arm-Release-Android_ASAN',
Add Android ASAN bot It should work on 32 and 64 bit android running M or newer. Bug: skia: Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c Reviewed-on: https://skia-review.googlesource.com/93700 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-12 19:31:48 +00:00
'Build-Debian9-Clang-arm64-Release-Android_ASAN',
Test SKQP on Firebase Testlab and Upload - adds building the testlab driver (run_testlab) as a separate step - adds gcloud isolate necessary to run testlab - adds Testlab support and uploading a verified AKP to GCS (with meta data attached). Bug: skia: Change-Id: I1bf265f46c99360eb3a9eb684886f93de48085fe Reviewed-on: https://skia-review.googlesource.com/111603 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
2018-03-07 19:44:44 +00:00
'Build-Debian9-Clang-universal-devrel-Android_SKQP',
Add Pixelbook to tree Bug: skia:7249 NOTRY=true Change-Id: I7ab6bc28d567ca5ae75df9c1e56b46c307032024 Reviewed-on: https://skia-review.googlesource.com/66143 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 13:34:08 +00:00
'Build-Debian9-Clang-x86_64-Debug-Chromebook_GLES',
Switch many jobs to Clang. No-Try: true Change-Id: Ie255d46ff50d13d25d045791c1c3066f06ab9243 Reviewed-on: https://skia-review.googlesource.com/53601 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2017-10-02 20:53:07 +00:00
'Build-Debian9-Clang-x86_64-Debug-SK_USE_DISCARDABLE_SCALEDIMAGECACHE',
[recipes] Update example builder names. Change-Id: If3532bcb5bef5fad8c950d6844135ad3597d2674 Reviewed-on: https://skia-review.googlesource.com/51380 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-26 18:11:15 +00:00
'Build-Debian9-Clang-x86_64-Release-Fast',
'Build-Debian9-Clang-x86_64-Release-Mini',
Add bot which builds without DEPS Bug: skia:7646 Change-Id: Iddf55940230c99fea9d838a1b03a8c3bb476262e Reviewed-on: https://skia-review.googlesource.com/109360 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2018-02-22 15:03:56 +00:00
'Build-Debian9-Clang-x86_64-Release-NoDEPS',
[recipes] Update example builder names. Change-Id: If3532bcb5bef5fad8c950d6844135ad3597d2674 Reviewed-on: https://skia-review.googlesource.com/51380 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-26 18:11:15 +00:00
'Build-Debian9-Clang-x86_64-Release-Vulkan',
'Build-Debian9-EMCC-wasm-Release',
resources: optionally link them into our binary To enable, set skia_embed_resources=true in args.gn. Also add *-EmbededResouces bots. Change-Id: Ia69b26e926a3ad4676a4fa021894432ea2104538 Reviewed-on: https://skia-review.googlesource.com/82626 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2017-12-08 18:35:47 +00:00
'Build-Debian9-GCC-x86_64-Debug-EmbededResouces',
[recipes] Update example builder names. Change-Id: If3532bcb5bef5fad8c950d6844135ad3597d2674 Reviewed-on: https://skia-review.googlesource.com/51380 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-26 18:11:15 +00:00
'Build-Debian9-GCC-x86_64-Release-ANGLE',
'Build-Debian9-GCC-x86_64-Release-Flutter_Android',
'Build-Debian9-GCC-x86_64-Release-NoGPU',
'Build-Debian9-GCC-x86_64-Release-PDFium',
'Build-Debian9-GCC-x86_64-Release-PDFium_SkiaPaths',
'Build-Debian9-GCC-x86_64-Release-Shared',
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
'Build-Mac-Clang-arm64-Debug-Android_Vulkan',
Switch to updated Mac bots. Bug: skia:7408 Change-Id: I26273df7871e3ee01e227636421962fcc6251e7d Reviewed-on: https://skia-review.googlesource.com/88080 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-03 21:15:33 +00:00
'Build-Mac-Clang-arm64-Debug-iOS',
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
'Build-Mac-Clang-x86_64-Debug-CommandBuffer',
Add Metal build bot Bug: skia:6896 Change-Id: If2ed083703e6300b9d2a86cfb298011bbf54e018 Reviewed-on: https://skia-review.googlesource.com/28180 Reviewed-by: Eric Boren <borenet@google.com>
2017-07-28 18:18:43 +00:00
'Build-Mac-Clang-x86_64-Debug-Metal',
Stop adding Android-specific defines to SkUserConfig Remove #defines that lived in gn_to_bp.py and android_framework_defines.gni. These have been moved into a new file in Android, SkUserConfigManual.h, in https://googleplex-android-review.git.corp.google.com/#/c/2519600/ Update gn_to_bp.py to include SkUserConfigManual.h, so it will still result in using the same #defines. Lately, we've found it difficult to guard changes behind a flag. e.g. a change to drawing causes a CTS failure in Android, so we have to do the following: - put the change behind a flag, and add it to gn_to_bp.py or android_framework_defines.gni - generate new images on Android (by running CTS with external/skia modified to not define the flag) - create a CL in CTS that uses the new images - land a CL in Skia that stops defining the flag - when the Skia change lands, wait for the auto-roller to create a CL that includes the change, stop the auto-roller, add the topic to the CTS CL so the two can land at the same time - land both Android changes (with TreeHugger) - restart the Android auto-roller With SkUserConfigManual.h (which lives in Android), the process will be similar to Chromium: - land a CL in Android's external/skia that defines a flag e.g. SK_SUPPORT_LEGACY_FEATURE. Land without TreeHugger because it isn't used in Skia and does not do anything - land a change in Skia that changes behavior unless SK_SUPPORT_LEGACY_FEATURE is defined. This will safely go through the Android roll and not change any behavior for Android - create two Android CLs - one in CTS to use the new images, and one in external/skia to delete SK_SUPPORT_LEGACY_FEATURE. Set them to the same topic and land them with TreeHugger In the new process, there is no need to mess with the Android roll. A downside to the new process is that we cannot test the android framework defines without checking in to Android. But given how much we've progressed in automating Android testing, this is fine. Bug: b/63429612 Change-Id: Idfbaef2f4cae641a75fb6e7bf70428733a441336 Reviewed-on: https://skia-review.googlesource.com/22072 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-07-11 19:53:41 +00:00
'Build-Win-Clang-arm64-Release-Android',
Reland "Switch Win Exceptions Build to Clang." This reverts commit 2f2419b936150e24ca1aea891ba405c8ea8ebdc7. Reason for revert: Creating CL to reland Original change's description: > Revert "Switch Win Exceptions Build to Clang." > > This reverts commit e1cb4778c70a6bef543a8936c5521a71a037f551. > > Reason for revert: Need to revert dependency https://skia-review.googlesource.com/c/skia/+/114093 > > Original change's description: > > Switch Win Exceptions Build to Clang. > > > > No-Try: true > > Change-Id: I119c7853299b6eef65f991b41cbb2afb0a35f431 > > Reviewed-on: https://skia-review.googlesource.com/113673 > > Commit-Queue: Ben Wagner <benjaminwagner@google.com> > > Reviewed-by: Mike Klein <mtklein@google.com> > > TBR=mtklein@google.com,benjaminwagner@google.com > > Change-Id: I36f4c6cdf890043d4b77b8d5347b4752f58ebd33 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/114420 > Reviewed-by: Ben Wagner <benjaminwagner@google.com> > Commit-Queue: Ben Wagner <benjaminwagner@google.com> TBR=mtklein@google.com,benjaminwagner@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie4ba6c264b3ab2b3c63ac0e225638b0a4e70cda1 Reviewed-on: https://skia-review.googlesource.com/114822 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-03-20 20:36:16 +00:00
'Build-Win-Clang-x86-Debug-Exceptions',
Switch many jobs to Clang. No-Try: true Change-Id: Ie255d46ff50d13d25d045791c1c3066f06ab9243 Reviewed-on: https://skia-review.googlesource.com/53601 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
2017-10-02 20:53:07 +00:00
'Build-Win-Clang-x86_64-Debug-GDI',
add a Win/Clang build bot BUG=skia:2679 CQ_INCLUDE_TRYBOTS=skia.primary:Build-Win-Clang-x86_64-Release Change-Id: I861366ae1340abcc67e87041904d08337b465bbe Reviewed-on: https://skia-review.googlesource.com/28864 Reviewed-by: Eric Boren <borenet@google.com>
2017-07-31 18:57:20 +00:00
'Build-Win-Clang-x86_64-Release',
Switch most Win Vulkan jobs to Clang. Update examples in recipes. Change-Id: I096f259e8daa46af8626158a820fe226e99cd159 Reviewed-on: https://skia-review.googlesource.com/58200 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-10-11 04:23:58 +00:00
'Build-Win-Clang-x86_64-Release-Vulkan',
Add a bot to verify that generated SKSL files have not been hand-edited Bug: skia:6893 Change-Id: I54480ddd1ad1989661393500044f9164a99ce7b0 Reviewed-on: https://skia-review.googlesource.com/27700 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-07-28 11:35:28 +00:00
'Housekeeper-PerCommit-CheckGeneratedFiles',
Scale extra CPUs to powersave during nanobench. This scaling logic correctly accounts for some devices which have multiple CPUs. Previously, we were scaling the smaller of these CPUs, which likely had a negative impact on nanobench, given nanobench was single threaded and the CPUs weren't allowed to idle much (because we set the CPU). This CL sets those additional CPUs to powersave when we run nanobench and then correctly scales down the beefier CPU we want to run nanobench on. For DM, we just run it in ondemand mode, which will hopefully be "as fast as possible", but allow the CPU governor to scale down if overheating becomes a problem. Bug: skia:7378 notry=TRUE Change-Id: I45ca5d9fb32182233d1b2d094842c879f2b84da4 Reviewed-on: https://skia-review.googlesource.com/83240 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
2017-12-12 12:33:48 +00:00
'Perf-Android-Clang-GalaxyS7_G930FD-GPU-MaliT880-arm64-Debug-All-Android',
Trying gpu scaling on Nexus 5 and 5x We do some of this already in skpbench. Bug: skia: Change-Id: Ia698466e83f9b476644c126747a2f89346361d13 Reviewed-on: https://skia-review.googlesource.com/93561 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2018-01-11 18:02:51 +00:00
'Perf-Android-Clang-Nexus5x-GPU-Adreno418-arm64-Debug-All-Android',
'Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Debug-All-Android',
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
'Perf-Android-Clang-Pixel-GPU-Adreno530-arm64-Debug-All-Android',
Rename chromebook jobs to be more human friendly Bug: skia: NOTRY=true Change-Id: I500eae85ec334dc7121266ebd2f41dc526ec4695 Reviewed-on: https://skia-review.googlesource.com/66880 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 16:03:22 +00:00
'Perf-ChromeOS-Clang-SamsungChromebookPlus-GPU-MaliT860-arm-Release-All',
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
'Perf-Chromecast-GCC-Chorizo-CPU-Cortex_A7-arm-Release-All',
'Perf-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-MSAN',
'Perf-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-ASAN',
'Perf-Ubuntu14-GCC-GCE-CPU-AVX2-x86_64-Release-All-CT_BENCH_1k_SKPs',
Fix scaling logic for NexusPlayer and AndroidOne They seem to be their own special cases for what governors they support. Bug: skia: NOTRY=true Change-Id: I7bb220e1d3ba6851c17c7e6ef327aab24ffdba42 Reviewed-on: https://skia-review.googlesource.com/83900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-12 13:14:19 +00:00
'Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-All-Android',
Put CPU frequency scaling in recipes Bug: skia: Change-Id: I994f67c3043306d7fa612feb03f8fbe8d7bf4c91 Reviewed-on: https://skia-review.googlesource.com/73760 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-11-20 21:06:06 +00:00
'Test-Android-Clang-GalaxyS7_G930FD-GPU-MaliT880-arm64-Debug-All-Android',
Use full paths for adb Add logic to run on Nexus 5xs in Golo. Bug:788839 Change-Id: I12290d11a0b1b0f012ada216da3e5b2599979c5e Reviewed-on: https://skia-review.googlesource.com/81861 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-12-07 16:19:31 +00:00
'Test-Android-Clang-Nexus5x-GPU-Adreno418-arm64-Debug-All-Android',
Add Android ASAN bot It should work on 32 and 64 bit android running M or newer. Bug: skia: Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c Reviewed-on: https://skia-review.googlesource.com/93700 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-01-12 19:31:48 +00:00
'Test-Android-Clang-Nexus5x-GPU-Adreno418-arm64-Release-All-Android_ASAN',
Add Nexus7 CPU jobs. Bug: skia:7381 Change-Id: I2dd5443c81cd895eb1d68b0cd90221a7e2e07d46 No-Try: true Reviewed-on: https://skia-review.googlesource.com/80843 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-07 15:23:07 +00:00
'Test-Android-Clang-Nexus7-CPU-Tegra3-arm-Release-All-Android',
Put CPU frequency scaling in recipes Bug: skia: Change-Id: I994f67c3043306d7fa612feb03f8fbe8d7bf4c91 Reviewed-on: https://skia-review.googlesource.com/73760 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-11-20 21:06:06 +00:00
'Test-Android-Clang-Pixel-GPU-Adreno530-arm64-Debug-All-Android',
Rename chromebook jobs to be more human friendly Bug: skia: NOTRY=true Change-Id: I500eae85ec334dc7121266ebd2f41dc526ec4695 Reviewed-on: https://skia-review.googlesource.com/66880 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 16:03:22 +00:00
'Test-ChromeOS-Clang-SamsungChromebookPlus-GPU-MaliT860-arm-Release-All',
Test SKQP on Firebase Testlab and Upload - adds building the testlab driver (run_testlab) as a separate step - adds gcloud isolate necessary to run testlab - adds Testlab support and uploading a verified AKP to GCS (with meta data attached). Bug: skia: Change-Id: I1bf265f46c99360eb3a9eb684886f93de48085fe Reviewed-on: https://skia-review.googlesource.com/111603 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
2018-03-07 19:44:44 +00:00
'Test-Debian9-Clang-GCE-CPU-AVX2-universal-devrel-All-Android_SKQP',
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
'Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-Coverage',
'Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Release-All-TSAN',
'Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-All',
Remove Linux IntelIris540 jobs. Replacing IntelIris540 with IntelIris640, added in https://skia-review.googlesource.com/c/skia/+/87202. I verified that Gold results are still identical (modulo flakes). See also https://skia-review.googlesource.com/c/skia/+/87721 and https://skia-review.googlesource.com/c/skia/+/78640. No-Try: true Change-Id: Ifc7e80e92d6203d922e00b59127b136632af7afc Reviewed-on: https://skia-review.googlesource.com/88427 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-12-21 15:49:58 +00:00
'Test-Ubuntu16-Clang-NUC7i5BNK-GPU-IntelIris640-x86_64-Debug-All-Vulkan',
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
('Test-Ubuntu17-GCC-Golo-GPU-QuadroP400-x86_64-Release-All'
[recipes] Update example builder names. Change-Id: If3532bcb5bef5fad8c950d6844135ad3597d2674 Reviewed-on: https://skia-review.googlesource.com/51380 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-26 18:11:15 +00:00
'-Valgrind_AbandonGpuContext_SK_CPU_LIMIT_SSE41'),
Add ProcDump support to gn_flavor.py. Adds procdump_win asset. Enable ProcDump for some of the jobs failing in skia:7177 as a test case. If it has no ill effect, we can proceed with enabling it for all Win bots (and remove "ProcDump" tag). Bug: skia:7626, skia:7177 Change-Id: I50c67ecfca86fe0c6d91d5f970f81485cc9cfd0a Reviewed-on: https://skia-review.googlesource.com/113265 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2018-03-09 18:42:56 +00:00
'Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Release-All-Vulkan_ProcDump',
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
'Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-All',
'Test-iOS-Clang-iPadPro-GPU-GT7800-arm64-Debug-All',
add -SafeStack bots These bots use https://clang.llvm.org/docs/SafeStack.html. This separates the safe (constant size?) parts of the stack like return address and some local variables apart from the unsafe over- and underflow prone array uses. These go on the "unsafe stack". In theory this makes sense on {Linux,Mac}x{Debug,Release}, but let's just start with Linux/Debug. Change-Id: I9f5cbeb7081e7d9ac8e1298ca0d86880a6085cfa Reviewed-on: https://skia-review.googlesource.com/62743 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
2017-10-23 14:09:04 +00:00
'Test-Debian9-Clang-GCE-CPU-AVX2-x86_64-Debug-All-SafeStack',
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
]
Remove SkQP bot from master Bug: skia: Change-Id: I0415690911a52059eaaf7f32c81b7a4c66117d5b Reviewed-on: https://skia-review.googlesource.com/109162 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2018-02-21 21:29:28 +00:00
# Default properties used for TEST_BUILDERS.
Add SKQP bot to build universal APK to master Bug: skia: Change-Id: Ib0e9ddb621056ddce2422b53f312ec42d4d7aa3c Reviewed-on: https://skia-review.googlesource.com/107880 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2018-02-20 16:40:25 +00:00
defaultProps = lambda buildername: dict(
buildername=buildername,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
patch_set=2,
swarm_out_dir='[SWARM_OUT_DIR]'
)
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
def GenTests(api):
for buildername in TEST_BUILDERS:
test = (
api.test(buildername) +
Add SKQP bot to build universal APK to master Bug: skia: Change-Id: Ib0e9ddb621056ddce2422b53f312ec42d4d7aa3c Reviewed-on: https://skia-review.googlesource.com/107880 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2018-02-20 16:40:25 +00:00
api.properties(**defaultProps(buildername))
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
)
Add Pixelbook to tree Bug: skia:7249 NOTRY=true Change-Id: I7ab6bc28d567ca5ae75df9c1e56b46c307032024 Reviewed-on: https://skia-review.googlesource.com/66143 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-11-02 13:34:08 +00:00
if 'Chromebook' in buildername and not 'Build' in buildername:
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
test += api.step_data(
'read chromeos ip',
stdout=api.raw_io.output('{"user_ip":"foo@127.0.0.1"}'))
Use ssh to trigger chromecast test Using adb seemed to ignore errors in some cases, primarily if nanobench crashed/hung. Bug: skia:6706 Change-Id: I5def49d5b4d20bed6c486b7e85040190be856ac8 Reviewed-on: https://skia-review.googlesource.com/18404 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-06-01 19:49:41 +00:00
if 'Chromecast' in buildername:
test += api.step_data(
'read chromecast ip',
stdout=api.raw_io.output('192.168.1.2:5555'))
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
yield test
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
builder = 'Test-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-All'
Recipes: remove some pragma: no cover These are the remaining instances, and they're harder to deal with: $ git grep pragma recipe_modules/swarming/api.py: except self.m.step.StepFailure as e: # pragma: no cover recipe_modules/swarming/api.py: if len(ids) > 1: # pragma: nocover recipes/ct_skps.py: if api.path.exists(version_file): # pragma: nocover recipes/ct_skps.py: if api.path.exists(blacklist_file): # pragma: nocover recipes/upload_nano_results.py: if len(results) != 1: # pragma: nocover Bug: skia:6473 Change-Id: If75e2ffcf39a944b513b9005bbc4bd9c4fb031f6 Reviewed-on: https://skia-review.googlesource.com/13867 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 18:39:21 +00:00
yield (
api.test('exceptions') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]',
is_testing_exceptions='True')
)
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
builder = 'Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Debug-All-Android'
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
yield (
api.test('failed_infra_step') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]') +
Change force_quarantine to use bot id Bug: skia:7639 Change-Id: I4b8337bac996062c41fb9ae7460cf214b7524a46 Reviewed-on: https://skia-review.googlesource.com/111300 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-03-01 14:21:38 +00:00
api.step_data('get swarming bot id',
stdout=api.raw_io.output('build123-m2--device5')) +
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
api.step_data('dump log', retcode=1)
)
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
builder = 'Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Debug-All-Android'
Reland Recipes: Use strict coverage, part 2 Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
2017-04-19 17:36:00 +00:00
yield (
api.test('failed_read_version') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]') +
api.step_data('read /sdcard/revenge_of_the_skiabot/SK_IMAGE_VERSION',
retcode=1)
)
Retry adb commands on flaky devices. No-Try: true Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f Reviewed-on: https://skia-review.googlesource.com/43564 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-08 18:06:38 +00:00
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
builder = 'Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Debug-All-Android'
Retry adb commands on flaky devices. No-Try: true Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f Reviewed-on: https://skia-review.googlesource.com/43564 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-08 18:06:38 +00:00
yield (
api.test('retry_adb_command') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]') +
api.step_data('mkdir /sdcard/revenge_of_the_skiabot/resources',
retcode=1)
)
Add in test_filter to build configuration The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-10-16 01:05:58 +00:00
builder = 'Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Debug-All-Android'
Retry adb commands on flaky devices. No-Try: true Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f Reviewed-on: https://skia-review.googlesource.com/43564 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-08 18:06:38 +00:00
fail_step_name = 'mkdir /sdcard/revenge_of_the_skiabot/resources'
yield (
api.test('retry_adb_command_retries_exhausted') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]') +
Change force_quarantine to use bot id Bug: skia:7639 Change-Id: I4b8337bac996062c41fb9ae7460cf214b7524a46 Reviewed-on: https://skia-review.googlesource.com/111300 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2018-03-01 14:21:38 +00:00
api.step_data('get swarming bot id',
stdout=api.raw_io.output('build123-m2--device5')) +
Retry adb commands on flaky devices. No-Try: true Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f Reviewed-on: https://skia-review.googlesource.com/43564 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2017-09-08 18:06:38 +00:00
api.step_data(fail_step_name, retcode=1) +
api.step_data(fail_step_name + ' (attempt 2)', retcode=1) +
api.step_data(fail_step_name + ' (attempt 3)', retcode=1)
)
Make CPU scaling code cleaner This also makes *sure* the CPU frequency we set the device to actually "takes". Along the way, I learned if scaling_max_freq is < the frequency we set, the scaling_max_freq will be used instead, which was happening to the PixelCs and AndroidOnes. As a result, this may make those two Test- configs faster. Bug: skia: Change-Id: I10c98d37e296a19e1cf67bfe7269bb59cdd912d5 Reviewed-on: https://skia-review.googlesource.com/74360 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-11-21 21:47:16 +00:00
yield (
api.test('cpu_scale_failed') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]') +
Experiment with turning CPUs off during perf Perf was nice and flat after https://skia-review.googlesource.com/c/skia/+/83240 but there was a 4-5x slowdown on the benchmarks themselves, indicating that perhaps we were running nanobench on the LITTLE cores (now on powersave) instead of the big cores we thought (which were recently scaled down). This experiment will show us FOR CERTAIN that we are running on core 0 or 1 which is at .6 max frequency. We expect to see a speedup from the previous results. This is leading to turning of CPUs we don't need to make sure nanobench is running on the ones we expect. Bug: skia: NOTRY=true Change-Id: Ida65181e4d90e778e65e3f22d761288b9ade64f6 Reviewed-on: https://skia-review.googlesource.com/84201 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
2017-12-12 20:57:20 +00:00
api.step_data('Scale CPU 0 to 0.600000', retcode=1)
Make CPU scaling code cleaner This also makes *sure* the CPU frequency we set the device to actually "takes". Along the way, I learned if scaling_max_freq is < the frequency we set, the scaling_max_freq will be used instead, which was happening to the PixelCs and AndroidOnes. As a result, this may make those two Test- configs faster. Bug: skia: Change-Id: I10c98d37e296a19e1cf67bfe7269bb59cdd912d5 Reviewed-on: https://skia-review.googlesource.com/74360 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
2017-11-21 21:47:16 +00:00
)
Only uninstall if install failed. This is a followup to https://skia-review.googlesource.com/c/skia/+/90343, which causes task durations to increase due to copying over images, skps, etc. on every run. Bug: skia:7408 Change-Id: I42e829e287b7343e969159ac19c587a87ebe99e8 No-Try: true Reviewed-on: https://skia-review.googlesource.com/90942 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
2018-01-04 16:29:15 +00:00
builder = 'Test-iOS-Clang-iPhone7-GPU-GT7600-arm64-Release-All'
fail_step_name = 'install_dm'
yield (
api.test('retry_ios_install') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]') +
api.step_data(fail_step_name, retcode=1)
)
yield (
api.test('retry_ios_install_retries_exhausted') +
api.properties(buildername=builder,
repository='https://skia.googlesource.com/skia.git',
revision='abc123',
path_config='kitchen',
swarm_out_dir='[SWARM_OUT_DIR]') +
api.step_data(fail_step_name, retcode=1) +
api.step_data(fail_step_name + ' (attempt 2)', retcode=1)
)
Reference in New Issue Copy Permalink