AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
f3b1a751cb
skia2/tools/flags/CommonFlags.h

47 lines
1.4 KiB
C
Raw Normal View History

share dm and command flags Share command flags between dm and unit tests. Also, allow dm's core to be included by itself and iOSShell. Command line flags that are the same (or nearly the same) in DM and in skia_tests have been moved to common_flags. Authors, please check to see that the shared common flag is correct for the tool. For iOS, the 'tool_main' entry point has a wrapper to allow multiple tools to be statically linked in the iOSShell. Since SkCommandLineFlags::Parse can only be called once, these calls are disabled in the IOS build. Since the iOS app directory is dynamically assigned a name, use '@' to select it. (This is the same convention chosen by the Mobile Harness iOS file system utilities.) Move the heart of dm.gyp into dm.gypi so that it can be included by itself and iOSShell.gyp. Add tools/flags/SkCommonFlags.* to define and declare common command line flags. Add support for dm to iOSShell. BUG=skia: R=scroggo@google.com, mtklein@google.com, jvanverth@google.com, bsalomon@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/389653004
2014-07-22 17:15:34 +00:00
/*
* Copyright 2014 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
de-common the rest of the flags Turns out lots of tools had two copies of many of these flags. Some GN and .cpp file refactoring to make sure when flags are present in a binary, they do something in that binary. I think this finally finishes the flag refrag. Change-Id: I01488e37ab73a5c4361786863ddb137a7f1095b1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203420 Commit-Queue: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-25 15:54:59 +00:00
#pragma once
share dm and command flags Share command flags between dm and unit tests. Also, allow dm's core to be included by itself and iOSShell. Command line flags that are the same (or nearly the same) in DM and in skia_tests have been moved to common_flags. Authors, please check to see that the shared common flag is correct for the tool. For iOS, the 'tool_main' entry point has a wrapper to allow multiple tools to be statically linked in the iOSShell. Since SkCommandLineFlags::Parse can only be called once, these calls are disabled in the IOS build. Since the iOS app directory is dynamically assigned a name, use '@' to select it. (This is the same convention chosen by the Mobile Harness iOS file system utilities.) Move the heart of dm.gyp into dm.gypi so that it can be included by itself and iOSShell.gyp. Add tools/flags/SkCommonFlags.* to define and declare common command line flags. Add support for dm to iOSShell. BUG=skia: R=scroggo@google.com, mtklein@google.com, jvanverth@google.com, bsalomon@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/389653004
2014-07-22 17:15:34 +00:00
rewrite includes to not need so much -Ifoo Current strategy: everything from the top Things to look at first are the manual changes: - added tools/rewrite_includes.py - removed -Idirectives from BUILD.gn - various compile.sh simplifications - tweak tools/embed_resources.py - update gn/find_headers.py to write paths from the top - update gn/gn_to_bp.py SkUserConfig.h layout so that #include "include/config/SkUserConfig.h" always gets the header we want. No-Presubmit: true Change-Id: I73a4b181654e0e38d229bc456c0d0854bae3363e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/209706 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
2019-04-23 17:05:21 +00:00
#include "include/core/SkString.h"
#include "include/private/SkTArray.h"
#include "tools/flags/CommandLineFlags.h"
share dm and command flags Share command flags between dm and unit tests. Also, allow dm's core to be included by itself and iOSShell. Command line flags that are the same (or nearly the same) in DM and in skia_tests have been moved to common_flags. Authors, please check to see that the shared common flag is correct for the tool. For iOS, the 'tool_main' entry point has a wrapper to allow multiple tools to be statically linked in the iOSShell. Since SkCommandLineFlags::Parse can only be called once, these calls are disabled in the IOS build. Since the iOS app directory is dynamically assigned a name, use '@' to select it. (This is the same convention chosen by the Mobile Harness iOS file system utilities.) Move the heart of dm.gyp into dm.gypi so that it can be included by itself and iOSShell.gyp. Add tools/flags/SkCommonFlags.* to define and declare common command line flags. Add support for dm to iOSShell. BUG=skia: R=scroggo@google.com, mtklein@google.com, jvanverth@google.com, bsalomon@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/389653004
2014-07-22 17:15:34 +00:00
Treat bad values passed to --images as a fatal error If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
2016-02-03 20:19:11 +00:00
/**
remove Sk prefix from CommandLineFlags The command line flag package is tool-only, not part of Skia per se, and does not need an Sk prefix to avoid naming conflicts. And git clang-format. Change-Id: Ida8477779e51750ed0475590ed2454841b23d6ea Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202307 Auto-Submit: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-20 15:50:33 +00:00
* Helper to assist in collecting image paths from |dir| specified through a command line
* flag.
Treat bad values passed to --images as a fatal error If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
2016-02-03 20:19:11 +00:00
*
Add ColorCodecSrc for testing/comparison on color corrected decodes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933753002 Review-Url: https://codereview.chromium.org/1933753002
2016-04-29 16:38:40 +00:00
* Populates |output|, an array of strings with paths to images to test.
Treat bad values passed to --images as a fatal error If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
2016-02-03 20:19:11 +00:00
*
Add ColorCodecSrc for testing/comparison on color corrected decodes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933753002 Review-Url: https://codereview.chromium.org/1933753002
2016-04-29 16:38:40 +00:00
* Returns true if each argument to the images flag is meaningful:
Treat bad values passed to --images as a fatal error If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
2016-02-03 20:19:11 +00:00
* - If the file/directory does not exist, return false.
Add ColorCodecSrc for testing/comparison on color corrected decodes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933753002 Review-Url: https://codereview.chromium.org/1933753002
2016-04-29 16:38:40 +00:00
* - If |dir| does not have any supported images (based on file type), return false.
* - If |dir| is a single file, assume the user is deliberately testing this image,
* regardless of file type.
Treat bad values passed to --images as a fatal error If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
2016-02-03 20:19:11 +00:00
*/
remove Sk prefix from CommandLineFlags The command line flag package is tool-only, not part of Skia per se, and does not need an Sk prefix to avoid naming conflicts. And git clang-format. Change-Id: Ida8477779e51750ed0475590ed2454841b23d6ea Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202307 Auto-Submit: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-20 15:50:33 +00:00
bool CollectImages(CommandLineFlags::StringArray dir, SkTArray<SkString>* output);
Treat bad values passed to --images as a fatal error If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
2016-02-03 20:19:11 +00:00
Fold CommonFlagsGpu into CommonFlags This scopes a bunch of flags more tightly to SetCtxOptionsFromCommonFlags(). Change-Id: I6090a016880c085fb5405a45081c0af984a1cd5b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203094 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-22 16:08:02 +00:00
/**
* Helper to set GrContextOptions from common GPU flags, including
* --gpuThreads
* --cachePathMasks
Add an "allPathsVolatile" option for testing Bug: skia:10419 Change-Id: I4bb2dc515448d8c87329ade90d24bf78ca1d7938 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/319097 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-09-23 17:55:27 +00:00
* --allPathsVolatile
Add a flag for suppressing tessellation shaders Change-Id: Ic29618c5eac9b3eed92ce0321162745645240d6c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285142 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2020-04-23 17:44:26 +00:00
* --(no)gs
* --(no)ts
Add gms that test limited hw tessellation segments Adds variations of trickycubicstrokes and widebuttcaps that limit the max number of hardware tessellation segments to 5. This exercises our stroking logic for splitting curves and joins when they require more segments than are supported by the hardware. Bug: skia:10419 Change-Id: Ie52374b89e30bfa021b2de74e3cd32e02ab734d0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317268 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
2020-09-17 18:16:54 +00:00
* --maxTessellationSegments
Fold CommonFlagsGpu into CommonFlags This scopes a bunch of flags more tightly to SetCtxOptionsFromCommonFlags(). Change-Id: I6090a016880c085fb5405a45081c0af984a1cd5b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203094 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-22 16:08:02 +00:00
* --pr
Move --internalSamples to common flags Change-Id: I3120ca817f5fe3dc5969b6b875473f38c2fb8ea2 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261667 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
2019-12-27 20:47:25 +00:00
* --internalSamples
Fold CommonFlagsGpu into CommonFlags This scopes a bunch of flags more tightly to SetCtxOptionsFromCommonFlags(). Change-Id: I6090a016880c085fb5405a45081c0af984a1cd5b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203094 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-22 16:08:02 +00:00
* --disableDriverCorrectnessWorkarounds
Reland "Merge GrOpList and GrRTOpList and rename to GrOpsTask." This reverts commit f21bf9e50bb175eb151e90a01d7f8351da0802f8. Reason for revert: relanding with infra fix Original change's description: > Revert "Merge GrOpList and GrRTOpList and rename to GrOpsTask." > > This reverts commit 2a5954140b49d18e5161a30a4ae2c7ac28bc1993. > > Reason for revert: breaking everything > > Original change's description: > > Merge GrOpList and GrRTOpList and rename to GrOpsTask. > > > > Change-Id: I8f4f2218a30fd0541a8f79f7bb9850f9500cd243 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236343 > > Commit-Queue: Greg Daniel <egdaniel@google.com> > > Reviewed-by: Brian Salomon <bsalomon@google.com> > > TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com > > Change-Id: I27840ea0343e8e6b388556afb7bd2e76386d611d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236349 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Ibd3a06e4a91dbb1f225dcc8d17d0db3967b6f85f No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/236350 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
2019-08-22 20:19:24 +00:00
* --reduceOpsTaskSplitting
* --dontReduceOpsTaskSplitting
Fold CommonFlagsGpu into CommonFlags This scopes a bunch of flags more tightly to SetCtxOptionsFromCommonFlags(). Change-Id: I6090a016880c085fb5405a45081c0af984a1cd5b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203094 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-22 16:08:02 +00:00
*/
void SetCtxOptionsFromCommonFlags(struct GrContextOptions*);
factor out SetAnalyticAAFromCommonFlags() This wraps up the behavior for --analyticAA and --forceAnalyticAA in one place, like we've done for the various GPU flags covered by SetCtxOptionsFromCommonFlags(). It seems at least midly useful to have common flags centralized when there is really a common mechanism they control. Most of the rest of these flags only serve analogous purposes in the various binaries that use them, and I think it might be better for them to be split out rather than centralized (so they don't show up confusingly in binaries that _don't_ use them). Change-Id: I27dbe53586363d4b262c1679ea73138015811ed1 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/203095 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
2019-03-22 16:39:09 +00:00
/**
* Enable, disable, or force analytic anti-aliasing using --analyticAA and --forceAnalyticAA.
*/
void SetAnalyticAAFromCommonFlags();
Reference in New Issue Copy Permalink