skia2/resources/sksl/errors/ArrayUnspecifiedDimensions.rts

int arrUnsized[];
int arrFloat[1.];
int arrBool[true];

int unsized_in_expression() { return int[](0)[0]; }

/*%%*
expected array dimension
array size must be an integer
array size must be an integer
missing index in '[]'
*%%*/
Rename Runtime Effect-compatible ES2 error tests to .rts. This is useful because it will allow these tests to be supported in Android CTS, where only Runtime Effects are API-accessible. This CL updates the C++ test harness so that .rts files in the error/ directory are found, and tweaks error tests as necessary to make them Runtime Effect-compatible. For instance, Runtime Effects enforce the parameters on main(), which adds extra errors that we don't want. And some error tests require ES3 (e.g. array constructors) and so those tests remain as .sksl files. In this CL, only tests beginning with A are updated. The remaining tests will be updated in followup CLs. Change-Id: I70b064df4f0b3ed02d6bc8cc9add7ee844a78691 Bug: skia:13042 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/522424 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> 2022-03-21 14:56:03 +00:00			`int arrUnsized[];`
			`int arrFloat[1.];`
			`int arrBool[true];`
Enforce (valid) array sizes in many more places Unsized arrays are now allowed in exactly one place: On the declaration of an interface block. This satisfies the one existing use-case, which is the gl_in (sk_in) declaration for geometry shaders. There is no other useful scenario, and most of our backends don't support them anyway. Several spots were using less strict checks when attaching sizes to arrays, allowing for zero or negative-sized arrays, so those are all fixed now. The existing tests that initialize arrays are still a problem, because Metal doesn't support that (neither does GLES2). Also, ArrayConstructors has gone from generating an error in the Vulkan backend, to invalid SPIR-V. Bug: skia:11013 Bug: skia:11127 Change-Id: Ib08dfe9aeec96bf605661665d6f166419d27e8bc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/353817 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> 2021-01-14 19:18:10 +00:00
			`int unsized_in_expression() { return int[](0)[0]; }`
Add expected errors to every test file. This was (crudely) automated with shell scripts: http://go/paste/5484300603490304 Change-Id: Ic9e1c93112772d303d1158eb26d995f27b439eba Bug: skia:12665 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/505637 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com> 2022-02-08 17:19:26 +00:00
			`/%%`
			`expected array dimension`
			`array size must be an integer`
			`array size must be an integer`
			`missing index in '[]'`
			`%%/`