AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Implement readPixels from float buffer, when half float is missing

Browse Source 
If reading in half float format is not supported, then read in a
temporary float buffer and convert to half float. This is used by
SwiftShader emulator.

Bug: skia:6945
Bug: b/68383159
Test: Passed PixelCopyTest.testWindowProducerCopyToRGBA16F
Change-Id: I1bfc72e65e4db596ac15d4a1ac31b20e6aea6d30
Reviewed-on: https://skia-review.googlesource.com/68860
Commit-Queue: Stan Iliev <stani@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
This commit is contained in:
Stan Iliev 2017-11-08 14:16:26 -05:00 committed by Skia Commit-Bot
parent bb4b48945d
commit 0078ab2251
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/gpu/gl/GrGLGpu.cpp
View File

@ -26,6 +26,7 @@
#include "GrTexturePriv.h"
#include "GrTypes.h"
#include "SkAutoMalloc.h"
#include "SkHalf.h"
#include "SkJSONWriter.h"
#include "SkMakeUnique.h"
#include "SkMipMap.h"
@ -2281,6 +2282,10 @@ bool GrGLGpu::onGetReadPixelsInfo(GrSurface* srcSurface, GrSurfaceOrigin srcOrig
SkASSERT(tempDrawInfo->fTempSurfaceDesc.fConfig == srcConfig);
SkASSERT(tempDrawInfo->fReadConfig == kAlpha_8_GrPixelConfig);
}
} else if (readConfig == kRGBA_half_GrPixelConfig &&
this->readPixelsSupported(srcSurface, kRGBA_float_GrPixelConfig)) {
// If reading in half float format is not supported, then read in float format.
return true;
} else if (this->glCaps().canConfigBeFBOColorAttachment(readConfig) &&
this->readPixelsSupported(readConfig, readConfig)) {
// Do a draw to convert from the src config to the read config.
@ -2341,6 +2346,29 @@ bool GrGLGpu::onReadPixels(GrSurface* surface, GrSurfaceOrigin origin,
return true;
}
}
// If reading in half float format is not supported, then read in a temporary float buffer
// and convert to half float.
if (kRGBA_half_GrPixelConfig == config &&
this->readPixelsSupported(surface, kRGBA_float_GrPixelConfig)) {
std::unique_ptr<float[]> temp(new float[width * height * 4]);
if (this->onReadPixels(surface, origin, left, top, width, height,
kRGBA_float_GrPixelConfig, temp.get(),
width*sizeof(float)*4)) {
uint8_t* dst = reinterpret_cast<uint8_t*>(buffer);
float* src = temp.get();
for (int j = 0; j < height; ++j) {
SkHalf* dstRow = reinterpret_cast<SkHalf*>(dst);
for (int i = 0; i < width; ++i) {
for (int color = 0; color < 4; color++) {
*dstRow++ = SkFloatToHalf(*src++);
}
}
dst += rowBytes;
}
return true;
}
}
return false;
}