AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove CFG-based check for missing value-returns.

Browse Source 
This check is redundant; we now determine this at function finalization
time (http://review.skia.org/379056) and error out before this check
can be reached.

Change-Id: I1706adb90435b430883d7d1ab44cb5dc98fccd8c
Bug: skia:11377
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/379836
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
This commit is contained in:
John Stiles 2021-03-04 18:15:56 -05:00
parent 532138cea7
commit 0404933136
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/sksl/SkSLCompiler.cpp
View File

@ -1389,14 +1389,6 @@ bool Compiler::scanCFG(FunctionDefinition& f, ProgramUsage* usage) {
} while (optimizationContext.fUpdated); } while (optimizationContext.fUpdated);
SkASSERT(!optimizationContext.fNeedsRescan); SkASSERT(!optimizationContext.fNeedsRescan);
// check for missing return
if (f.declaration().returnType() != *fContext->fTypes.fVoid) {
if (cfg.fBlocks[cfg.fExit].fIsReachable) {
this->error(f.fOffset, String("function '" + String(f.declaration().name()) +
"' can exit without returning a value"));
}
}
return madeChanges; return madeChanges;
} }