Miscellaneous gpu cleanup

Encountered while creating a presentation

Change-Id: I16962f089d263504644cc6b5f17d35644ff2099d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/539056
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>

src/gpu/ganesh/BaseDevice.h

@@ -24,14 +24,7 @@ namespace v1 { class SurfaceDrawContext; }
 #endif // SK_GPU_V1
 
 /*
- * The most important thing to remember about this class hierarchy is there is no skgpu::SDC
- * base class so the v1 and v2 Devices privately hold their own version of the SDC. The best
- * the BaseDevice can do is to return the SDC-variant as a generic SFC.
- *
- *                             skgpu::BaseDevice
- *                           /                   \
- *                     v1::Device           v2::Device
- *                       - v1::SDC              - v2::SDC
+ * This class is left over from the initial v1/v2 split. It should be merged into the v1::Device.
  */
 class BaseDevice : public SkBaseDevice {
 public:

src/gpu/ganesh/SurfaceContext.h

@@ -40,12 +40,10 @@ class SurfaceFillContext;
  *            SurfaceContext
  *                   |
  *          SurfaceFillContext
- *           /               \
- *     v1::SFC               v2::SFC
- *        |                     |
- *        |                     |
- *        |                     |
- *     v1::SDC               v2::SDC
+ *                   |
+ *                v1::SFC
+ *                   |
+ *               v1::SDC
  *
  */
 class SurfaceContext {

src/gpu/ganesh/SurfaceFillContext.h

@@ -12,6 +12,8 @@
 
 namespace skgpu {
 
+// This class is left over from the v1/v2 split. It should be merged back into
+// v1::SurfaceFillContext.
 class SurfaceFillContext : public SurfaceContext {
 public:
 

src/gpu/ganesh/mock/GrMockRenderTask.h

@@ -10,7 +10,7 @@
 
 #include "src/gpu/ganesh/GrRenderTask.h"
 
-class GrMockRenderTask : public GrRenderTask {
+class GrMockRenderTask final : public GrRenderTask {
 public:
     GrMockRenderTask() : GrRenderTask() {
         // Mock tasks are never "owned" by a drawmgr in the first place.

src/gpu/ganesh/ops/AtlasRenderTask.h

@@ -24,7 +24,7 @@ namespace skgpu::v1 {
 //
 // The atlas texture does not get instantiated automatically. It is the creator's responsibility to
 // call instantiate() at flush time.
-class AtlasRenderTask : public OpsTask {
+class AtlasRenderTask final : public OpsTask {
 public:
     AtlasRenderTask(GrRecordingContext*,
                     sk_sp<GrArenas>,

src/gpu/ganesh/ops/GrOvalOpFactory.cpp

@@ -1811,7 +1811,7 @@ private:
 
 ///////////////////////////////////////////////////////////////////////////////
 
-class EllipseOp : public GrMeshDrawOp {
+class EllipseOp final : public GrMeshDrawOp {
 private:
     using Helper = GrSimpleMeshDrawOpHelper;
 
@@ -2103,7 +2103,7 @@ private:
 
 /////////////////////////////////////////////////////////////////////////////////////////////////
 
-class DIEllipseOp : public GrMeshDrawOp {
+class DIEllipseOp final : public GrMeshDrawOp {
 private:
     using Helper = GrSimpleMeshDrawOpHelper;
 
@@ -2502,7 +2502,7 @@ static const uint16_t* rrect_type_to_indices(RRectType type) {
 //   each vertex is also given the normalized x & y distance from the interior rect's edge
 //      the GP takes the min of those depths +1 to get the normalized distance to the outer edge
 
-class CircularRRectOp : public GrMeshDrawOp {
+class CircularRRectOp final : public GrMeshDrawOp {
 private:
     using Helper = GrSimpleMeshDrawOpHelper;
 
@@ -2867,7 +2867,7 @@ static sk_sp<const GrBuffer> get_rrect_index_buffer(RRectType type,
     }
 }
 
-class EllipticalRRectOp : public GrMeshDrawOp {
+class EllipticalRRectOp final : public GrMeshDrawOp {
 private:
     using Helper = GrSimpleMeshDrawOpHelper;