Pass rietveld as the default patch_storage.

Passing around empty strings as command line arguments requires
us to be really careful about command line quoting, parsing, etc.

It seems easy enough here to just supply the implied value.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323233003

Review-Url: https://codereview.chromium.org/2323233003
This commit is contained in:
mtklein 2016-09-15 08:27:33 -07:00 committed by Commit bot
parent e839e78443
commit 0973a371ec
6 changed files with 7 additions and 7 deletions

View File

@ -108,7 +108,7 @@ class SkiaVarsApi(recipe_api.RecipeApi):
self.default_env.update({'SKIA_OUT': self.skia_out,
'BUILDTYPE': self.configuration})
self.is_trybot = self.builder_cfg['is_trybot']
self.patch_storage = self.m.properties.get('patch_storage', '')
self.patch_storage = self.m.properties.get('patch_storage', 'rietveld')
self.issue = None
self.patchset = None
if self.is_trybot:

View File

@ -167,7 +167,7 @@
"patchset",
"1",
"patch_storage",
"",
"rietveld",
"--key",
"arch",
"x86_64",

View File

@ -167,7 +167,7 @@
"patchset",
"1",
"patch_storage",
"",
"rietveld",
"--key",
"arch",
"x86_64",

View File

@ -148,7 +148,7 @@
"patchset",
"1",
"patch_storage",
"",
"rietveld",
"--svgs",
"[SLAVE_BUILD]/svg",
"--key",
@ -447,7 +447,7 @@
"patchset",
"1",
"patch_storage",
""
"rietveld"
],
"cwd": "[SLAVE_BUILD]/skia",
"env": {

View File

@ -200,7 +200,7 @@
"patchset",
"1",
"patch_storage",
"",
"rietveld",
"--svgs",
"[SLAVE_BUILD]\\svg",
"--key",

View File

@ -200,7 +200,7 @@
"patchset",
"1",
"patch_storage",
"",
"rietveld",
"--svgs",
"[SLAVE_BUILD]\\svg",
"--key",