AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable QCOM_tiled_rendering while we wait for test devices

Browse Source 
There are devices that advertise this extension but don't actually
provide the GL entrypoints. This is causing live crashes.

Bug: flutter:47164
Bug: flutter:47804
Change-Id: Idded47e8dbd4462463ad91a62b06b0df3245f0c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263809
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This commit is contained in:
Chris Dalton 2020-01-10 17:45:44 -07:00 committed by Skia Commit-Bot
parent a3a704afa3
commit 0a1923e507
3 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gpu/gl/GrGLCaps.cpp
View File

@ -697,9 +697,11 @@ void GrGLCaps::init(const GrContextOptions& contextOptions,
fSamplerObjectSupport = version >= GR_GL_VER(2,0);
}
if (GR_IS_GR_GL_ES(standard)) {
fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
}
// https://github.com/flutter/flutter/issues/47164
// https://github.com/flutter/flutter/issues/47804
// if (GR_IS_GR_GL_ES(standard)) {
// fTiledRenderingSupport = ctxInfo.hasExtension("GL_QCOM_tiled_rendering");
// }
FormatWorkarounds formatWorkarounds;

5
src/gpu/gl/GrGLInterfaceAutogen.cpp
View File

@ -351,10 +351,7 @@ bool GrGLInterface::validate() const {
if ((GR_IS_GR_GL_ES(fStandard) && (
fExtensions.has("GL_QCOM_tiled_rendering")))) {
if (!fFunctions.fEndTiling ||
!fFunctions.fStartTiling) {
RETURN_FALSE_INTERFACE;
}
// all functions were marked optional or test_only
}
if ((GR_IS_GR_GL(fStandard) && (

5
tools/gpu/gl/interface/interface.json5
View File

@ -300,6 +300,11 @@
"functions": [
"StartTiling", "EndTiling",
],
// https://github.com/flutter/flutter/issues/47164
// https://github.com/flutter/flutter/issues/47804
"optional": [
"StartTiling", "EndTiling",
]
},