AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

make SpecialLineRec::addSegment assert more permissive to accomodate rounding error

Browse Source 
Because the driving code that calls SpecialLineRec::addSegment uses double precision,
when converted back to single precision this may round such that d0 and d1 are the same.
This causes the assert to trigger. The simplest thing to do here is to modify the assert
to not be so picky and allow the rare/occasional equality.

Downstream Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1290628

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209303004

Review-Url: https://codereview.chromium.org/2209303004
This commit is contained in:
lsalzman 2016-08-08 13:40:27 -07:00 committed by Commit bot
parent c97796b47b
commit 0adbd3e0a6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/utils/SkDashPath.cpp
View File

@ -186,7 +186,7 @@ public:
} }
void addSegment(SkScalar d0, SkScalar d1, SkPath* path) const { void addSegment(SkScalar d0, SkScalar d1, SkPath* path) const {
SkASSERT(d0 < fPathLength); SkASSERT(d0 <= fPathLength);
// clamp the segment to our length // clamp the segment to our length
if (d1 > fPathLength) { if (d1 > fPathLength) {
d1 = fPathLength; d1 = fPathLength;