From 0cb3175c07b2e5147e06a6b65681a50e46627341 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Mon, 18 Mar 2019 15:39:12 -0500 Subject: [PATCH] lift main-thread limit on iOS bots I noticed this today while working on something else. Looks like we added --threads 0 hoping it'd help something on iOS a long time ago, and we decided it had no effect, but didn't revert the change. Bug: skia:6748 Change-Id: I4fb6722ae79ca21d1f7ee96bcb31b8ffb5319143 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/202010 Commit-Queue: Mike Klein Reviewed-by: Stephan Altmueller --- ...iOS-Clang-iPadPro-GPU-PowerVRGT7800-arm64-Release-All.json | 2 -- infra/bots/recipes/test.py | 4 ---- 2 files changed, 6 deletions(-) diff --git a/infra/bots/recipes/test.expected/Test-iOS-Clang-iPadPro-GPU-PowerVRGT7800-arm64-Release-All.json b/infra/bots/recipes/test.expected/Test-iOS-Clang-iPadPro-GPU-PowerVRGT7800-arm64-Release-All.json index 62a95c8c33..07f3435936 100644 --- a/infra/bots/recipes/test.expected/Test-iOS-Clang-iPadPro-GPU-PowerVRGT7800-arm64-Release-All.json +++ b/infra/bots/recipes/test.expected/Test-iOS-Clang-iPadPro-GPU-PowerVRGT7800-arm64-Release-All.json @@ -660,8 +660,6 @@ "--dont_write", "pdf", "--randomProcessorTest", - "--threads", - "0", "--nocpu", "--config", "gles", diff --git a/infra/bots/recipes/test.py b/infra/bots/recipes/test.py index 18cafeeeaf..befd5b5e70 100644 --- a/infra/bots/recipes/test.py +++ b/infra/bots/recipes/test.py @@ -87,10 +87,6 @@ def dm_flags(api, bot): if 'Test' in bot and 'DISCARDABLE' in bot: thread_limit = MAIN_THREAD_ONLY - # See if staying on the main thread helps skia:6748. - if 'Test-iOS' in bot: - thread_limit = MAIN_THREAD_ONLY - if thread_limit is not None: args.extend(['--threads', str(thread_limit)])