AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Respect wrap mode when decimating for blur

Browse Source 
It used to be the case that bilerp wasn't supported for shader-based
repeats and mirrors, but that is no longer the case. If we switched
to ClampToBorder in those cases, we could introduce transparent black
into the decimated image that would then infect the final blur.

Bug: skia:10145
Change-Id: Ie273b4d64f082be3ddbdbf54acf201ff1fdfa133
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/283940
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>
This commit is contained in:
Michael Ludwig 2020-04-16 10:17:57 -04:00 committed by Skia Commit-Bot
parent 8390f2ead6
commit 0dca280047
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/core/SkGpuBlurUtils.cpp
View File

@ -300,14 +300,7 @@ static GrSurfaceProxyView decimate(GrRecordingContext* context,
GrPaint paint;
std::unique_ptr<GrFragmentProcessor> fp;
if (i == 1) {
GrSamplerState::WrapMode wrapMode;
if (mode == SkTileMode::kClamp) {
wrapMode = GrSamplerState::WrapMode::kClamp;
} else {
// GrTextureEffect does not support WrapMode::k[Mirror]Repeat with
// GrSamplerState::Filter::kBilerp. So we use kClampToBorder.
wrapMode = GrSamplerState::WrapMode::kClampToBorder;
}
GrSamplerState::WrapMode wrapMode = SkTileModeToWrapMode(mode);
const auto& caps = *context->priv().caps();
GrSamplerState sampler(wrapMode, GrSamplerState::Filter::kBilerp);
fp = GrTextureEffect::MakeSubset(std::move(srcView), srcAlphaType, SkMatrix::I(),