AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

use /imsvc with clang-cl where we use -isystem

Browse Source 
This should disable warnings from third-party headers
on Clang/Win builds.  So far we've just gotten lucky.

Change-Id: Ieaf459e200925d46d8c65ba8d489db111705b125
Reviewed-on: https://skia-review.googlesource.com/c/191283
Commit-Queue: Mike Klein <mtklein@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
This commit is contained in:
Mike Klein 2019-02-11 12:18:24 -05:00 committed by Skia Commit-Bot
parent 27f830257b
commit 10af5ecfaa
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
third_party/third_party.gni vendored
View File

@ -11,8 +11,15 @@ template("third_party") {
if (defined(invoker.public_defines)) {
defines = invoker.public_defines
}
if (is_win) {
if (is_win && !is_clang) {
include_dirs = invoker.public_include_dirs
} else if (is_win && is_clang) {
foreach(dir, invoker.public_include_dirs) {
cflags += [
"/imsvc",
rebase_path(dir),
]
}
} else {
foreach(dir, invoker.public_include_dirs) {
cflags += [