AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove TecnoSpark adv. blend workaround.

Browse Source 
This workaround has not stopped long shaders from randomly failing
to compile on TecnoSpark Pro 3. It just stops us from generating some
shaders that fail to compile in unit tests.

Also, it reveals rendering issue when framebuffer fetch is used with
MSAA on this device (instead of adv. blending).

Change-Id: I8026ded6d0d75743dc2c508df5c4ffc207d8b5a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/261736
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
This commit is contained in:
Brian Salomon 2019-12-30 09:18:55 -05:00 committed by Skia Commit-Bot
parent 63d32153ad
commit 115ca68b6b
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/gpu/gl/GrGLCaps.cpp
View File

@ -3625,20 +3625,6 @@ void GrGLCaps::applyDriverCorrectnessWorkarounds(const GrGLContextInfo& ctxInfo,
shaderCaps->fAdvBlendEqInteraction = GrShaderCaps::kNotSupported_AdvBlendEqInteraction;
}
// Advanced blending can cause shader compilation to fail with message
// "Interface block type in this shader".
// on some shaders that use advanced blending on the line:
// "layout (blend_support_all_equations) out;"
// It has been triggered multiple times in the random Programs test, particularly on longer
// shaders. This was seen on a Tecno Spark 3 Pro with a PowerVR Rogue GE8300 running Android P
// driver version "1.10@5130912". It's unknown if it is fixed on later driver versions.
if (ctxInfo.vendor() == kImagination_GrGLVendor &&
ctxInfo.driverVersion() < GR_GL_DRIVER_VER(1, 11, 0) &&
fBlendEquationSupport != kBasic_BlendEquationSupport) {
fBlendEquationSupport = kBasic_BlendEquationSupport;
shaderCaps->fAdvBlendEqInteraction = GrShaderCaps::kNotSupported_AdvBlendEqInteraction;
}
if (fDriverBugWorkarounds.disable_blend_equation_advanced) {
fBlendEquationSupport = kBasic_BlendEquationSupport;
shaderCaps->fAdvBlendEqInteraction = GrShaderCaps::kNotSupported_AdvBlendEqInteraction;