AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add unit tests for src=dst in SkGeometry

Browse Source 
Bug: skia:
Change-Id: Iee0beaa187898f01983f5cb7297d8b515e47103a
Reviewed-on: https://skia-review.googlesource.com/146926
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>
This commit is contained in:
Chris Dalton 2018-08-13 00:20:33 -06:00 committed by Skia Commit-Bot
parent 8d868e5ca9
commit 1208e0fc80
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/GeometryTest.cpp
View File

@ -35,6 +35,16 @@ static void testChopCubic(skiatest::Reporter* reporter) {
if (false) { // avoid bit rot, suppress warning if (false) { // avoid bit rot, suppress warning
REPORTER_ASSERT(reporter, count); REPORTER_ASSERT(reporter, count);
} }
// Make sure src and dst can be the same pointer.
SkPoint pts[7];
for (int i = 0; i < 7; ++i) {
pts[i].set(i, i);
}
SkChopCubicAt(pts, pts, .5f);
for (int i = 0; i < 7; ++i) {
REPORTER_ASSERT(reporter, pts[i].fX == pts[i].fY);
REPORTER_ASSERT(reporter, pts[i].fX == i * .5f);
}
} }
static void check_pairs(skiatest::Reporter* reporter, int index, SkScalar t, const char name[], static void check_pairs(skiatest::Reporter* reporter, int index, SkScalar t, const char name[],
@ -328,24 +338,24 @@ static void test_classify_cubic(skiatest::Reporter* reporter) {
} }
DEF_TEST(Geometry, reporter) { DEF_TEST(Geometry, reporter) {
SkPoint pts[3], dst[5]; SkPoint pts[5];
pts[0].set(0, 0); pts[0].set(0, 0);
pts[1].set(100, 50); pts[1].set(100, 50);
pts[2].set(0, 100); pts[2].set(0, 100);
int count = SkChopQuadAtMaxCurvature(pts, dst); int count = SkChopQuadAtMaxCurvature(pts, pts); // Ensure src and dst can be the same pointer.
REPORTER_ASSERT(reporter, count == 1 || count == 2); REPORTER_ASSERT(reporter, count == 1 || count == 2);
pts[0].set(0, 0); pts[0].set(0, 0);
pts[1].set(3, 0); pts[1].set(3, 0);
pts[2].set(3, 3); pts[2].set(3, 3);
SkConvertQuadToCubic(pts, dst); SkConvertQuadToCubic(pts, pts);
const SkPoint cubic[] = { const SkPoint cubic[] = {
{ 0, 0, }, { 2, 0, }, { 3, 1, }, { 3, 3 }, { 0, 0, }, { 2, 0, }, { 3, 1, }, { 3, 3 },
}; };
for (int i = 0; i < 4; ++i) { for (int i = 0; i < 4; ++i) {
REPORTER_ASSERT(reporter, nearly_equal(cubic[i], dst[i])); REPORTER_ASSERT(reporter, nearly_equal(cubic[i], pts[i]));
} }
testChopCubic(reporter); testChopCubic(reporter);