AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable DDL assert to unblock Chrome

Browse Source 
Chrome is replaying DDLs into FBO 0 which impacts several rendering capabilities. FBO 0-ness of the final destination currently isn't part of SkSurfaceCharacterization so the surface flags aren't being set appropriately for the expected capabilities.

Bug: skia:7748
Change-Id: I0d2bf3f689f8f75990443a0d5959f016d16f5d97
Reviewed-on: https://skia-review.googlesource.com/116188
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This commit is contained in:
Robert Phillips 2018-03-23 14:20:42 -04:00 committed by Skia Commit-Bot
parent a6e30f75fc
commit 12a68422ad
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/gpu/GrSurfaceProxy.cpp
View File

@ -181,8 +181,10 @@ void GrSurfaceProxy::assign(sk_sp<GrSurface> surface) {
SkASSERT(!fTarget && surface);
// Check that our a priori computation matched the ultimate reality
SkASSERT((fSurfaceFlags & ~GrInternalSurfaceFlags::kNoPendingIO) ==
surface->surfacePriv().flags());
// DDL TODO: re-enable this after skbug.com/7748 (Add FBO-0-ness to SkSurfaceCharacterization)
// is fixed.
// SkASSERT((fSurfaceFlags & ~GrInternalSurfaceFlags::kNoPendingIO) ==
// surface->surfacePriv().flags());
fTarget = surface.release();