AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix floating-point overflow error check on OS X 10.12.

Browse Source 
We no longer enforce a particular string form of 3.41e+38.

Change-Id: I33b8a30aa3c7ab54de0c7f4a02181b60cd8f71a3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/505799
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This commit is contained in:
John Stiles 2022-02-08 14:36:36 -05:00
parent b86ab9d097
commit 12b6796407
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
resources/sksl/errors/OverflowFloatLiteral.sksl
View File

@ -1,8 +1,7 @@
void main() {
sk_FragColor.x = half4(3.41e+38);
sk_FragColor = half4(3.41e+38);
}
/*%%*
floating-point value is too large: 3.41e+38
type mismatch: '=' cannot operate on 'half', 'half4'
floating-point value is too large:
*%%*/

3
tests/sksl/errors/OverflowFloatLiteral.glsl
View File

@ -1,5 +1,4 @@
### Compilation failed:
error: 2: floating-point value is too large: 3.41e+38
error: 2: type mismatch: '=' cannot operate on 'half', 'half4'
2 errors
1 error