AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Test CodecImageGenerator on GPU bots

Browse Source 
In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes,
so that we can test on a GPU bot. Update the arguments to DM so that
we run CodecImageGenerator on GPU bots.

This is adapted from:
https://codereview.chromium.org/1663453002/

This will cause many untriaged images on Gold.
The GPU converts YUV->RGBA differently than we
do in software.

BUG=skia:4888
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676663002

Review URL: https://codereview.chromium.org/1676663002
This commit is contained in:
msarett 2016-02-08 09:10:47 -08:00 committed by Commit bot
parent 3c69348e72
commit 13a036b7eb
3 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dm/DMSrcSink.cpp
View File

@ -855,6 +855,14 @@ Error GPUSink::draw(const Src& src, SkBitmap* dst, SkWStream*, SkString* log) co
const SkISize size = src.size();
const SkImageInfo info =
SkImageInfo::Make(size.width(), size.height(), kN32_SkColorType, kPremul_SkAlphaType);
#if SK_SUPPORT_GPU
const int maxDimension = factory.getContextInfo(fContextType, fContextOptions).
fGrContext->caps()->maxTextureSize();
if (maxDimension < SkTMax(size.width(), size.height())) {
return Error::Nonfatal("Src too large to create a texture.\n");
}
#endif
SkAutoTUnref<SkSurface> surface(
NewGpuSurface(&factory, fContextType, fContextOptions, info, fSampleCount, fUseDIText));
if (!surface) {

7
tools/dm_flags.json
View File

@ -232,6 +232,7 @@
"--src",
"tests",
"gm",
"image",
"--blacklist",
"serialize-8888",
"gm",
@ -434,6 +435,7 @@
"--src",
"tests",
"gm",
"image",
"--threads",
"0",
"--blacklist",
@ -636,6 +638,7 @@
"--src",
"tests",
"gm",
"image",
"--threads",
"0",
"--blacklist",
@ -842,6 +845,7 @@
"--src",
"tests",
"gm",
"image",
"--blacklist",
"serialize-8888",
"gm",
@ -1042,6 +1046,7 @@
"--src",
"tests",
"gm",
"image",
"--blacklist",
"serialize-8888",
"gm",
@ -2474,6 +2479,7 @@
"--src",
"tests",
"gm",
"image",
"--blacklist",
"pdf",
"gm",
@ -2717,6 +2723,7 @@
"--src",
"tests",
"gm",
"image",
"--blacklist",
"msaa16",
"gm",

8
tools/dm_flags.py
View File

@ -80,13 +80,9 @@ def get_args(bot):
args.append('--config')
args.extend(configs)
# Run tests and gms everywhere,
# and image decoding tests everywhere except GPU bots.
# Run tests, gms, and image decoding tests everywhere.
# TODO: remove skp from default --src list?
if 'GPU' in bot:
args.extend('--src tests gm'.split(' '))
else:
args.extend('--src tests gm image'.split(' '))
args.extend('--src tests gm image'.split(' '))
if 'GalaxyS' in bot:
args.extend(('--threads', '0'))