AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove SK_SUPPORT_LEGACY_GRADIENT_ALPHATRUNC dead code

Browse Source 
The guard is no longer used in Chrome.

(https://chromium-review.googlesource.com/c/539715)

Change-Id: Ib78527a11002a2992af71adce4ed4b8261ed8ead
Reviewed-on: https://skia-review.googlesource.com/20281
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>
This commit is contained in:
Florin Malita 2017-06-19 15:40:45 -04:00 committed by Skia Commit-Bot
parent ae7bb04f4c
commit 15200bd8b3
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/shaders/gradients/SkLinearGradient.cpp
View File

@ -560,9 +560,6 @@ template <bool apply_alpha> SkPMColor trunc_from_255(const Sk4f& x, const Sk4f&
SkPMColor c; SkPMColor c;
Sk4f c4f255 = x; Sk4f c4f255 = x;
if (apply_alpha) { if (apply_alpha) {
#ifdef SK_SUPPORT_LEGACY_GRADIENT_ALPHATRUNC
static constexpr float alphaScale = 1;
#else
// Due to use of multiplication by the 1/255 reciprocal instead of division by 255, // Due to use of multiplication by the 1/255 reciprocal instead of division by 255,
// non-integer alpha values very close to their ceiling can push the color values // non-integer alpha values very close to their ceiling can push the color values
// above the alpha value, which will become an invalid premultiplied color. So nudge // above the alpha value, which will become an invalid premultiplied color. So nudge
@ -572,7 +569,7 @@ template <bool apply_alpha> SkPMColor trunc_from_255(const Sk4f& x, const Sk4f&
// scaled by the alpha value, we need to scale the epsilon by 255 to get a safe // scaled by the alpha value, we need to scale the epsilon by 255 to get a safe
// upper bound on the error. // upper bound on the error.
static constexpr float alphaScale = 1 + 255*std::numeric_limits<float>::epsilon(); static constexpr float alphaScale = 1 + 255*std::numeric_limits<float>::epsilon();
#endif
const float scale = x[SkPM4f::A] * (1 / 255.f); const float scale = x[SkPM4f::A] * (1 / 255.f);
c4f255 *= Sk4f(scale, scale, scale, alphaScale); c4f255 *= Sk4f(scale, scale, scale, alphaScale);
} }