Exclude URLs only for some page sets

Bug: skia:7348
Change-Id: Iabf4c0d0bf83a0caeeb06027e5617a18900ac5fc
Reviewed-on: https://skia-review.googlesource.com/77180
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
This commit is contained in:
Ravi Mistry 2017-11-29 08:38:12 -05:00 committed by Skia Commit-Bot
parent 373588426b
commit 19ea45ef53

View File

@ -115,6 +115,11 @@ CHROMIUM_PAGE_SETS_TO_PREFIX = {
'top_25_smooth.py': 'top25desk',
}
PAGE_SETS_TO_EXCLUSIONS = {
# See skbug.com/7348
'key_mobile_sites_smooth.py': '"(digg|worldjournal)"',
}
def remove_prefix(s, prefix):
if s.startswith(prefix):
@ -278,7 +283,7 @@ class SkPicturePlayback(object):
# Get the webpages archive so that it can be replayed.
self._DownloadWebpagesArchive(wpr_data_file, page_set_json_name)
run_benchmark_cmd = (
run_benchmark_cmd = [
'PYTHONPATH=%s:%s:$PYTHONPATH' % (page_set_dir, self._catapult_dir),
'DISPLAY=%s' % X11_DISPLAY,
'timeout', '1800',
@ -291,9 +296,11 @@ class SkPicturePlayback(object):
'--page-set-base-dir=%s' % page_set_dir,
'--skp-outdir=%s' % TMP_SKP_DIR,
'--also-run-disabled-tests',
# See skbug.com/7348
'--story-filter-exclude="(digg|worldjournal)"',
)
]
exclusions = PAGE_SETS_TO_EXCLUSIONS.get(os.path.basename(page_set))
if exclusions:
run_benchmark_cmd.append('--story-filter-exclude=' + exclusions)
for _ in range(RETRY_RUN_MEASUREMENT_COUNT):
try: