bug fixes from PVS Studio (static analysis)

- Hal, please check out SkPDFCanon... was this unused?
  - Cary, please SkOpContour... is it right that allDone isn't necessary?
  - Brian, the rest?

Bug: chromium:805881

Change-Id: I7cbbcf44f4460a114f4ed2a59ed3856203049cdc
Reviewed-on: https://skia-review.googlesource.com/99960
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Hal Canary <halcanary@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

src/core/SkPathRef.cpp

@@ -771,9 +771,6 @@ bool SkPathRef::isValid() const {
     if (nullptr == fPoints && 0 != fFreeSpace) {
         return false;
     }
-    if (nullptr == fPoints && 0 != fFreeSpace) {
-        return false;
-    }
     if (nullptr == fPoints && fPointCnt) {
         return false;
     }

src/gpu/gl/GrGLGpu.cpp

@@ -3314,7 +3314,7 @@ static inline bool can_blit_framebuffer_for_copy_surface(
     // have filtered such cases out.
     SkASSERT(GrPixelConfigIsSint(dst->config()) == GrPixelConfigIsSint(src->config()));
     const GrGLTexture* dstTex = static_cast<const GrGLTexture*>(dst->asTexture());
-    const GrGLTexture* srcTex = static_cast<const GrGLTexture*>(dst->asTexture());
+    const GrGLTexture* srcTex = static_cast<const GrGLTexture*>(src->asTexture());
     const GrRenderTarget* dstRT = dst->asRenderTarget();
     const GrRenderTarget* srcRT = src->asRenderTarget();
     if (dstTex && dstTex->target() != GR_GL_TEXTURE_2D) {

src/gpu/gl/builders/GrGLProgramBuilder.cpp

@@ -274,10 +274,10 @@ GrGLProgram* GrGLProgramBuilder::finalize() {
             // store shader in cache
             sk_sp<SkData> key = SkData::MakeWithoutCopy(desc()->asKey(), desc()->keyLength());
             GrGLenum binaryFormat;
-            std::unique_ptr<char> binary(new char[length]);
+            std::unique_ptr<char[]> binary(new char[length]);
             GL_CALL(GetProgramBinary(programID, length, &length, &binaryFormat, binary.get()));
             size_t dataLength = sizeof(inputs) + sizeof(binaryFormat) + length;
-            std::unique_ptr<uint8_t> data((uint8_t*) malloc(dataLength));
+            std::unique_ptr<uint8_t[]> data(new uint8_t[dataLength]);
             size_t offset = 0;
             memcpy(data.get() + offset, &inputs, sizeof(inputs));
             offset += sizeof(inputs);

src/gpu/ops/GrNonAAFillRectOp.cpp

@@ -273,7 +273,7 @@ public:
         SkString str;
         str.appendf("# combined: %d\n", fRects.count());
         for (int i = 0; i < fRects.count(); ++i) {
-            const RectInfo& geo = fRects[0];
+            const RectInfo& geo = fRects[i];
             str.appendf("%d: Color: 0x%08x, Rect [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n", i,
                         geo.fColor, geo.fRect.fLeft, geo.fRect.fTop, geo.fRect.fRight,
                         geo.fRect.fBottom);

src/pathops/SkOpContour.cpp

@@ -32,17 +32,13 @@ void SkOpContour::toReversePath(SkPathWriter* path) const {
 
 SkOpSpan* SkOpContour::undoneSpan() {
     SkOpSegment* testSegment = &fHead;
-    bool allDone = true;
     do {
         if (testSegment->done()) {
             continue;
         }
-        allDone = false;
         return testSegment->undoneSpan();
     } while ((testSegment = testSegment->next()));
-    if (allDone) {
+    fDone = true;
-      fDone = true;
-    }
     return nullptr;
 }
 

src/pdf/SkPDFCanon.h

@@ -64,6 +64,6 @@ public:
 };
 
 inline bool operator==(const SkPDFCanon::BitmapGlyphKey& u, const SkPDFCanon::BitmapGlyphKey& v) {
-    return memcmp(&u, &u, sizeof(SkPDFCanon::BitmapGlyphKey)) == 0;
+    return memcmp(&u, &v, sizeof(SkPDFCanon::BitmapGlyphKey)) == 0;
 }
 #endif  // SkPDFCanon_DEFINED