AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

rebaseline_server was not allowing tests to be marked ignore-failure

Browse Source 
(SkipBuildbotRuns)
TBR=jcgregorio

Review URL: https://codereview.chromium.org/59063005

git-svn-id: http://skia.googlecode.com/svn/trunk@12143 2bbb7eff-a529-9590-31e7-b0007b416f81
This commit is contained in:
epoger@google.com 2013-11-05 21:00:24 +00:00
parent 56ad44b53a
commit 1e698afbc2
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gm/rebaseline_server/static/loader.js
View File

@ -64,7 +64,7 @@ Loader.controller(
$scope.showSubmitAdvancedSettings = false; $scope.showSubmitAdvancedSettings = false;
$scope.submitAdvancedSettings = {}; $scope.submitAdvancedSettings = {};
$scope.submitAdvancedSettings['reviewed-by-human'] = true; $scope.submitAdvancedSettings['reviewed-by-human'] = true;
$scope.submitAdvancedSettings['ignore-failures'] = false; $scope.submitAdvancedSettings['ignore-failure'] = false;
$scope.submitAdvancedSettings['bug'] = ''; $scope.submitAdvancedSettings['bug'] = '';
// Create the list of tabs (lists into which the user can file each // Create the list of tabs (lists into which the user can file each
@ -368,7 +368,7 @@ Loader.controller(
$scope.submitAdvancedSettings['reviewed-by-human']; $scope.submitAdvancedSettings['reviewed-by-human'];
if (true == $scope.submitAdvancedSettings['ignore-failure']) { if (true == $scope.submitAdvancedSettings['ignore-failure']) {
// if it's false, don't send it at all (just keep the default) // if it's false, don't send it at all (just keep the default)
expectedResult['ignoreFailure'] = true; expectedResult['ignore-failure'] = true;
} }
expectedResult['bugs'] = bugs; expectedResult['bugs'] = bugs;

2
gm/rebaseline_server/static/view.html
View File

@ -160,7 +160,7 @@
<input type="checkbox" ng-model="showSubmitAdvancedSettings"> <input type="checkbox" ng-model="showSubmitAdvancedSettings">
show show
<ul ng-hide="!showSubmitAdvancedSettings"> <ul ng-hide="!showSubmitAdvancedSettings">
<li ng-repeat="setting in ['reviewed-by-human', 'ignore-failures']"> <li ng-repeat="setting in ['reviewed-by-human', 'ignore-failure']">
{{setting}} {{setting}}
<input type="checkbox" ng-model="submitAdvancedSettings[setting]"> <input type="checkbox" ng-model="submitAdvancedSettings[setting]">
</li> </li>