Output location of rankings CSV and a link to download SKPs by rank
Example run: https://luci-milo.appspot.com/swarming/task/31cdda8d5cb95310 BUG=skia:5826 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3173 Change-Id: I56f4143e919f4328d0f573e8a4a4321eceb8564a Reviewed-on: https://skia-review.googlesource.com/3173 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
This commit is contained in:
parent
8f2996c59c
commit
1eab442602
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/100k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/100k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -409,7 +409,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
@ -1362,6 +1363,8 @@
|
||||
"@@@STEP_LOG_END@json.output@@@",
|
||||
"@@@STEP_LINK@shard #0 isolated out@blah@@@",
|
||||
"@@@STEP_LINK@view steps on Milo@https://luci-milo.appspot.com/swarming/task/148aa78d7aa0000@@@",
|
||||
"@@@STEP_LINK@Webpage rankings@https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv@@@",
|
||||
"@@@STEP_LINK@Download SKPs by rank@https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/@@@",
|
||||
"@@@STEP_FAILURE@@@"
|
||||
]
|
||||
},
|
||||
@ -1488,6 +1491,8 @@
|
||||
"@@@STEP_LOG_END@json.output@@@",
|
||||
"@@@STEP_LINK@shard #0 isolated out@blah@@@",
|
||||
"@@@STEP_LINK@view steps on Milo@https://luci-milo.appspot.com/swarming/task/148aa78d7aa0000@@@",
|
||||
"@@@STEP_LINK@Webpage rankings@https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv@@@",
|
||||
"@@@STEP_LINK@Download SKPs by rank@https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/@@@",
|
||||
"@@@STEP_FAILURE@@@"
|
||||
]
|
||||
},
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
@ -1486,6 +1487,8 @@
|
||||
"@@@STEP_LOG_END@json.output@@@",
|
||||
"@@@STEP_LINK@shard #0 isolated out@blah@@@",
|
||||
"@@@STEP_LINK@view steps on Milo@https://luci-milo.appspot.com/swarming/task/148aa78d7aa0000@@@",
|
||||
"@@@STEP_LINK@Webpage rankings@https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv@@@",
|
||||
"@@@STEP_LINK@Download SKPs by rank@https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/All/fad657e-276e633/@@@",
|
||||
"@@@STEP_FAILURE@@@"
|
||||
]
|
||||
},
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/100k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/100k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -389,7 +389,8 @@
|
||||
],
|
||||
"name": "Copy Go binary",
|
||||
"~followup_annotations": [
|
||||
"@@@SET_BUILD_PROPERTY@Location of SKPs@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
"@@@SET_BUILD_PROPERTY@Webpage rankings@\"https://storage.cloud.google.com/cluster-telemetry/csv/top-1m.csv\"@@@",
|
||||
"@@@SET_BUILD_PROPERTY@Download SKPs by rank@\"https://pantheon.corp.google.com/storage/browser/cluster-telemetry/swarming/skps/10k/fad657e-276e633/\"@@@"
|
||||
]
|
||||
},
|
||||
{
|
||||
|
@ -89,10 +89,17 @@ def RunSteps(api):
|
||||
skps_chromium_build = api.properties.get(
|
||||
'skps_chromium_build', DEFAULT_SKPS_CHROMIUM_BUILD)
|
||||
|
||||
# Set build property to make finding SKPs convenient.
|
||||
api.step.active_result.presentation.properties['Location of SKPs'] = (
|
||||
# Set build properties to make finding SKPs convenient.
|
||||
webpage_rankings_link = (
|
||||
'https://storage.cloud.google.com/%s/csv/top-1m.csv'
|
||||
% api.ct.CT_GS_BUCKET)
|
||||
api.step.active_result.presentation.properties['Webpage rankings'] = (
|
||||
webpage_rankings_link)
|
||||
download_skps_link = (
|
||||
'https://pantheon.corp.google.com/storage/browser/%s/swarming/skps/%s/%s/'
|
||||
% (api.ct.CT_GS_BUCKET, ct_page_type, skps_chromium_build))
|
||||
api.step.active_result.presentation.properties['Download SKPs by rank'] = (
|
||||
download_skps_link)
|
||||
|
||||
# Delete swarming_temp_dir to ensure it starts from a clean slate.
|
||||
api.run.rmtree(api.swarming.swarming_temp_dir)
|
||||
@ -215,6 +222,11 @@ def RunSteps(api):
|
||||
)
|
||||
|
||||
except api.step.StepFailure as e:
|
||||
# Add SKP links for convenience.
|
||||
api.step.active_result.presentation.links['Webpage rankings'] = (
|
||||
webpage_rankings_link)
|
||||
api.step.active_result.presentation.links['Download SKPs by rank'] = (
|
||||
download_skps_link)
|
||||
failed_tasks.append(e)
|
||||
|
||||
if failed_tasks:
|
||||
|
Loading…
Reference in New Issue
Block a user