From 210b629b32cfa67b5bb8ed7a5435380e2c2bfe36 Mon Sep 17 00:00:00 2001 From: Florin Malita Date: Fri, 26 Jan 2018 21:14:15 +0000 Subject: [PATCH] Revert "Simplify call when finished with bitmaps." This reverts commit ec48afdc2a345c0cd8d38983f5d241deddf8c7dd. Reason for revert: broke skdiff Original change's description: > Simplify call when finished with bitmaps. > > Bug: skia: > Change-Id: I841052bdaf68f6ec4c98a045712941f313a7b27b > Reviewed-on: https://skia-review.googlesource.com/94000 > Reviewed-by: Hal Canary TBR=halcanary@google.com,reed@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: skia: Change-Id: Ic3586eb42d7a6cd6c4708381272a6c87a8c5fb1c Reviewed-on: https://skia-review.googlesource.com/100360 Reviewed-by: Florin Malita Commit-Queue: Florin Malita --- tools/skdiff/skdiff_main.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/skdiff/skdiff_main.cpp b/tools/skdiff/skdiff_main.cpp index 9380785280..59e9b0a6b7 100644 --- a/tools/skdiff/skdiff_main.cpp +++ b/tools/skdiff/skdiff_main.cpp @@ -330,16 +330,10 @@ public: SkASSERT(drp != nullptr); } ~AutoReleasePixels() { -#if 0 fDrp->fBase.fBitmap.setPixelRef(nullptr, 0, 0); fDrp->fComparison.fBitmap.setPixelRef(nullptr, 0, 0); fDrp->fDifference.fBitmap.setPixelRef(nullptr, 0, 0); fDrp->fWhite.fBitmap.setPixelRef(nullptr, 0, 0); -#endif - fDrp->fBase.fBitmap.reset(); - fDrp->fComparison.fBitmap.reset(); - fDrp->fDifference.fBitmap.reset(); - fDrp->fWhite.fBitmap.reset(); } private: