AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unnecessary flush in RenderYUVAToRGBA (take 2)

Browse Source 
There is no real reason to flush here. If clients need to access the results immediately they should be flushing at the API level.

A reland of: https://skia-review.googlesource.com/c/skia/+/196645

It needs to land after the Chrome CL:

https://chromium-review.googlesource.com/c/chromium/src/+/1560554 (Flush pending work after calls to YUVGrBackendTexturesToSkImage)

Change-Id: I230d7433b5c1b72d8f50fd475033c942826eda94
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/206688
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This commit is contained in:
Robert Phillips 2019-04-10 09:43:14 -04:00 committed by Skia Commit-Bot
parent 14003828df
commit 223845f792
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/image/SkImage_GpuBase.cpp
View File

@ -373,10 +373,6 @@ bool SkImage_GpuBase::RenderYUVAToRGBA(GrContext* ctx, GrRenderTargetContext* re
paint.addColorFragmentProcessor(std::move(fp));
renderTargetContext->drawRect(GrNoClip(), std::move(paint), GrAA::kNo, SkMatrix::I(), rect);
// DDL TODO: in the promise image version we must not flush here
ctx->priv().flush(renderTargetContext->asSurfaceProxy());
return true;
}