AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Switch to using the gpu-ddl sink(s) to generate the DDL images

Browse Source 
The previous settings used the ddl-via - which doesn't use threads as effectively.

Change-Id: I82a0632d99c772421afc645f53bb749420275460
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/285812
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
This commit is contained in:
Robert Phillips 2020-05-04 09:20:00 -04:00 committed by Skia Commit-Bot
parent cdf23dd9f1
commit 2329db1171
2 changed files with 23 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
infra/bots/gen_tasks_logic/dm_flags.go
View File

@ -108,6 +108,13 @@ func (b *taskBuilder) dmFlags(internalHardwareLabel string) {
}
return rv
}
suffix := func(slice []string, sfx string) []string {
rv := make([]string, 0, len(slice))
for _, e := range slice {
rv = append(rv, e+sfx)
}
return rv
}
blacklist := func(quad ...string) {
if len(quad) == 1 {
@ -438,15 +445,14 @@ func (b *taskBuilder) dmFlags(internalHardwareLabel string) {
// DDL is a GPU-only feature
if b.extraConfig("DDL1") {
// This bot generates gl and vk comparison images for the large skps
// This bot generates comparison images for the large skps and the gms
configs = filter(configs, "gl", "vk", "mtl")
args = append(args, "--skpViewportSize", "2048")
args = append(args, "--pr", "~small")
}
if b.extraConfig("DDL3") {
// This bot generates the ddl-gl and ddl-vk images for the
// large skps and the gms
ddlConfigs := prefix(filter(configs, "gl", "vk", "mtl"), "ddl-")
// This bot generates the real ddl images for the large skps and the gms
ddlConfigs := suffix(filter(configs, "gl", "vk", "mtl"), "ddl")
ddl2Configs := prefix(filter(configs, "gl", "vk", "mtl"), "ddl2-")
configs = append(ddlConfigs, ddl2Configs...)
args = append(args, "--skpViewportSize", "2048")

26
infra/bots/tasks.json
View File

File diff suppressed because one or more lines are too long