AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Set mac_sdk_min=10.13 for CommandBuffer builds

Browse Source 
The default SDK version was changed in
https://chromium-review.googlesource.com/c/chromium/src/+/1711106, but
our bots don't have that version yet. This is causing failed rolls,
e.g. https://skia-review.googlesource.com/c/skia/+/231071.

The DEPS change was cherry-picked from
https://skia-review.googlesource.com/c/skia/+/231071.

Change-Id: Iddfa0c7cb8ef676bf6f6b2093c120afdd33513f7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/231097
Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com>
This commit is contained in:
Ben Wagner 2019-07-31 09:57:04 -04:00 committed by Skia Commit-Bot
parent d7cf0be186
commit 2891b87844
4 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
DEPS
View File

@ -35,7 +35,7 @@ deps = {
"third_party/externals/zlib" : "https://chromium.googlesource.com/chromium/src/third_party/zlib@47af7c547f8551bd25424e56354a2ae1e9062859",
"../src": {
"url": "https://chromium.googlesource.com/chromium/src.git@5c3e9d87e1942b7e03c45516cca96354495771d3",
"url": "https://chromium.googlesource.com/chromium/src.git@f6d0e4f58cbd1ef8e875ed4768f645247069e2db",
"condition": "checkout_chromium",
},
}

1
infra/bots/recipe_modules/build/default.py
View File

@ -20,6 +20,7 @@ def build_command_buffer(api, chrome_dir, skia_dir, out):
args=[
'--chrome-dir', chrome_dir,
'--output-dir', out,
'--extra-gn-args', 'mac_sdk_min="10.13"',
'--no-sync', '--no-hooks', '--make-output-dir'])

2
infra/bots/recipe_modules/build/examples/full.expected/Build-Mac-Clang-x86_64-Debug-CommandBuffer.json
View File

@ -43,6 +43,8 @@
"[START_DIR]/cache/work",
"--output-dir",
"[START_DIR]/cache/work/skia/out/Build-Mac-Clang-x86_64-Debug-CommandBuffer/Debug",
"--extra-gn-args",
"mac_sdk_min=\"10.13\"",
"--no-sync",
"--no-hooks",
"--make-output-dir"

2
infra/bots/recipes/sync_and_compile.expected/Build-Mac-Clang-x86_64-Debug-CommandBuffer.json
View File

@ -171,6 +171,8 @@
"[START_DIR]/cache/work",
"--output-dir",
"[START_DIR]/cache/work/skia/out/Build-Mac-Clang-x86_64-Debug-CommandBuffer/Debug",
"--extra-gn-args",
"mac_sdk_min=\"10.13\"",
"--no-sync",
"--no-hooks",
"--make-output-dir"