From 28987a418a0c9fd4ef8365f7d94aca96574dd9fa Mon Sep 17 00:00:00 2001 From: Robert Phillips Date: Thu, 12 Jul 2018 00:55:12 +0000 Subject: [PATCH] Revert "build debug on linux for gdb" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 3c3db72e69ef5dcdde57f1fbbd939579d50d96f1. Reason for revert: I suspect this is breaking the Build-Debian9-Clang-arm-Debug-Chromebook_GLES bot Original change's description: > build debug on linux for gdb > > Building with this define enables additional > checks for standard library functions when > running gdb, and allows printing std::string. > > R=​halcanary@google.com > > Bug: skia: > Change-Id: Ib71c179d8cbacbcd7f17a1c85f912072918e6be8 > Reviewed-on: https://skia-review.googlesource.com/140786 > Commit-Queue: Cary Clark > Reviewed-by: Mike Klein TBR=mtklein@google.com,halcanary@google.com,caryclark@google.com Change-Id: I56ae1c6c02032e6445f5585de51c48423d283636 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/140840 Reviewed-by: Robert Phillips Commit-Queue: Robert Phillips --- gn/BUILD.gn | 3 --- 1 file changed, 3 deletions(-) diff --git a/gn/BUILD.gn b/gn/BUILD.gn index ea6c8194a5..1d4cd7b035 100644 --- a/gn/BUILD.gn +++ b/gn/BUILD.gn @@ -209,9 +209,6 @@ config("default") { if (is_linux) { libs += [ "pthread" ] - if (is_debug && sanitize == "") { - defines += [ "_GLIBCXX_DEBUG" ] - } } if (is_mac) { # Disable linker warnings. They're usually just annoyances like,