Remove string.h from SkTypes.h

Change-Id: I2be84f37ea11a386206a96d2fef6e0fc9464e21b
Reviewed-on: https://skia-review.googlesource.com/135264
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>

include/core/SkMatrix44.h

@@ -8,11 +8,12 @@
 #ifndef SkMatrix44_DEFINED
 #define SkMatrix44_DEFINED
 
-#include <atomic>
-
 #include "SkMatrix.h"
 #include "SkScalar.h"
 
+#include <atomic>
+#include <cstring>
+
 #ifdef SK_MSCALAR_IS_DOUBLE
 #ifdef SK_MSCALAR_IS_FLOAT
     #error "can't define MSCALAR both as DOUBLE and FLOAT"

include/core/SkTypes.h

@@ -16,7 +16,6 @@
 #include <stdint.h>
 // IWYU pragma: end_exports
 
-#include <string.h>
 #include <utility>
 
 /** \file SkTypes.h

include/gpu/gl/GrGLFunctions.h

@@ -12,6 +12,8 @@
 #include "GrGLTypes.h"
 #include "../private/SkTLogic.h"
 
+#include <cstring>
+
 extern "C" {
 
 ///////////////////////////////////////////////////////////////////////////////

include/private/SkFloatingPoint.h

@@ -13,6 +13,8 @@
 #include "SkSafe_math.h"
 #include <float.h>
 #include <math.h>
+#include <cstring>
+
 
 #if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSE1
     #include <xmmintrin.h>

src/effects/SkPackBits.cpp

@@ -6,9 +6,10 @@
  */
 
 #include "SkPackBits.h"
-
 #include "SkTo.h"
 
+#include <cstring>
+
 size_t SkPackBits::ComputeMaxSize8(size_t srcSize) {
     // worst case is the number of 8bit values + 1 byte per (up to) 128 entries.
     return ((srcSize + 127) >> 7) + srcSize;

src/gpu/GrAutoLocaleSetter.h

@@ -20,6 +20,7 @@
 
 #if defined(SK_BUILD_FOR_MAC) || defined(SK_BUILD_FOR_IOS)
 #include <xlocale.h>
+#include <cstring>
 #define HAVE_XLOCALE 1
 #else
 #define HAVE_XLOCALE 0