AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

SkPDF: Remove Array's unused set(i) and get(i) (leaving only append())

Browse Source 
BUG=skia:3585

Review URL: https://codereview.chromium.org/1071583003
This commit is contained in:
halcanary 2015-04-08 08:40:36 -07:00 committed by Commit bot
parent e4579adfdf
commit 2ad228e8ff
3 changed files with 1 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pdf/SkPDFTypes.cpp
View File

@ -255,14 +255,6 @@ void SkPDFArray::reserve(int length) {
fValue.setReserve(length);
}
SkPDFObject* SkPDFArray::setAt(int offset, SkPDFObject* value) {
SkASSERT(offset < fValue.count());
value->ref();
fValue[offset]->unref();
fValue[offset] = value;
return value;
}
SkPDFObject* SkPDFArray::append(SkPDFObject* value) {
SkASSERT(fValue.count() < kMaxLen);
value->ref();

12
src/pdf/SkPDFTypes.h
View File

@ -250,18 +250,6 @@ public:
*/
void reserve(int length);
/** Returns the object at the given offset in the array.
* @param index The index into the array to retrieve.
*/
SkPDFObject* getAt(int index) { return fValue[index]; }
/** Set the object at the given offset in the array. Ref's value.
* @param index The index into the array to set.
* @param value The value to add to the array.
* @return The value argument is returned.
*/
SkPDFObject* setAt(int index, SkPDFObject* value);
/** Append the object to the end of the array and increments its ref count.
* @param value The value to add to the array.
* @return The value argument is returned.

5
tests/PDFPrimitivesTest.cpp
View File

@ -269,9 +269,6 @@ DEF_TEST(PDFPrimitives, reporter) {
SkAutoTUnref<SkPDFInt> int0(new SkPDFInt(0));
array->append(int0.get());
SimpleCheckObjectOutput(reporter, array.get(), "[42 0.5 0]");
SkAutoTUnref<SkPDFInt> int1(new SkPDFInt(1));
array->setAt(0, int1.get());
SimpleCheckObjectOutput(reporter, array.get(), "[1 0.5 0]");
SkAutoTUnref<SkPDFDict> dict(new SkPDFDict);
SimpleCheckObjectOutput(reporter, dict.get(), "<<>>");
@ -283,7 +280,7 @@ DEF_TEST(PDFPrimitives, reporter) {
dict->insert(n2.get(), realHalf.get());
dict->insert(n3.get(), array.get());
SimpleCheckObjectOutput(reporter, dict.get(),
"<</n1 42\n/n2 0.5\n/n3 [1 0.5 0]>>");
"<</n1 42\n/n2 0.5\n/n3 [42 0.5 0]>>");
TestPDFStream(reporter);