AuroraMiddleware/skia2
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Use inline storage for SkEdgeBuilder."

Browse Source 
This reverts commit be32a432af.

Reason for revert: Google3 stacks are smaller than you might hope.  "the frame size of 25584 bytes is larger than 16384 bytes; see http://go/big_stack_frame"

Original change's description:
> Use inline storage for SkEdgeBuilder.
> 
> Change-Id: I06d9ee759a366d6c2c11341e15e671f5a1f87ae7
> Reviewed-on: https://skia-review.googlesource.com/9164
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Herb Derby <herb@google.com>
> 

TBR=herb@google.com,liyuqian@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I496e37754977c598f3cf30c7a0fbc4954a58152c
Reviewed-on: https://skia-review.googlesource.com/9181
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
This commit is contained in:
Mike Klein 2017-03-02 22:04:55 +00:00 committed by Skia Commit-Bot
parent 9169d807b1
commit 2b46f3eff9
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/SkEdgeBuilder.cpp
View File

@ -14,7 +14,9 @@
///////////////////////////////////////////////////////////////////////////////
SkEdgeBuilder::SkEdgeBuilder() : fEdgeList{nullptr} {}
SkEdgeBuilder::SkEdgeBuilder() : fAlloc(16*1024) {
fEdgeList = nullptr;
}
SkEdgeBuilder::Combine SkEdgeBuilder::CombineVertical(const SkEdge* edge, SkEdge* last) {
if (last->fCurveCount || last->fDX || edge->fX != last->fX) {

3
src/core/SkEdgeBuilder.h
View File

@ -42,8 +42,7 @@ private:
bool vertical_line(const SkEdge* edge);
bool vertical_line(const SkAnalyticEdge* edge);
char fStorage[8*1024];
SkArenaAlloc fAlloc{fStorage};
SkArenaAlloc fAlloc;
SkTDArray<void*> fList;
/*