From 3150839b598e99855af42b84e5ce554e96cf0855 Mon Sep 17 00:00:00 2001 From: John Stiles Date: Wed, 17 Mar 2021 16:59:07 -0400 Subject: [PATCH] Disable CommaSideEffects test on GPU. This test causes the Adreno 330 driver to crash, and does not pass on Quadro P400 in wasm. The CPU test confirms that we can get it right, even if not all drivers do. Change-Id: I5ffb72ac647a49dab7130ab2c6e94f587ded6cf9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/386216 Commit-Queue: John Stiles Commit-Queue: Brian Osman Auto-Submit: John Stiles Reviewed-by: Brian Osman --- tests/SkSLTest.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/SkSLTest.cpp b/tests/SkSLTest.cpp index b0a7dd0eac..4469df46d3 100644 --- a/tests/SkSLTest.cpp +++ b/tests/SkSLTest.cpp @@ -151,7 +151,9 @@ SKSL_TEST(SkSLArrayTypes, "shared/ArrayTypes.sksl") SKSL_TEST(SkSLAssignment, "shared/Assignment.sksl") SKSL_TEST(SkSLCastsRoundTowardZero, "shared/CastsRoundTowardZero.sksl") SKSL_TEST(SkSLCommaMixedTypes, "shared/CommaMixedTypes.sksl") -SKSL_TEST(SkSLCommaSideEffects, "shared/CommaSideEffects.sksl") +// This test causes the Adreno 330 driver to crash, and does not pass on Quadro P400 in wasm. +// The CPU test confirms that we can get it right, even if not all drivers do. +SKSL_TEST_CPU(SkSLCommaSideEffects, "shared/CommaSideEffects.sksl") SKSL_TEST(SkSLConstantIf, "shared/ConstantIf.sksl") SKSL_TEST(SkSLConstVariableComparison, "shared/ConstVariableComparison.sksl") SKSL_TEST(SkSLDeadIfStatement, "shared/DeadIfStatement.sksl")